linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: linux-arch@vger.kernel.org
Cc: mmarek@suse.cz, geert@linux-m68k.org, ralf@linux-mips.org,
	lethal@linux-sh.org, jdike@addtoit.com, gxt@mprc.pku.edu.cn,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net,
	Richard Weinberger <richard@nod.at>,
	Ramkumar Ramachandra <artagnon@gmail.com>
Subject: [PATCH 2/8] um: Do not use SUBARCH
Date: Wed, 21 Aug 2013 10:19:26 +0200	[thread overview]
Message-ID: <1377073172-3662-3-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1377073172-3662-1-git-send-email-richard@nod.at>

From now on UML does no longer depend on SUBARCH and will
never silently change CONFIG_64BIT.

"make defconfig ARCH=um" produces now a .config with is suitable
for your host arch.

"make i386_defconfig ARCH=um" replaces "make defconfig ARCH=um SUBARCH=i386"
"and make x86_64_defconfig ARCH=um" replaces "make defconfig ARCH=um SUBARCH=x86_64"

Finally a "make ARCH=um" will produce an UML as described in your .config and you
don't have to worry about setting the correct SUBARCH.

This patch is based on: https://lkml.org/lkml/2013/7/4/396

Cc: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/Kconfig.common |  4 ----
 arch/um/Makefile       | 21 +++++++++++----------
 arch/x86/Makefile.um   |  2 +-
 arch/x86/um/Kconfig    |  6 +++---
 4 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
index bceee66..a7ef0b4 100644
--- a/arch/um/Kconfig.common
+++ b/arch/um/Kconfig.common
@@ -58,7 +58,3 @@ config GENERIC_BUG
 config HZ
 	int
 	default 100
-
-config SUBARCH
-	string
-	option env="SUBARCH"
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 133f7de..5bc7892 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -8,6 +8,8 @@
 
 ARCH_DIR := arch/um
 OS := $(shell uname -s)
+OS_ARCH := $(shell uname -m)
+
 # We require bash because the vmlinux link and loader script cpp use bash
 # features.
 SHELL := /bin/bash
@@ -20,15 +22,14 @@ core-y			+= $(ARCH_DIR)/kernel/		\
 
 MODE_INCLUDE	+= -I$(srctree)/$(ARCH_DIR)/include/shared/skas
 
-HEADER_ARCH 	:= $(SUBARCH)
-
-# Additional ARCH settings for x86
-ifeq ($(SUBARCH),i386)
-        HEADER_ARCH := x86
-endif
-ifeq ($(SUBARCH),x86_64)
-        HEADER_ARCH := x86
-	KBUILD_CFLAGS += -mcmodel=large
+# Currently we support only i386 and x86_64, if you port UML to another arch
+# add another if branch...
+ifeq ($(OS_ARCH),x86_64)
+	HEADER_ARCH := x86
+	KBUILD_DEFCONFIG := x86_64_defconfig
+else
+	HEADER_ARCH := x86
+	KBUILD_DEFCONFIG := i386_defconfig
 endif
 
 HOST_DIR := arch/$(HEADER_ARCH)
@@ -155,4 +156,4 @@ endef
 include/generated/user_constants.h: $(HOST_DIR)/um/user-offsets.s
 	$(call filechk,gen-asm-offsets)
 
-export SUBARCH USER_CFLAGS CFLAGS_NO_HARDENING OS DEV_NULL_PATH
+export USER_CFLAGS CFLAGS_NO_HARDENING OS DEV_NULL_PATH
diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um
index 36b62bc..91d088c 100644
--- a/arch/x86/Makefile.um
+++ b/arch/x86/Makefile.um
@@ -40,7 +40,7 @@ else
 
 START := 0x60000000
 
-KBUILD_CFLAGS += -fno-builtin -m64 
+KBUILD_CFLAGS += -fno-builtin -m64 -mcmodel=large
 
 CHECKFLAGS  += -m64 -D__x86_64__
 KBUILD_AFLAGS += -m64
diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index 14ef8d1..bb6df67 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -1,4 +1,4 @@
-mainmenu "User Mode Linux/$SUBARCH $KERNELVERSION Kernel Configuration"
+mainmenu "User Mode Linux $KERNELVERSION Kernel Configuration"
 
 source "arch/um/Kconfig.common"
 
@@ -15,8 +15,8 @@ config UML_X86
 	select GENERIC_FIND_FIRST_BIT
 
 config 64BIT
-	bool "64-bit kernel" if SUBARCH = "x86"
-	default SUBARCH != "i386"
+	bool "64-bit kernel"
+	default n
 
 config X86_32
 	def_bool !64BIT
-- 
1.8.1.4

  parent reply	other threads:[~2013-08-21  8:19 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  8:19 [RFC] Get rid of SUBARCH Richard Weinberger
2013-08-21  8:19 ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 1/8] um: Create defconfigs for i386 and x86_64 Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-22  4:55   ` Stephen Rothwell
2013-08-22  4:55     ` Stephen Rothwell
2013-09-26 10:20   ` Ramkumar Ramachandra
2013-09-26 10:35     ` Richard Weinberger
2013-09-26 10:35       ` Richard Weinberger
2013-09-26 11:57       ` Ramkumar Ramachandra
2013-09-26 11:57         ` Ramkumar Ramachandra
2013-09-26 12:04         ` Richard Weinberger
2013-09-26 12:04           ` Richard Weinberger
2013-09-27  9:22       ` Toralf Förster
2013-09-27  9:22         ` Toralf Förster
2013-09-27  9:26         ` Richard Weinberger
2013-09-27  9:26           ` Richard Weinberger
2013-08-21  8:19 ` Richard Weinberger [this message]
2013-08-21  8:19   ` [PATCH 2/8] um: Do not use SUBARCH Richard Weinberger
2013-09-26 10:40   ` Ramkumar Ramachandra
2013-09-26 10:40     ` Ramkumar Ramachandra
2013-09-26 10:44     ` Richard Weinberger
2013-09-26 10:53       ` Ramkumar Ramachandra
2013-09-26 11:01         ` Richard Weinberger
2013-09-26 11:01           ` Richard Weinberger
2013-09-26 11:43           ` Ramkumar Ramachandra
2013-09-26 11:43             ` Ramkumar Ramachandra
2013-09-26 11:56             ` Richard Weinberger
2013-09-26 11:56               ` Richard Weinberger
2013-09-26 12:00               ` Ramkumar Ramachandra
2013-09-26 12:00                 ` Ramkumar Ramachandra
2013-09-26 13:13                 ` Ramkumar Ramachandra
2013-09-26 13:13                   ` Ramkumar Ramachandra
2013-09-26 13:26                   ` Geert Uytterhoeven
2013-09-26 13:56                     ` Richard Weinberger
2013-09-26 13:57                     ` Ramkumar Ramachandra
2013-09-26 13:57                       ` Ramkumar Ramachandra
2013-09-26 14:24                     ` Richard Weinberger
2013-09-26 14:24                       ` Richard Weinberger
2013-09-26 14:36                       ` Ramkumar Ramachandra
2013-09-26 14:36                         ` Ramkumar Ramachandra
2013-09-26 15:04                         ` Richard Weinberger
2013-09-26 15:04                           ` Richard Weinberger
2013-09-26 16:06                           ` Ramkumar Ramachandra
2013-09-26 16:06                             ` Ramkumar Ramachandra
2013-09-26 17:10                             ` Richard Weinberger
2013-09-26 17:10                               ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 3/8] um: Remove old defconfig Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 4/8] m68k: Do not use SUBARCH Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 5/8] sh: " Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 6/8] mips: " Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 7/8] unicore32: " Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21  8:19 ` [PATCH 8/8] Makefile: Remove SUBARCH Richard Weinberger
2013-08-21  8:19   ` Richard Weinberger
2013-08-21 12:07 ` [RFC] Get rid of SUBARCH Geert Uytterhoeven
2013-08-21 12:07   ` Geert Uytterhoeven
2013-08-21 12:16   ` Richard Weinberger
2013-08-21 17:25   ` Rob Landley
2013-08-21 17:25     ` Rob Landley
2013-08-21 19:51   ` Sam Ravnborg
2013-08-21 19:51     ` Sam Ravnborg
2013-08-22 12:58     ` Geert Uytterhoeven
2013-08-22 12:58       ` Geert Uytterhoeven
2013-08-22 20:41       ` Rob Landley
2013-08-22 20:41         ` Rob Landley
2013-08-22 20:55         ` David Daney
2013-08-22 21:32           ` Rob Landley
2013-08-22 21:32             ` Rob Landley
2013-08-21 12:53 ` Thorsten Glaser
2013-08-21 12:53   ` Thorsten Glaser
2013-08-21 12:58   ` H. Peter Anvin
2013-08-21 12:58     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377073172-3662-3-git-send-email-richard@nod.at \
    --to=richard@nod.at \
    --cc=artagnon@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=hpa@zytor.com \
    --cc=jdike@addtoit.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).