linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <Waiman.Long@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michel Lespinasse <walken@google.com>,
	Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	George Spelvin <linux@horizon.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	"Aswin Chandramouleeswaran\"" <aswin@hp.com>,
	Scott J Norton <scott.norton@hp.com>,
	Waiman Long <Waiman.Long@hp.com>
Subject: [PATCH v6 5/5] qrwlock: Use smp_store_release() in write_unlock()
Date: Tue, 12 Nov 2013 09:48:55 -0500	[thread overview]
Message-ID: <1384267735-43213-7-git-send-email-Waiman.Long@hp.com> (raw)
In-Reply-To: <1384267735-43213-1-git-send-email-Waiman.Long@hp.com>

This patch modifies the queue_write_unlock() function to use the
new smp_store_release() function in another pending patch. This patch
should only be merged if the other patch was merged.

Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
 include/asm-generic/qrwlock.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h
index 288fb00..479c142 100644
--- a/include/asm-generic/qrwlock.h
+++ b/include/asm-generic/qrwlock.h
@@ -219,9 +219,7 @@ static inline void queue_write_unlock(struct qrwlock *lock)
 	/*
 	 * Make sure that none of the critical section will be leaked out.
 	 */
-	smp_mb__before_clear_bit();
-	ACCESS_ONCE(lock->cnts.writer) = 0;
-	smp_mb__after_clear_bit();
+	smp_store_release(&lock->cnts.writer, 0);
 }
 
 /*
-- 
1.7.1

  parent reply	other threads:[~2013-11-12 14:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 14:48 [PATCH v6 0/5] qrwlock: Introducing a queue read/write lock implementation Waiman Long
2013-11-12 14:48 ` [PATCH v6 1/5] qrwlock: A " Waiman Long
2013-11-12 14:48 ` [PATCH v6 1/3] " Waiman Long
2013-11-12 14:48   ` Waiman Long
2013-11-12 14:53   ` Waiman Long
2013-11-12 14:48 ` [PATCH v6 2/5] qrwlock x86: Enable x86 to use queue read/write lock Waiman Long
2013-11-12 14:48   ` Waiman Long
2013-11-12 14:48 ` [PATCH v6 3/5] qrwlock: Enable fair " Waiman Long
2013-11-12 14:48   ` Waiman Long
2013-11-18 18:11   ` Linus Torvalds
2013-11-18 18:34     ` Andi Kleen
2013-11-18 18:38       ` Linus Torvalds
2013-11-18 18:46         ` Andi Kleen
2013-11-18 18:46           ` Andi Kleen
2013-11-18 18:55           ` Linus Torvalds
2013-11-18 18:55             ` Linus Torvalds
2013-11-19  4:33     ` Long, Wai Man
2013-11-12 14:48 ` [PATCH v6 4/5] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
2013-11-12 14:48   ` Waiman Long
2013-11-12 14:48 ` Waiman Long [this message]
2013-11-12 14:48   ` [PATCH v6 5/5] qrwlock: Use smp_store_release() in write_unlock() Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384267735-43213-7-git-send-email-Waiman.Long@hp.com \
    --to=waiman.long@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arnd@arndb.de \
    --cc=aswin@hp.com \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).