From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0024] asm-generic: Rename int-ll64.h to types.h
Date: Mon, 25 Nov 2013 14:16:57 +0400 [thread overview]
Message-ID: <1385374617.2354.22.camel@dabdike> (raw)
In-Reply-To: <1385369734-24893-1-git-send-email-geert@linux-m68k.org>
On Mon, 2013-11-25 at 09:55 +0100, Geert Uytterhoeven wrote:
> This patchset aims to rename <asm-generic/int-ll64.h> to
> <asm-generic/types.h> in kernelspace, as suggested by Arnd.
>
> While userspace still has both include/uapi/asm-generic/int-l64.h and
> include/uapi/asm-generic/int-ll64.h (int-l64.h may still be used on legacy
> 64-bit systems), kernelspace always uses "(unsigned) long long" for 64-bit
> integer values ("u64" and "s64"). Hence there's no longer a need to
> distinguish between int-l64 and int-ll64 in kernelspace, and int-ll64.h can
> just be called types.h
Is this a good idea? I thought some versions of gcc used long long for
128 bit integers, in which case int-ll64.h will give the wrong types for
u64 and s64. I think gcc is changing to use the __int128 type, so this
may be historical, but someone would need to validate that we have no
architectures with the old long long behaviour.
James
next prev parent reply other threads:[~2013-11-25 10:17 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 8:55 [PATCH 0024] asm-generic: Rename int-ll64.h to types.h Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 01/24] uapi: Add missing _UAPI prefix to <asm-generic/types.h> include guard Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 02/24] avr32/uapi: Use Kbuild logic to provide <asm/types.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 9:07 ` Hans-Christian Egtvedt
2013-11-25 9:07 ` Hans-Christian Egtvedt
2013-11-25 8:55 ` [PATCH 03/24] cris/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 9:03 ` Jesper Nilsson
2013-11-25 8:55 ` [PATCH 04/24] frv/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 05/24] m32r/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
[not found] ` <1385369734-24893-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-11-25 8:55 ` [PATCH 06/24] microblaze/uapi: Use Kbuild logic to include <asm-generic/types.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 07/24] mn10300/uapi: Use Kbuild logic to provide <asm/types.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 08/24] parisc/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 9:55 ` James Bottomley
2013-11-25 10:12 ` Geert Uytterhoeven
2013-11-25 10:12 ` Geert Uytterhoeven
2013-11-25 10:22 ` James Bottomley
2013-11-25 10:22 ` James Bottomley
2013-11-25 8:55 ` [PATCH 09/24] score/uapi: Use Kbuild logic to include <asm-generic/types.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 10/24] sh/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 11/24] x86/uapi: " Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 12/24] alpha: Remove #include <uapi/asm/types.h> from <asm/types.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 13/24] mips: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 14/24] avr32: Use Kbuild logic to provide <asm/types.h> Geert Uytterhoeven
2013-11-25 9:09 ` Hans-Christian Egtvedt
2013-11-25 9:09 ` Hans-Christian Egtvedt
2013-11-25 10:03 ` Geert Uytterhoeven
2013-11-25 10:03 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 15/24] cris: " Geert Uytterhoeven
2013-11-25 9:03 ` Jesper Nilsson
2013-11-25 9:03 ` Jesper Nilsson
2013-11-25 8:55 ` [PATCH 16/24] frv: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 17/24] m32r: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 18/24] mn10300: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 19/24] sh: Replace <uapi/asm/types.h> by <asm-generic/int-ll64.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 20/24] xtensa: Remove duplicate definition of BITS_PER_LONG Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 21/24] powerpc: Separate kernel/userspace inclusion of <asm-generic/int-ll64.h> Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 22/24] s390: " Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 23/24] xtensa: " Geert Uytterhoeven
2013-11-25 8:55 ` [PATCH 24/24] asm-generic: Rename int-ll64.h to types.h Geert Uytterhoeven
2013-11-25 8:55 ` Geert Uytterhoeven
2013-11-25 10:16 ` James Bottomley [this message]
2013-11-25 10:43 ` [PATCH 0024] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385374617.2354.22.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).