From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 0024] asm-generic: Rename int-ll64.h to types.h Date: Mon, 25 Nov 2013 14:16:57 +0400 Message-ID: <1385374617.2354.22.camel@dabdike> References: <1385369734-24893-1-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53781 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114Ab3KYKRB (ORCPT ); Mon, 25 Nov 2013 05:17:01 -0500 In-Reply-To: <1385369734-24893-1-git-send-email-geert@linux-m68k.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 2013-11-25 at 09:55 +0100, Geert Uytterhoeven wrote: > This patchset aims to rename to > in kernelspace, as suggested by Arnd. > > While userspace still has both include/uapi/asm-generic/int-l64.h and > include/uapi/asm-generic/int-ll64.h (int-l64.h may still be used on legacy > 64-bit systems), kernelspace always uses "(unsigned) long long" for 64-bit > integer values ("u64" and "s64"). Hence there's no longer a need to > distinguish between int-l64 and int-ll64 in kernelspace, and int-ll64.h can > just be called types.h Is this a good idea? I thought some versions of gcc used long long for 128 bit integers, in which case int-ll64.h will give the wrong types for u64 and s64. I think gcc is changing to use the __int128 type, so this may be historical, but someone would need to validate that we have no architectures with the old long long behaviour. James