From: Waiman Long <Waiman.Long@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
"Aswin Chandramouleeswaran\"" <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>,
Waiman Long <Waiman.Long@hp.com>
Subject: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()
Date: Tue, 14 Jan 2014 23:44:06 -0500 [thread overview]
Message-ID: <1389761047-47566-5-git-send-email-Waiman.Long@hp.com> (raw)
In-Reply-To: <1389761047-47566-1-git-send-email-Waiman.Long@hp.com>
This patch modifies the queue_write_unlock() function to use the new
smp_store_release() function (currently in tip). It also removes the
temporary implementation of smp_load_acquire() and smp_store_release()
function in qrwlock.c.
This patch will use atomic subtraction instead if the writer field is
not atomic.
Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
include/asm-generic/qrwlock.h | 10 ++++++----
kernel/locking/qrwlock.c | 34 ----------------------------------
2 files changed, 6 insertions(+), 38 deletions(-)
diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h
index 5abb6ca..68f488b 100644
--- a/include/asm-generic/qrwlock.h
+++ b/include/asm-generic/qrwlock.h
@@ -181,11 +181,13 @@ static inline void queue_read_unlock(struct qrwlock *lock)
static inline void queue_write_unlock(struct qrwlock *lock)
{
/*
- * Make sure that none of the critical section will be leaked out.
+ * If the writer field is atomic, it can be cleared directly.
+ * Otherwise, an atomic subtraction will be used to clear it.
*/
- smp_mb__before_clear_bit();
- ACCESS_ONCE(lock->cnts.writer) = 0;
- smp_mb__after_clear_bit();
+ if (__native_word(lock->cnts.writer))
+ smp_store_release(&lock->cnts.writer, 0);
+ else
+ atomic_sub(_QW_LOCKED, &lock->cnts.rwa);
}
/*
diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
index 053be4d..2727188 100644
--- a/kernel/locking/qrwlock.c
+++ b/kernel/locking/qrwlock.c
@@ -47,40 +47,6 @@
# define arch_mutex_cpu_relax() cpu_relax()
#endif
-#ifndef smp_load_acquire
-# ifdef CONFIG_X86
-# define smp_load_acquire(p) \
- ({ \
- typeof(*p) ___p1 = ACCESS_ONCE(*p); \
- barrier(); \
- ___p1; \
- })
-# else
-# define smp_load_acquire(p) \
- ({ \
- typeof(*p) ___p1 = ACCESS_ONCE(*p); \
- smp_mb(); \
- ___p1; \
- })
-# endif
-#endif
-
-#ifndef smp_store_release
-# ifdef CONFIG_X86
-# define smp_store_release(p, v) \
- do { \
- barrier(); \
- ACCESS_ONCE(*p) = v; \
- } while (0)
-# else
-# define smp_store_release(p, v) \
- do { \
- smp_mb(); \
- ACCESS_ONCE(*p) = v; \
- } while (0)
-# endif
-#endif
-
/*
* If an xadd (exchange-add) macro isn't available, simulate one with
* the atomic_add_return() function.
--
1.7.1
next prev parent reply other threads:[~2014-01-15 4:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 4:44 [PATCH v9 0/5] qrwlock: Introducing a queue read/write lock implementation Waiman Long
2014-01-15 4:44 ` [PATCH v9 1/5] qrwlock: A " Waiman Long
2014-01-20 15:21 ` Peter Zijlstra
2014-01-20 15:21 ` Peter Zijlstra
2014-01-21 15:58 ` Waiman Long
2014-01-15 4:44 ` [PATCH v9 2/5] qrwlock x86: Enable x86 to use queue read/write lock Waiman Long
2014-01-15 4:44 ` Waiman Long
2014-01-20 16:08 ` Peter Zijlstra
2014-01-20 16:08 ` Peter Zijlstra
2014-01-20 16:16 ` Steven Rostedt
2014-01-21 16:00 ` Waiman Long
2014-01-15 4:44 ` [PATCH v9 3/5] qrwlock, x86 - Treat all data type not bigger than long as atomic in x86 Waiman Long
2014-01-15 4:44 ` Waiman Long
2014-01-20 15:03 ` Peter Zijlstra
2014-01-20 15:03 ` Peter Zijlstra
2014-01-21 15:36 ` Waiman Long
2014-01-21 15:39 ` Peter Zijlstra
2014-01-21 16:09 ` Waiman Long
2014-01-22 0:31 ` Linus Torvalds
2014-01-22 4:42 ` Waiman Long
2014-01-22 4:42 ` Waiman Long
2014-01-22 8:01 ` Peter Zijlstra
2014-01-22 12:09 ` Ingo Molnar
2014-01-22 12:13 ` Peter Zijlstra
2014-01-22 13:09 ` Ingo Molnar
2014-01-27 17:09 ` Paul E. McKenney
2014-01-15 4:44 ` Waiman Long [this message]
2014-01-15 4:44 ` [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock() Waiman Long
2014-01-20 3:39 ` Paul E. McKenney
2014-01-20 15:18 ` Peter Zijlstra
2014-01-20 15:18 ` Peter Zijlstra
2014-01-21 15:45 ` Waiman Long
2014-01-21 15:49 ` Peter Zijlstra
2014-01-21 15:49 ` Peter Zijlstra
2014-01-15 4:44 ` [PATCH v9 5/5] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
2014-01-15 4:44 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389761047-47566-5-git-send-email-Waiman.Long@hp.com \
--to=waiman.long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).