From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Chen Subject: Re: [PATCH v7 1/6] MCS Lock: Restructure the MCS lock defines and locking code into its own file Date: Mon, 20 Jan 2014 11:31:31 -0800 Message-ID: <1390246291.3138.31.camel@schen9-DESK> References: <1389917296.3138.11.camel@schen9-DESK> <20140120120756.GB31570@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:11936 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaATTbe (ORCPT ); Mon, 20 Jan 2014 14:31:34 -0500 In-Reply-To: <20140120120756.GB31570@twins.programming.kicks-ass.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin On Mon, 2014-01-20 at 13:07 +0100, Peter Zijlstra wrote: > On Thu, Jan 16, 2014 at 04:08:16PM -0800, Tim Chen wrote: > > +/* > > + * We don't inline mcs_spin_lock() so that perf can correctly account for the > > + * time spent in this lock function. > > + */ > > +static noinline > > +void mcs_spin_lock(struct mcs_spinlock **lock, struct mcs_spinlock *node) > > But given a vmlinux with sufficient DWARFs in, the IP will resolve to a > .ista. symbol, no? I'm actually only renaming the mspin_lock code to mcs_spin_lock here and moving the code to header file. The noinline logic was in the original code. Later on when we move mcs_spin_lock to its own file and exporting the symbol, then I think this issue will be resolved. Tim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:11936 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaATTbe (ORCPT ); Mon, 20 Jan 2014 14:31:34 -0500 Subject: Re: [PATCH v7 1/6] MCS Lock: Restructure the MCS lock defines and locking code into its own file From: Tim Chen In-Reply-To: <20140120120756.GB31570@twins.programming.kicks-ass.net> References: <1389917296.3138.11.camel@schen9-DESK> <20140120120756.GB31570@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 20 Jan 2014 11:31:31 -0800 Message-ID: <1390246291.3138.31.camel@schen9-DESK> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin Chandramouleeswaran , Scott J Norton , "Figo.zhang" Message-ID: <20140120193131.Yl06Kp_2-KzWYLlvIg9W9CjaaQUmhKassPqbZIFM2ws@z> On Mon, 2014-01-20 at 13:07 +0100, Peter Zijlstra wrote: > On Thu, Jan 16, 2014 at 04:08:16PM -0800, Tim Chen wrote: > > +/* > > + * We don't inline mcs_spin_lock() so that perf can correctly account for the > > + * time spent in this lock function. > > + */ > > +static noinline > > +void mcs_spin_lock(struct mcs_spinlock **lock, struct mcs_spinlock *node) > > But given a vmlinux with sufficient DWARFs in, the IP will resolve to a > .ista. symbol, no? I'm actually only renaming the mspin_lock code to mcs_spin_lock here and moving the code to header file. The noinline logic was in the original code. Later on when we move mcs_spin_lock to its own file and exporting the symbol, then I think this issue will be resolved. Tim