From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Chen Subject: Re: [PATCH v8 3/6] MCS Lock: optimizations and extra comments Date: Tue, 21 Jan 2014 09:31:51 -0800 Message-ID: <1390325511.3138.42.camel@schen9-DESK> References: <1390267468.3138.37.camel@schen9-DESK> <20140121102626.GV31570@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:23795 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742AbaAURbx (ORCPT ); Tue, 21 Jan 2014 12:31:53 -0500 In-Reply-To: <20140121102626.GV31570@twins.programming.kicks-ass.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin On Tue, 2014-01-21 at 11:26 +0100, Peter Zijlstra wrote: > On Mon, Jan 20, 2014 at 05:24:28PM -0800, Tim Chen wrote: > > From: Jason Low > > > > Remove unnecessary operation to assign locked status to 1 if lock is > > acquired without contention as this value will not be checked by lock > > holder again and other potential lock contenders will not be looking at > > their own lock status. should be "lock contenders will not be looking at lock holder's lock status" Thanks for catching it. Tim > > Ha, read that again :-) > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:23795 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742AbaAURbx (ORCPT ); Tue, 21 Jan 2014 12:31:53 -0500 Subject: Re: [PATCH v8 3/6] MCS Lock: optimizations and extra comments From: Tim Chen In-Reply-To: <20140121102626.GV31570@twins.programming.kicks-ass.net> References: <1390267468.3138.37.camel@schen9-DESK> <20140121102626.GV31570@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 21 Jan 2014 09:31:51 -0800 Message-ID: <1390325511.3138.42.camel@schen9-DESK> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin Chandramouleeswaran , Scott J Norton , "Figo.zhang" Message-ID: <20140121173151.R0dhalfoil-2bHDDHjzKIHExUwu9PDXXEV7wtp-5L14@z> On Tue, 2014-01-21 at 11:26 +0100, Peter Zijlstra wrote: > On Mon, Jan 20, 2014 at 05:24:28PM -0800, Tim Chen wrote: > > From: Jason Low > > > > Remove unnecessary operation to assign locked status to 1 if lock is > > acquired without contention as this value will not be checked by lock > > holder again and other potential lock contenders will not be looking at > > their own lock status. should be "lock contenders will not be looking at lock holder's lock status" Thanks for catching it. Tim > > Ha, read that again :-) > >