From: Richard Weinberger <richard@nod.at>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, viro@zeniv.linux.org.uk,
vgupta@synopsys.com, catalin.marinas@arm.com,
will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no,
vapier@gentoo.org, msalter@redhat.com, a-jacquiot@ti.com,
starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
takata@linux-m32r.org, geert@linux-m68k.org,
james.hogan@imgtec.com, monstr@monstr.eu,
yasutake.koichi@jp.panasonic.com, ralf@linux-mips.org,
jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de,
benh@kernel.crashing.org, paulus@samba.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
liqin.linux@gmail.com, lennox.wu@gmail.com, cmetcalf@tilera.com,
gxt@mprc.pku.edu.cn, linux-xtensa@linux-xtensa.org,
akpm@linux-foundation.org, oleg@redhat.com, tj@kernel.org,
hch@infradead.org, Richard Weinberger <richard@nod.at>
Subject: [PATCH 27/44] Clean up signal_delivered()
Date: Mon, 3 Mar 2014 00:59:10 +0100 [thread overview]
Message-ID: <1393804758-7916-5-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1393804758-7916-1-git-send-email-richard@nod.at>
- Pass a ksignal struct to it
- Remove unused regs parameter
- Make it private as it's nowhere outside of kernel/signal.c is used
Signed-off-by: Richard Weinberger <richard@nod.at>
---
include/linux/signal.h | 1 -
kernel/signal.c | 21 ++++++++-------------
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/include/linux/signal.h b/include/linux/signal.h
index 33177f5..ef8fcfd 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -287,7 +287,6 @@ struct ksignal {
extern int get_signal(struct ksignal *ksig);
extern void signal_setup_done(int failed, struct ksignal *ksig, int stepping);
-extern void signal_delivered(int sig, siginfo_t *info, struct k_sigaction *ka, struct pt_regs *regs, int stepping);
extern void exit_signals(struct task_struct *tsk);
extern struct kmem_cache *sighand_cachep;
diff --git a/kernel/signal.c b/kernel/signal.c
index b0a6256..8346b20 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2377,19 +2377,15 @@ relock:
/**
* signal_delivered -
- * @sig: number of signal being delivered
- * @info: siginfo_t of signal being delivered
- * @ka: sigaction setting that chose the handler
- * @regs: user register state
+ * @ksig: kernel signal struct
* @stepping: nonzero if debugger single-step or block-step in use
*
* This function should be called when a signal has succesfully been
- * delivered. It updates the blocked signals accordingly (@ka->sa.sa_mask
+ * delivered. It updates the blocked signals accordingly (@ksig->ka.sa.sa_mask
* is always blocked, and the signal itself is blocked unless %SA_NODEFER
- * is set in @ka->sa.sa_flags. Tracing is notified.
+ * is set in @ksig->ka.sa.sa_flags. Tracing is notified.
*/
-void signal_delivered(int sig, siginfo_t *info, struct k_sigaction *ka,
- struct pt_regs *regs, int stepping)
+static void signal_delivered(struct ksignal *ksig, int stepping)
{
sigset_t blocked;
@@ -2399,9 +2395,9 @@ void signal_delivered(int sig, siginfo_t *info, struct k_sigaction *ka,
simply clear the restore sigmask flag. */
clear_restore_sigmask();
- sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask);
- if (!(ka->sa.sa_flags & SA_NODEFER))
- sigaddset(&blocked, sig);
+ sigorsets(&blocked, ¤t->blocked, &ksig->ka.sa.sa_mask);
+ if (!(ksig->ka.sa.sa_flags & SA_NODEFER))
+ sigaddset(&blocked, ksig->sig);
set_current_blocked(&blocked);
tracehook_signal_handler(stepping);
}
@@ -2411,8 +2407,7 @@ void signal_setup_done(int failed, struct ksignal *ksig, int stepping)
if (failed)
force_sigsegv(ksig->sig, current);
else
- signal_delivered(ksig->sig, &ksig->info, &ksig->ka,
- signal_pt_regs(), stepping);
+ signal_delivered(ksig, stepping);
}
/*
--
1.8.4.2
next prev parent reply other threads:[~2014-03-02 23:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 23:59 [PATCH 23/44] unicore32: Use get_signal() signal_setup_done() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 24/44] xtensa: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 25/44] Rip out get_signal_to_deliver() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 26/44] tracehook_signal_handler: Remove sig, info, ka and regs Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger [this message]
2014-03-02 23:59 ` [PATCH 27/44] Clean up signal_delivered() Richard Weinberger
2014-03-02 23:59 ` [PATCH 28/44] Add translate_signal() helper Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-04 18:41 ` Oleg Nesterov
2014-03-04 20:43 ` Richard Weinberger
2014-03-04 20:43 ` Richard Weinberger
2014-03-04 21:00 ` Christoph Hellwig
2014-03-04 21:00 ` Christoph Hellwig
2014-03-02 23:59 ` [PATCH 29/44] arc: Use translate_signal() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-03 4:32 ` Vineet Gupta
2014-03-03 4:32 ` Vineet Gupta
2014-03-02 23:59 ` [PATCH 30/44] arm: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 31/44] arm64: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 32/44] blackfin: " Richard Weinberger
2014-03-02 23:59 ` [PATCH 33/44] frv: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 34/44] m32r: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 35/44] m68k: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393804758-7916-5-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=a-jacquiot@ti.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=liqin.linux@gmail.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
--cc=vgupta@synopsys.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).