From: Steve Capper <steve.capper@linaro.org> To: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: will.deacon@arm.com, gary.robertson@linaro.org, christoffer.dall@linaro.org, peterz@infradead.org, anders.roxell@linaro.org, akpm@linux-foundation.org, dann.frazier@canonical.com, mark.rutland@arm.com, mgorman@suse.de, Steve Capper <steve.capper@linaro.org> Subject: [PATH V2 0/6] RCU get_user_pages_fast and __get_user_pages_fast Date: Thu, 21 Aug 2014 16:43:26 +0100 [thread overview] Message-ID: <1408635812-31584-1-git-send-email-steve.capper@linaro.org> (raw) Hello, This series implements general forms of get_user_pages_fast and __get_user_pages_fast and activates them for arm and arm64. These are required for Transparent HugePages to function correctly, as a futex on a THP tail will otherwise result in an infinite loop (due to the core implementation of __get_user_pages_fast always returning 0). Unfortunately, a futex on THP tail can be quite common for certain workloads; thus THP is unreliable without a __get_user_pages_fast implementation. This series may also be beneficial for direct-IO heavy workloads and certain KVM workloads. Changes since PATCH V1 are: * Rebase to 3.17-rc1 * Switched to kick_all_cpus_sync as suggested by Mark Rutland. The main changes since RFC V5 are: * Rebased against 3.16-rc1. * pmd_present no longer tested for by gup_huge_pmd and gup_huge_pud, because the entry must be present for these leaf functions to be called. * Rather than assume puds can be re-cast as pmds, a separate function pud_write is instead used by the core gup. * ARM activation logic changed, now it will only activate RCU_TABLE_FREE and RCU_GUP when running with LPAE. The main changes since RFC V4 are: * corrected the arm64 logic so it now correctly rcu-frees page table backing pages. * rcu free logic relaxed for pre-ARMv7 ARM as we need an IPI to invalidate TLBs anyway. * rebased to 3.15-rc3 (some minor changes were needed to allow it to merge). * dropped Catalin's mmu_gather patch as that's been merged already. This series has been tested with LTP mm tests and some custom futex tests that exacerbate the futex on THP tail case; on both an Arndale board and a Juno board. Also debug counters were temporarily employed to ensure that the RCU_TABLE_FREE logic was behaving as expected. I would really appreciate any comments (especially on the validity or otherwise of the core fast_gup implementation) and testers. Cheers, -- Steve Steve Capper (6): mm: Introduce a general RCU get_user_pages_fast. arm: mm: Introduce special ptes for LPAE arm: mm: Enable HAVE_RCU_TABLE_FREE logic arm: mm: Enable RCU fast_gup arm64: mm: Enable HAVE_RCU_TABLE_FREE logic arm64: mm: Enable RCU fast_gup arch/arm/Kconfig | 5 + arch/arm/include/asm/pgtable-2level.h | 2 + arch/arm/include/asm/pgtable-3level.h | 15 ++ arch/arm/include/asm/pgtable.h | 6 +- arch/arm/include/asm/tlb.h | 38 ++++- arch/arm/mm/flush.c | 15 ++ arch/arm64/Kconfig | 4 + arch/arm64/include/asm/pgtable.h | 11 +- arch/arm64/include/asm/tlb.h | 20 ++- arch/arm64/mm/flush.c | 15 ++ mm/Kconfig | 3 + mm/gup.c | 278 ++++++++++++++++++++++++++++++++++ 12 files changed, 402 insertions(+), 10 deletions(-) -- 1.9.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Steve Capper <steve.capper@linaro.org> To: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: will.deacon@arm.com, gary.robertson@linaro.org, christoffer.dall@linaro.org, peterz@infradead.org, anders.roxell@linaro.org, akpm@linux-foundation.org, dann.frazier@canonical.com, mark.rutland@arm.com, mgorman@suse.de, Steve Capper <steve.capper@linaro.org> Subject: [PATH V2 0/6] RCU get_user_pages_fast and __get_user_pages_fast Date: Thu, 21 Aug 2014 16:43:26 +0100 [thread overview] Message-ID: <1408635812-31584-1-git-send-email-steve.capper@linaro.org> (raw) Message-ID: <20140821154326.eGuJhYaDzQYXPvwg9soaLfK-I7zve1jBFCDrTbQHWZE@z> (raw) Hello, This series implements general forms of get_user_pages_fast and __get_user_pages_fast and activates them for arm and arm64. These are required for Transparent HugePages to function correctly, as a futex on a THP tail will otherwise result in an infinite loop (due to the core implementation of __get_user_pages_fast always returning 0). Unfortunately, a futex on THP tail can be quite common for certain workloads; thus THP is unreliable without a __get_user_pages_fast implementation. This series may also be beneficial for direct-IO heavy workloads and certain KVM workloads. Changes since PATCH V1 are: * Rebase to 3.17-rc1 * Switched to kick_all_cpus_sync as suggested by Mark Rutland. The main changes since RFC V5 are: * Rebased against 3.16-rc1. * pmd_present no longer tested for by gup_huge_pmd and gup_huge_pud, because the entry must be present for these leaf functions to be called. * Rather than assume puds can be re-cast as pmds, a separate function pud_write is instead used by the core gup. * ARM activation logic changed, now it will only activate RCU_TABLE_FREE and RCU_GUP when running with LPAE. The main changes since RFC V4 are: * corrected the arm64 logic so it now correctly rcu-frees page table backing pages. * rcu free logic relaxed for pre-ARMv7 ARM as we need an IPI to invalidate TLBs anyway. * rebased to 3.15-rc3 (some minor changes were needed to allow it to merge). * dropped Catalin's mmu_gather patch as that's been merged already. This series has been tested with LTP mm tests and some custom futex tests that exacerbate the futex on THP tail case; on both an Arndale board and a Juno board. Also debug counters were temporarily employed to ensure that the RCU_TABLE_FREE logic was behaving as expected. I would really appreciate any comments (especially on the validity or otherwise of the core fast_gup implementation) and testers. Cheers, -- Steve Steve Capper (6): mm: Introduce a general RCU get_user_pages_fast. arm: mm: Introduce special ptes for LPAE arm: mm: Enable HAVE_RCU_TABLE_FREE logic arm: mm: Enable RCU fast_gup arm64: mm: Enable HAVE_RCU_TABLE_FREE logic arm64: mm: Enable RCU fast_gup arch/arm/Kconfig | 5 + arch/arm/include/asm/pgtable-2level.h | 2 + arch/arm/include/asm/pgtable-3level.h | 15 ++ arch/arm/include/asm/pgtable.h | 6 +- arch/arm/include/asm/tlb.h | 38 ++++- arch/arm/mm/flush.c | 15 ++ arch/arm64/Kconfig | 4 + arch/arm64/include/asm/pgtable.h | 11 +- arch/arm64/include/asm/tlb.h | 20 ++- arch/arm64/mm/flush.c | 15 ++ mm/Kconfig | 3 + mm/gup.c | 278 ++++++++++++++++++++++++++++++++++ 12 files changed, 402 insertions(+), 10 deletions(-) -- 1.9.3
next reply other threads:[~2014-08-21 15:43 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-21 15:43 Steve Capper [this message] 2014-08-21 15:43 ` [PATH V2 0/6] RCU get_user_pages_fast and __get_user_pages_fast Steve Capper 2014-08-21 15:43 ` [PATH V2 1/6] mm: Introduce a general RCU get_user_pages_fast Steve Capper 2014-08-21 15:43 ` Steve Capper 2014-08-27 8:54 ` Will Deacon 2014-08-27 12:50 ` Steve Capper 2014-08-27 12:50 ` Steve Capper 2014-08-27 13:14 ` Will Deacon 2014-08-27 14:28 ` Catalin Marinas 2014-08-27 14:42 ` Steve Capper 2014-08-27 15:01 ` Russell King - ARM Linux 2014-08-28 8:59 ` Steve Capper 2014-08-28 8:59 ` Steve Capper 2014-08-21 15:43 ` [PATH V2 2/6] arm: mm: Introduce special ptes for LPAE Steve Capper 2014-08-27 10:46 ` Catalin Marinas 2014-08-27 12:52 ` Steve Capper 2014-08-21 15:43 ` [PATH V2 3/6] arm: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper 2014-08-27 11:50 ` Catalin Marinas 2014-08-27 11:50 ` Catalin Marinas 2014-08-27 12:59 ` Steve Capper 2014-08-27 12:59 ` Steve Capper 2014-08-21 15:43 ` [PATH V2 4/6] arm: mm: Enable RCU fast_gup Steve Capper 2014-08-21 15:43 ` Steve Capper 2014-08-27 11:51 ` Catalin Marinas 2014-08-27 11:51 ` Catalin Marinas 2014-08-27 13:01 ` Steve Capper 2014-08-27 13:01 ` Steve Capper 2014-08-21 15:43 ` [PATH V2 5/6] arm64: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper 2014-08-27 10:48 ` Catalin Marinas 2014-08-27 10:48 ` Catalin Marinas 2014-08-27 13:08 ` Steve Capper 2014-08-21 15:43 ` [PATH V2 6/6] arm64: mm: Enable RCU fast_gup Steve Capper 2014-08-21 15:43 ` Steve Capper 2014-08-27 11:09 ` Catalin Marinas 2014-08-27 13:43 ` Steve Capper 2014-08-27 13:43 ` Steve Capper 2014-08-21 20:42 ` [PATH V2 0/6] RCU get_user_pages_fast and __get_user_pages_fast Dann Frazier 2014-08-21 20:42 ` Dann Frazier 2014-08-22 8:11 ` Steve Capper 2014-08-22 8:11 ` Steve Capper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1408635812-31584-1-git-send-email-steve.capper@linaro.org \ --to=steve.capper@linaro.org \ --cc=akpm@linux-foundation.org \ --cc=anders.roxell@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=dann.frazier@canonical.com \ --cc=gary.robertson@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mm@kvack.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mgorman@suse.de \ --cc=peterz@infradead.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).