* Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP [not found] <1411586033.19525.34.camel@x220> @ 2014-09-28 1:49 ` Xuetao Guan 2014-09-28 1:49 ` Xuetao Guan 2014-09-29 9:00 ` Paul Bolle 0 siblings, 2 replies; 5+ messages in thread From: Xuetao Guan @ 2014-09-28 1:49 UTC (permalink / raw) To: Paul Bolle; +Cc: Guan Xuetao, linux-kernel, linux-arch Sorry for late reply. I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig Sure, removing it means no different for .config file. I think a better way is reserving it or moving it into arch/Kconfig Cc: linux-arch@vger.kernel.org Xuetao Guan ----- Paul Bolle <pebolle@tiscali.nl> 写道： > Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is > possible that its value will be 'y'. For unicore32 its value will always > be 'n', making it pointless. Remove it. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Tested by playing with arch/unicore32/configs/unicore32_defconfig. This > patch made no difference whatsoever to the generated .config file. > Please note that it has > CONFIG_HAS_IOPORT_MAP=y > > set after invoking "make oldconfig" both before and after this patch. > > arch/unicore32/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig > index 928237a7b9ca..2322cc87e7cb 100644 > --- a/arch/unicore32/Kconfig > +++ b/arch/unicore32/Kconfig > @@ -27,9 +27,6 @@ config UNICORE32 > config GENERIC_CSUM > def_bool y > > -config NO_IOPORT_MAP > - bool > - > config STACKTRACE_SUPPORT > def_bool y > > -- > 1.9.3 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP 2014-09-28 1:49 ` [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP Xuetao Guan @ 2014-09-28 1:49 ` Xuetao Guan 2014-09-29 9:00 ` Paul Bolle 1 sibling, 0 replies; 5+ messages in thread From: Xuetao Guan @ 2014-09-28 1:49 UTC (permalink / raw) To: Paul Bolle; +Cc: Guan Xuetao, linux-kernel, linux-arch Sorry for late reply. I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig Sure, removing it means no different for .config file. I think a better way is reserving it or moving it into arch/Kconfig Cc: linux-arch@vger.kernel.org Xuetao Guan ----- Paul Bolle <pebolle@tiscali.nl> 写道： > Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is > possible that its value will be 'y'. For unicore32 its value will always > be 'n', making it pointless. Remove it. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Tested by playing with arch/unicore32/configs/unicore32_defconfig. This > patch made no difference whatsoever to the generated .config file. > Please note that it has > CONFIG_HAS_IOPORT_MAP=y > > set after invoking "make oldconfig" both before and after this patch. > > arch/unicore32/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig > index 928237a7b9ca..2322cc87e7cb 100644 > --- a/arch/unicore32/Kconfig > +++ b/arch/unicore32/Kconfig > @@ -27,9 +27,6 @@ config UNICORE32 > config GENERIC_CSUM > def_bool y > > -config NO_IOPORT_MAP > - bool > - > config STACKTRACE_SUPPORT > def_bool y > > -- > 1.9.3 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP 2014-09-28 1:49 ` [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP Xuetao Guan 2014-09-28 1:49 ` Xuetao Guan @ 2014-09-29 9:00 ` Paul Bolle 2014-10-01 14:38 ` 回复： " Xuetao Guan 1 sibling, 1 reply; 5+ messages in thread From: Paul Bolle @ 2014-09-29 9:00 UTC (permalink / raw) To: Xuetao Guan; +Cc: Guan Xuetao, linux-kernel, linux-arch On Sun, 2014-09-28 at 09:49 +0800, Xuetao Guan wrote: > Sorry for late reply. You replied within four days. That's rather quick, actually. > I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig > Sure, removing it means no different for .config file. > I think a better way is reserving it I'm not sure I get what you're saying here: what do mean with "reserving it"? > or moving it into arch/Kconfig Without a (treewide) patch I find it hard to say whether that's worth the trouble. But even if that move would be done, wouldn't it include dropping this entry from arch/unicore32 anyway? Paul Bolle ^ permalink raw reply [flat|nested] 5+ messages in thread
* 回复： Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP 2014-09-29 9:00 ` Paul Bolle @ 2014-10-01 14:38 ` Xuetao Guan 2014-10-01 14:38 ` Xuetao Guan 0 siblings, 1 reply; 5+ messages in thread From: Xuetao Guan @ 2014-10-01 14:38 UTC (permalink / raw) To: Paul Bolle; +Cc: Guan Xuetao, linux-kernel, linux-arch ----- Paul Bolle <pebolle@tiscali.nl> 写道： > On Sun, 2014-09-28 at 09:49 +0800, Xuetao Guan wrote: > > Sorry for late reply. > > You replied within four days. That's rather quick, actually. > > > I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig > > Sure, removing it means no different for .config file. > > I think a better way is reserving it > > I'm not sure I get what you're saying here: what do mean with "reserving > it"? I mean, it's better to keep the code unchanged. > > > or moving it into arch/Kconfig > > Without a (treewide) patch I find it hard to say whether that's worth > the trouble. But even if that move would be done, wouldn't it include > dropping this entry from arch/unicore32 anyway? IMHO, this config could be removed from kernel code. > > > Paul Bolle > ^ permalink raw reply [flat|nested] 5+ messages in thread
* 回复： Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP 2014-10-01 14:38 ` 回复： " Xuetao Guan @ 2014-10-01 14:38 ` Xuetao Guan 0 siblings, 0 replies; 5+ messages in thread From: Xuetao Guan @ 2014-10-01 14:38 UTC (permalink / raw) To: Paul Bolle; +Cc: Guan Xuetao, linux-kernel, linux-arch ----- Paul Bolle <pebolle@tiscali.nl> 写道： > On Sun, 2014-09-28 at 09:49 +0800, Xuetao Guan wrote: > > Sorry for late reply. > > You replied within four days. That's rather quick, actually. > > > I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig > > Sure, removing it means no different for .config file. > > I think a better way is reserving it > > I'm not sure I get what you're saying here: what do mean with "reserving > it"? I mean, it's better to keep the code unchanged. > > > or moving it into arch/Kconfig > > Without a (treewide) patch I find it hard to say whether that's worth > the trouble. But even if that move would be done, wouldn't it include > dropping this entry from arch/unicore32 anyway? IMHO, this config could be removed from kernel code. > > > Paul Bolle > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-01 14:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1411586033.19525.34.camel@x220>
2014-09-28 1:49 ` [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP Xuetao Guan
2014-09-28 1:49 ` Xuetao Guan
2014-09-29 9:00 ` Paul Bolle
2014-10-01 14:38 ` 回复： " Xuetao Guan
2014-10-01 14:38 ` Xuetao Guan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).