Re: [PATCHv7 0/3] syscalls,x86: Add execveat() system call

David Drysdale
2014-11-13T15:52:10Z

On Wed, Nov 12, 2014 at 10:08 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Fri, 7 Nov 2014 17:01:01 +0000 David Drysdale <drysdale@google.com> wrote:
>
>> This patch set adds execveat(2) for x86
>
> I grabbed these. If someone else was planning to do so, feel free to
> shout at me.
>
> I haven't been following the discussion closely so some reviewed-by's
> and tested-by's would be nice.

Yes please -- Andy, Eric, Al?

> Thanks for writing a manpage. mtk.manpages@gmail.com should have been
> cc'ed. He is now ;)

Thanks (for some reason I though cc'ing linux-api took care of Michael
seeing it).

> Your syscall number was taken by sys_bpf. I renumbered it
> appropriately.

Looks like the robots have also found a few things that need fixing:
1) Sparse warning on "close_on_exec(fd, current->files->fdt)": I guess
that needs a rcu_dereference_raw() or some such around arg2.
2) Syscall not implemented warning on sparc build: I could attempt to wire
up the sparc syscall (although I can only cross-compile it, not run it),
or is it best to leave it and ask sparclinux / David Miller nicely to take
care of it? Or have I just missed some bit of syscall machinery?
3) Non-canonical comment format just before the close_on_exec() call.
(Well, that last wasn't found by a robot -- thanks Andrew!)

When I generate a new version, would it be easier for you if I also merged up
against v3.18-rc4? That would at least take care of the syscall renumbering.