From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org
Subject: [PATCH 00/18] uaccess: fix sparse warning on get_user for bitwise types
Date: Sun, 14 Dec 2014 18:51:54 +0200 [thread overview]
Message-ID: <1418575877-21488-1-git-send-email-mst@redhat.com> (raw)
At the moment, if p and x are both tagged as bitwise types,
get_user(x, p) produces a sparse warning on many architectures.
This is because *p on these architectures is loaded into long
(typically using asm), then cast back to typeof(*p).
When typeof(*p) is a bitwise type (which is uncommon), such a cast needs
__force, otherwise sparse produces a warning.
Some architectures already have the __force tag, add it
where it's missing.
Specificlly, vhost wants to read bitwise types from userspace using get_user.
At the moment this triggers sparse errors, since the value is passed through an
integer.
For now, I worked around this by converting vhost code to access_ok +
__get_user, but that's not robust, I'd like to switch to get_user for 3.19.
I tested this on x86 only so far. Since it's just adding __force, should be
trivially safe everywhere?
Please review, and consider for 3.19.
Who can merge this? Arnd?
Michael S. Tsirkin (18):
x86/uaccess: fix sparse errors
alpha/uaccess: fix sparse errors
arm64/uaccess: fix sparse errors
avr32/uaccess: fix sparse errors
blackfin/uaccess: fix sparse errors
cris/uaccess: fix sparse errors
ia64/uaccess: fix sparse errors
m32r/uaccess: fix sparse errors
metag/uaccess: fix sparse errors
microblaze/uaccess: fix sparse errors
openrisc/uaccess: fix sparse errors
parisc/uaccess: fix sparse errors
powerpc/uaccess: fix sparse errors
sh/uaccess: fix sparse errors
sparc/uaccess: fix sparse errors
sparc/uaccess: fix sparse errors
xtensa/uaccess: fix sparse errors
m68k/uaccess: fix sparse errors
arch/alpha/include/asm/uaccess.h | 4 ++--
arch/arm64/include/asm/uaccess.h | 2 +-
arch/avr32/include/asm/uaccess.h | 4 ++--
arch/blackfin/include/asm/uaccess.h | 2 +-
arch/cris/include/asm/uaccess.h | 4 ++--
arch/ia64/include/asm/uaccess.h | 2 +-
arch/m32r/include/asm/uaccess.h | 4 ++--
arch/m68k/include/asm/uaccess_mm.h | 4 ++--
arch/metag/include/asm/uaccess.h | 4 ++--
arch/microblaze/include/asm/uaccess.h | 4 ++--
arch/openrisc/include/asm/uaccess.h | 4 ++--
arch/parisc/include/asm/uaccess.h | 2 +-
arch/powerpc/include/asm/uaccess.h | 6 +++---
arch/sh/include/asm/uaccess.h | 4 ++--
arch/sparc/include/asm/uaccess_32.h | 8 ++++----
arch/sparc/include/asm/uaccess_64.h | 4 ++--
arch/x86/include/asm/uaccess.h | 2 +-
arch/xtensa/include/asm/uaccess.h | 4 ++--
18 files changed, 34 insertions(+), 34 deletions(-)
--
MST
next reply other threads:[~2014-12-14 16:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 16:51 Michael S. Tsirkin [this message]
2014-12-14 16:51 ` [PATCH 01/18] x86/uaccess: fix sparse errors Michael S. Tsirkin
2014-12-14 16:51 ` Michael S. Tsirkin
2014-12-16 16:47 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 02/18] alpha/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 03/18] arm64/uaccess: " Michael S. Tsirkin
2014-12-15 11:17 ` Will Deacon
2014-12-15 11:23 ` Russell King - ARM Linux
2014-12-15 11:29 ` Michael S. Tsirkin
2014-12-15 12:54 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 04/18] avr32/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 20:35 ` Hans-Christian Egtvedt
2014-12-14 16:52 ` [PATCH 05/18] blackfin/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-18 3:11 ` Steven Miao
2014-12-14 16:52 ` [PATCH 06/18] cris/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 07/18] ia64/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 08/18] m32r/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 09/18] metag/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 10/18] microblaze/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 11/18] openrisc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 12/18] parisc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 13/18] powerpc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-15 0:05 ` Benjamin Herrenschmidt
2014-12-15 1:37 ` Benjamin Herrenschmidt
2014-12-16 16:47 ` Michael S. Tsirkin
2014-12-16 23:50 ` Michael Ellerman
2014-12-17 0:52 ` Benjamin Herrenschmidt
2014-12-17 10:53 ` Arnd Bergmann
2014-12-17 11:05 ` Benjamin Herrenschmidt
2014-12-14 16:52 ` [PATCH 14/18] sh/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 15/18] sparc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 16/18] " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 17/18] xtensa/uaccess: " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 18/18] m68k/uaccess: " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-15 0:40 ` [PATCH 00/18] uaccess: fix sparse warning on get_user for bitwise types Michael Ellerman
2014-12-15 10:22 ` Michael S. Tsirkin
2014-12-15 10:22 ` Michael S. Tsirkin
2014-12-16 23:49 ` Michael Ellerman
2014-12-15 10:03 ` LF.Tan
2014-12-15 10:17 ` Michael S. Tsirkin
2014-12-16 6:06 ` Ley Foon Tan
2014-12-16 6:57 ` Michael S. Tsirkin
2014-12-16 16:45 ` Michael S. Tsirkin
2014-12-18 6:54 ` Ley Foon Tan
2014-12-18 6:54 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418575877-21488-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).