From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips) Date: Thu, 18 Dec 2014 17:14:18 -0800 Message-ID: <1418951658.28384.20.camel@perches.com> References: <1418849927.28384.1.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:59806 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbaLSBOW (ORCPT ); Thu, 18 Dec 2014 20:14:22 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: linux-arch , LKML , Geert Uytterhoeven , linux-m68k , Steven Miao , Ralf Baechle , linux-mips On Fri, 2014-12-19 at 00:33 +0100, Thomas Gleixner wrote: > On Wed, 17 Dec 2014, Joe Perches wrote: > > It seems like early_printk can be configured into > > a few architectures but also appear not to be used. > > > > $ git grep -w "early_printk" > ... > > These seem to the only uses: > ... > > So blackfin, m68k, and mips seems to have it possible to enable, > > but also don't appear at first glance to use it, > > Hint: CONFIG_EARLY_PRINTK covers far more than early_printk() I know this. Note also I didn't specify CONFIG_EARLY_PRINTK, just early_printk. > > Is early_printk really used by these architectures? > > Should it be removed? > > Sure, if you have a good reason to remove working functionality. Unused. Ideally, all direct early_printk() uses would go away. This would just be a starting point to minimize code.