From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: Generic page fault (Was: libsigsegv ....)
Date: Sat, 28 Feb 2015 21:36:54 +1100 [thread overview]
Message-ID: <1425119814.4645.114.camel@kernel.crashing.org> (raw)
In-Reply-To: <1425107646.4645.109.camel@kernel.crashing.org>
On Sat, 2015-02-28 at 18:14 +1100, Benjamin Herrenschmidt wrote:
> On Sat, 2015-02-28 at 18:12 +1100, Benjamin Herrenschmidt wrote:
> >
> > Let me know what you think of the approach. It's boot tested on x86_64
> > in qemu and
>
> ... and powerpc64 LE on qemu as well :-)
One thing I'd like to do is fold handle_kernel_fault() into
handle_bad_area() (and in fact fold do_sigbus as well).
Basically have a single handle_bad_fault() that takes sig and si_code as
arguments which we call from the generic code for all faults. It will
test for kernel vs. user mode and do the right thing (and we could
handle the sigbus special case by simply comparing sig to sigbus).
The one reason I haven't done it so far is that x86 handle_bad_area()
has the is_f00f_bug() call which isn't do for other cases of
no_context() and I'm not sure generalizing it is safe for all cases (or
maybe I can call it only when sig is SIGSEGV ?) ... I don't actually
understand what it does :)
Cheers,
Ben.
next prev parent reply other threads:[~2015-02-28 10:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1422361485.6648.71.camel@opensuse.org>
[not found] ` <54C78756.9090605@suse.cz>
[not found] ` <alpine.LSU.2.11.1501271347440.30227@nerf60.vanv.qr>
[not found] ` <1422364084.6648.82.camel@opensuse.org>
[not found] ` <s5h7fw8hvdp.wl-tiwai@suse.de>
[not found] ` <CA+55aFyzy_wYHHnr2gDcYr7qcgOKM2557bRdg6RBa=cxrynd+Q@mail.gmail.com>
2015-01-27 20:57 ` [opensuse-factory] Re: [opensuse-kernel] libsigsegv build fail with kernel 3.18.3 Linus Torvalds
[not found] ` <CA+55aFxRnj97rpSQvvzLJhpo7C8TQ-F=eB1Ry2n53AV1rN8mwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-28 7:38 ` [opensuse-factory] " Heiko Carstens
2015-01-28 7:38 ` [opensuse-factory] Re: [opensuse-kernel] " Heiko Carstens
2015-01-29 6:59 ` Max Filippov
2015-01-29 18:16 ` Linus Torvalds
2015-02-02 0:23 ` Benjamin Herrenschmidt
2015-02-02 1:09 ` Linus Torvalds
2015-02-22 23:50 ` Benjamin Herrenschmidt
2015-02-22 23:50 ` [opensuse-factory] " Benjamin Herrenschmidt
2015-02-28 7:12 ` Generic page fault (Was: libsigsegv ....) Benjamin Herrenschmidt
2015-02-28 7:14 ` Benjamin Herrenschmidt
2015-02-28 10:36 ` Benjamin Herrenschmidt [this message]
2015-02-28 19:56 ` Linus Torvalds
2015-02-28 19:58 ` Linus Torvalds
2015-02-28 19:58 ` Linus Torvalds
2015-02-28 21:14 ` Benjamin Herrenschmidt
2015-02-28 21:49 ` Linus Torvalds
2015-02-28 21:49 ` Linus Torvalds
2015-02-28 22:49 ` Benjamin Herrenschmidt
2015-02-28 22:16 ` Benjamin Herrenschmidt
2015-02-28 22:50 ` Benjamin Herrenschmidt
2015-02-28 23:02 ` Benjamin Herrenschmidt
2015-02-28 23:02 ` Benjamin Herrenschmidt
2015-03-01 0:41 ` Linus Torvalds
2015-03-01 0:41 ` Linus Torvalds
2015-03-01 3:57 ` Benjamin Herrenschmidt
[not found] ` <CA+55aFyzy_wYHHnr2gDcYr7qcgOKM2557bRdg6RBa=cxrynd+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-27 21:12 ` [opensuse-factory] Re: libsigsegv build fail with kernel 3.18.3 Jan Engelhardt
2015-01-27 21:12 ` [opensuse-factory] Re: [opensuse-kernel] " Jan Engelhardt
2015-01-27 21:32 ` Linus Torvalds
2015-01-27 22:14 ` Jan Engelhardt
2015-01-27 22:32 ` Linus Torvalds
2015-01-27 23:13 ` Jan Engelhardt
2015-01-27 23:53 ` David Miller
[not found] ` <CA+55aFzguEFfG2REN1soMC+0UJ7GtANfEvMoCNPt0QqmP9LKoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-28 8:48 ` [opensuse-factory] " Andreas Schwab
2015-01-28 8:48 ` [opensuse-factory] Re: [opensuse-kernel] " Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425119814.4645.114.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).