From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v6 06/16] h8300: CPU depend helpers Date: Mon, 09 Mar 2015 09:21:07 -0700 Message-ID: <1425918067.5428.10.camel@perches.com> References: <1425890830-29399-1-git-send-email-ysato@users.sourceforge.jp> <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> Sender: linux-kernel-owner@vger.kernel.org To: Yoshinori Sato Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon, 2015-03-09 at 17:47 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato trivia: > arch/h8300/kernel/cpu/h83069/setup.c | 202 ++++++++++++++++++++++++++ [] > diff --git a/arch/h8300/kernel/cpu/h83069/setup.c b/arch/h8300/kernel/cpu/h83069/setup.c [] > +static struct resource sci0_resources[] = { > + DEFINE_RES_MEM(0xffffb0, 8), > + DEFINE_RES_IRQ(52), > + DEFINE_RES_IRQ(53), > + DEFINE_RES_IRQ(54), > + DEFINE_RES_IRQ(55), > +} Perhaps most all of these might be const? > +static struct plat_sci_port sci0_platform_data = { [] > +static struct resource sci1_resources[] = { [] > +static struct plat_sci_port sci1_platform_data = { [] > +static struct platform_device sci0_device = { [] > +static struct platform_device sci1_device = { [] > +static struct h8300_timer8_config tm8_unit0_platform_data = { [] > +static struct resource tm8_unit0_resources[] = { [] > +static struct platform_device timer8_unit0_device = { [] > +static struct h8300_timer8_config tm8_unit1_platform_data = { [] etc.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0156.hostedemail.com ([216.40.44.156]:54719 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754144AbbCIQeW (ORCPT ); Mon, 9 Mar 2015 12:34:22 -0400 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id 0B288211ADD for ; Mon, 9 Mar 2015 16:26:11 +0000 (UTC) Message-ID: <1425918067.5428.10.camel@perches.com> Subject: Re: [PATCH v6 06/16] h8300: CPU depend helpers From: Joe Perches In-Reply-To: <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> References: <1425890830-29399-1-git-send-email-ysato@users.sourceforge.jp> <1425890830-29399-7-git-send-email-ysato@users.sourceforge.jp> Content-Type: text/plain; charset="ISO-8859-1" Date: Mon, 09 Mar 2015 09:21:07 -0700 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yoshinori Sato Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20150309162107.v9CGdOgD9-WKj-2YICUzE-QNkhLLiF099afwtWH8qOE@z> On Mon, 2015-03-09 at 17:47 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato trivia: > arch/h8300/kernel/cpu/h83069/setup.c | 202 ++++++++++++++++++++++++++ [] > diff --git a/arch/h8300/kernel/cpu/h83069/setup.c b/arch/h8300/kernel/cpu/h83069/setup.c [] > +static struct resource sci0_resources[] = { > + DEFINE_RES_MEM(0xffffb0, 8), > + DEFINE_RES_IRQ(52), > + DEFINE_RES_IRQ(53), > + DEFINE_RES_IRQ(54), > + DEFINE_RES_IRQ(55), > +} Perhaps most all of these might be const? > +static struct plat_sci_port sci0_platform_data = { [] > +static struct resource sci1_resources[] = { [] > +static struct plat_sci_port sci1_platform_data = { [] > +static struct platform_device sci0_device = { [] > +static struct platform_device sci1_device = { [] > +static struct h8300_timer8_config tm8_unit0_platform_data = { [] > +static struct resource tm8_unit0_resources[] = { [] > +static struct platform_device timer8_unit0_device = { [] > +static struct h8300_timer8_config tm8_unit1_platform_data = { [] etc..