From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver Date: Fri, 13 Mar 2015 10:41:23 +0100 Message-ID: <1426239683.5304.59.camel@x220> References: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> <1426197361-19290-11-git-send-email-maxime.coquelin@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426197361-19290-11-git-send-email-maxime.coquelin@st.com> Sender: linux-gpio-owner@vger.kernel.org To: Maxime Coquelin Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon List-Id: linux-arch.vger.kernel.org Just a license nit, I'm afraid. On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote: > --- /dev/null > +++ b/drivers/tty/serial/stm32-usart.c > @@ -0,0 +1,695 @@ > +/* > + * Copyright (C) Maxime Coquelin 2015 > + * Author: Maxime Coquelin > + * License terms: GNU General Public License (GPL), version 2 > + * > + * Inspired by st-asc.c from STMicroelectronics (c) > + */ This states the license is GPL v2. > +MODULE_LICENSE("GPL"); And MODULE_LICENSE("GPL v2"); would match that statement. Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cpsmtpb-ews01.kpnxchange.com ([213.75.39.4]:51464 "EHLO cpsmtpb-ews01.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbbCMJl2 (ORCPT ); Fri, 13 Mar 2015 05:41:28 -0400 Message-ID: <1426239683.5304.59.camel@x220> Subject: Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver From: Paul Bolle Date: Fri, 13 Mar 2015 10:41:23 +0100 In-Reply-To: <1426197361-19290-11-git-send-email-maxime.coquelin@st.com> References: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> <1426197361-19290-11-git-send-email-maxime.coquelin@st.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Maxime Coquelin Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org Message-ID: <20150313094123.p6ARhVFnv_359Zi0dGwHLVR1AbqUXwLyNOkHlMN04xk@z> Just a license nit, I'm afraid. On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote: > --- /dev/null > +++ b/drivers/tty/serial/stm32-usart.c > @@ -0,0 +1,695 @@ > +/* > + * Copyright (C) Maxime Coquelin 2015 > + * Author: Maxime Coquelin > + * License terms: GNU General Public License (GPL), version 2 > + * > + * Inspired by st-asc.c from STMicroelectronics (c) > + */ This states the license is GPL v2. > +MODULE_LICENSE("GPL"); And MODULE_LICENSE("GPL v2"); would match that statement. Paul Bolle