From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: [PATCH v2 2/8] ARC: perf: cap the number of counters to hardware max of 32 Date: Wed, 5 Aug 2015 18:13:28 +0300 Message-ID: <1438787614-14074-3-git-send-email-abrodkin@synopsys.com> References: <1438787614-14074-1-git-send-email-abrodkin@synopsys.com> Return-path: In-Reply-To: <1438787614-14074-1-git-send-email-abrodkin@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Vineet.Gupta1@synopsys.com, arc-linux-dev@synopsys.com, arnd@arndb.de, peterz@infradead.org, Arnaldo Carvalho de Melo , Alexey Brodkin List-Id: linux-arch.vger.kernel.org From: Vineet Gupta The number of counters in PCT can never be more than 32 (while countable conditions could be 100+) for both ARCompact and ARCv2 Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Signed-off-by: Vineet Gupta Signed-off-by: Alexey Brodkin --- No changes since v1. arch/arc/include/asm/perf_event.h | 5 +++-- arch/arc/kernel/perf_event.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arc/include/asm/perf_event.h b/arch/arc/include/asm/perf_event.h index ea43477..ca8c414 100644 --- a/arch/arc/include/asm/perf_event.h +++ b/arch/arc/include/asm/perf_event.h @@ -1,6 +1,7 @@ /* * Linux performance counter support for ARC * + * Copyright (C) 2014-2015 Synopsys, Inc. (www.synopsys.com) * Copyright (C) 2011-2013 Synopsys, Inc. (www.synopsys.com) * * This program is free software; you can redistribute it and/or modify @@ -12,8 +13,8 @@ #ifndef __ASM_PERF_EVENT_H #define __ASM_PERF_EVENT_H -/* real maximum varies per CPU, this is the maximum supported by the driver */ -#define ARC_PMU_MAX_HWEVENTS 64 +/* Max number of counters that PCT block may ever have */ +#define ARC_PERF_MAX_COUNTERS 32 /* Max number of countable events that CPU may have */ #define ARC_PERF_MAX_EVENTS 256 diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index ae4a921..461fccf 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -23,7 +23,7 @@ struct arc_pmu { int counter_size; /* in bits */ int n_counters; int n_events; - unsigned long used_mask[BITS_TO_LONGS(ARC_PMU_MAX_HWEVENTS)]; + unsigned long used_mask[BITS_TO_LONGS(ARC_PERF_MAX_COUNTERS)]; int ev_hw_idx[PERF_COUNT_ARC_HW_MAX]; u64 raw_events[ARC_PERF_MAX_EVENTS]; }; @@ -306,7 +306,7 @@ static int arc_pmu_device_probe(struct platform_device *pdev) pr_err("This core does not have performance counters!\n"); return -ENODEV; } - BUG_ON(pct_bcr.c > ARC_PMU_MAX_HWEVENTS); + BUG_ON(pct_bcr.c > ARC_PERF_MAX_COUNTERS); READ_BCR(ARC_REG_CC_BUILD, cc_bcr); BUG_ON(!cc_bcr.v); /* Counters exist but No countable conditions ? */ -- 2.4.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay2.synopsys.com ([198.182.60.111]:39866 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752971AbbHEPOK (ORCPT ); Wed, 5 Aug 2015 11:14:10 -0400 From: Alexey Brodkin Subject: [PATCH v2 2/8] ARC: perf: cap the number of counters to hardware max of 32 Date: Wed, 5 Aug 2015 18:13:28 +0300 Message-ID: <1438787614-14074-3-git-send-email-abrodkin@synopsys.com> In-Reply-To: <1438787614-14074-1-git-send-email-abrodkin@synopsys.com> References: <1438787614-14074-1-git-send-email-abrodkin@synopsys.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Vineet.Gupta1@synopsys.com, arc-linux-dev@synopsys.com, arnd@arndb.de, peterz@infradead.org, Arnaldo Carvalho de Melo , Alexey Brodkin Message-ID: <20150805151328.zKIOP8-5Kfd4wu8jon2Oiv3JyL76O2pnDqZJtoE0p8Q@z> From: Vineet Gupta The number of counters in PCT can never be more than 32 (while countable conditions could be 100+) for both ARCompact and ARCv2 Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Signed-off-by: Vineet Gupta Signed-off-by: Alexey Brodkin --- No changes since v1. arch/arc/include/asm/perf_event.h | 5 +++-- arch/arc/kernel/perf_event.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arc/include/asm/perf_event.h b/arch/arc/include/asm/perf_event.h index ea43477..ca8c414 100644 --- a/arch/arc/include/asm/perf_event.h +++ b/arch/arc/include/asm/perf_event.h @@ -1,6 +1,7 @@ /* * Linux performance counter support for ARC * + * Copyright (C) 2014-2015 Synopsys, Inc. (www.synopsys.com) * Copyright (C) 2011-2013 Synopsys, Inc. (www.synopsys.com) * * This program is free software; you can redistribute it and/or modify @@ -12,8 +13,8 @@ #ifndef __ASM_PERF_EVENT_H #define __ASM_PERF_EVENT_H -/* real maximum varies per CPU, this is the maximum supported by the driver */ -#define ARC_PMU_MAX_HWEVENTS 64 +/* Max number of counters that PCT block may ever have */ +#define ARC_PERF_MAX_COUNTERS 32 /* Max number of countable events that CPU may have */ #define ARC_PERF_MAX_EVENTS 256 diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index ae4a921..461fccf 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -23,7 +23,7 @@ struct arc_pmu { int counter_size; /* in bits */ int n_counters; int n_events; - unsigned long used_mask[BITS_TO_LONGS(ARC_PMU_MAX_HWEVENTS)]; + unsigned long used_mask[BITS_TO_LONGS(ARC_PERF_MAX_COUNTERS)]; int ev_hw_idx[PERF_COUNT_ARC_HW_MAX]; u64 raw_events[ARC_PERF_MAX_EVENTS]; }; @@ -306,7 +306,7 @@ static int arc_pmu_device_probe(struct platform_device *pdev) pr_err("This core does not have performance counters!\n"); return -ENODEV; } - BUG_ON(pct_bcr.c > ARC_PMU_MAX_HWEVENTS); + BUG_ON(pct_bcr.c > ARC_PERF_MAX_COUNTERS); READ_BCR(ARC_REG_CC_BUILD, cc_bcr); BUG_ON(!cc_bcr.v); /* Counters exist but No countable conditions ? */ -- 2.4.3