public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Greg Ungerer <gerg@uclinux.org>, Sam Creasey <sammy@sammy.net>,
	linux-m68k@lists.linux-m68k.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and {min,max}_low_pfn
Date: Sun, 15 Nov 2015 12:04:11 +0100	[thread overview]
Message-ID: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> (raw)

	Hi,

This patch series adds missing initialization of max_pfn, min_low_pfn,
and max_low_pfn on various m68k platforms.

This was exposed by failing selftests/vm/mlock2-tests.

Note that several other architectures lack a proper initialization of
max_pfn. On some of them it's completely missing, on others max_pfn is a
local variable, hence it hides the global max_pfn, which is thus not
initialized neither.

On platforms with MMU, this can easily be verified by reading the
following virtual files (CONFIG_PROC_PAGE_MONITOR=y):

    /proc/kpagecount
    /proc/kpageflags
    /proc/kpagecgroup (CONFIG_MEMCG=y)

If max_pfn is not initialized, all three virtual files are empty.

Besides the above, max_pfn is also used to calculate DMA masks for block
devices. An uninitialized (zero) value means all RAM is suitable for
DMA.

Absence of initialization of min_low_pfn and max_low_pfn is more subtle.
(are there any bad side-effects?).

Geert Uytterhoeven (4):
  m68k/mm: motorola - Add missing initialization of max_pfn
  m68k/mm: m54xx - Add missing initialization of max_pfn
  m68k/mm: sun3 - Add missing initialization of max_pfn and
    {min,max}_low_pfn
  m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn

 arch/m68k/coldfire/m54xx.c  | 2 +-
 arch/m68k/kernel/setup_no.c | 9 ++++++---
 arch/m68k/mm/motorola.c     | 2 +-
 arch/m68k/sun3/config.c     | 4 ++--
 4 files changed, 10 insertions(+), 7 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2015-11-15 11:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 11:04 Geert Uytterhoeven [this message]
2015-11-15 11:04 ` [PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 1/4] m68k/mm: motorola - Add missing initialization of max_pfn Geert Uytterhoeven
2015-11-17  4:42   ` Michael Schmitz
2015-11-17 19:54     ` Geert Uytterhoeven
2015-11-17 19:54       ` Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 2/4] m68k/mm: m54xx " Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-17  0:16   ` Greg Ungerer
2015-11-17  0:16     ` Greg Ungerer
2015-11-15 11:04 ` [PATCH 3/4] m68k/mm: sun3 - Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 4/4] m68knommu: " Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-16 12:18   ` Greg Ungerer
2015-11-16 12:18     ` Greg Ungerer
2015-11-16 13:05     ` Geert Uytterhoeven
2015-11-16 23:46       ` Greg Ungerer
2015-11-16 23:54   ` Greg Ungerer
2015-11-22 10:38     ` Geert Uytterhoeven
2015-11-17  0:17 ` [PATCH 0/4] m68k/mm: " Greg Ungerer
2015-11-17  0:17   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447585455-19671-1-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=sammy@sammy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox