From: Toshi Kani <toshi.kani@hpe.com> To: akpm@linux-foundation.org, bp@alien8.de Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Toshi Kani <toshi.kani@hpe.com> Subject: [PATCH v2 02/16] resource: make resource flags handled properly Date: Fri, 25 Dec 2015 15:09:11 -0700 [thread overview] Message-ID: <1451081365-15190-2-git-send-email-toshi.kani@hpe.com> (raw) In-Reply-To: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> I/O resource flags consist of I/O resource types and modifier bits. Therefore, checking an I/O resource type in 'flags' must be performed with a bitwise operation. Fix find_next_iomem_res() and region_intersects() that simply compare 'flags' against a given value. Also change __request_region() to set 'res->flags' from resource_type() and resource_ext_type() of the parent, so that children nodes will inherit the extended I/O resource type. Link: http://lkml.kernel.org/r/<CA+55aFy4WQrWexC4u2LxX9Mw2NVoznw7p3Yh=iF4Xtf7zKWnRw@mail.gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Toshi Kani <toshi.kani@hpe.com> --- kernel/resource.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index f150dbb..d30a175 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -358,7 +358,7 @@ static int find_next_iomem_res(struct resource *res, char *name, read_lock(&resource_lock); for (p = iomem_resource.child; p; p = next_resource(p, sibling_only)) { - if (p->flags != res->flags) + if ((p->flags & res->flags) != res->flags) continue; if (name && strcmp(p->name, name)) continue; @@ -519,7 +519,8 @@ int region_intersects(resource_size_t start, size_t size, const char *name) read_lock(&resource_lock); for (p = iomem_resource.child; p ; p = p->sibling) { - bool is_type = strcmp(p->name, name) == 0 && p->flags == flags; + bool is_type = strcmp(p->name, name) == 0 && + ((p->flags & flags) == flags); if (start >= p->start && start <= p->end) is_type ? type++ : other++; @@ -1071,7 +1072,7 @@ struct resource * __request_region(struct resource *parent, res->name = name; res->start = start; res->end = start + n - 1; - res->flags = resource_type(parent); + res->flags = resource_type(parent) | resource_ext_type(parent); res->flags |= IORESOURCE_BUSY | flags; write_lock(&resource_lock); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com> To: akpm@linux-foundation.org, bp@alien8.de Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Toshi Kani <toshi.kani@hpe.com> Subject: [PATCH v2 02/16] resource: make resource flags handled properly Date: Fri, 25 Dec 2015 15:09:11 -0700 [thread overview] Message-ID: <1451081365-15190-2-git-send-email-toshi.kani@hpe.com> (raw) Message-ID: <20151225220911.JQAS70xXF4_vj6iydhKS3wbIxZwlC0u8S5bvzdRFInM@z> (raw) In-Reply-To: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> I/O resource flags consist of I/O resource types and modifier bits. Therefore, checking an I/O resource type in 'flags' must be performed with a bitwise operation. Fix find_next_iomem_res() and region_intersects() that simply compare 'flags' against a given value. Also change __request_region() to set 'res->flags' from resource_type() and resource_ext_type() of the parent, so that children nodes will inherit the extended I/O resource type. Link: http://lkml.kernel.org/r/<CA+55aFy4WQrWexC4u2LxX9Mw2NVoznw7p3Yh=iF4Xtf7zKWnRw@mail.gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Toshi Kani <toshi.kani@hpe.com> --- kernel/resource.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index f150dbb..d30a175 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -358,7 +358,7 @@ static int find_next_iomem_res(struct resource *res, char *name, read_lock(&resource_lock); for (p = iomem_resource.child; p; p = next_resource(p, sibling_only)) { - if (p->flags != res->flags) + if ((p->flags & res->flags) != res->flags) continue; if (name && strcmp(p->name, name)) continue; @@ -519,7 +519,8 @@ int region_intersects(resource_size_t start, size_t size, const char *name) read_lock(&resource_lock); for (p = iomem_resource.child; p ; p = p->sibling) { - bool is_type = strcmp(p->name, name) == 0 && p->flags == flags; + bool is_type = strcmp(p->name, name) == 0 && + ((p->flags & flags) == flags); if (start >= p->start && start <= p->end) is_type ? type++ : other++; @@ -1071,7 +1072,7 @@ struct resource * __request_region(struct resource *parent, res->name = name; res->start = start; res->end = start + n - 1; - res->flags = resource_type(parent); + res->flags = resource_type(parent) | resource_ext_type(parent); res->flags |= IORESOURCE_BUSY | flags; write_lock(&resource_lock);
next prev parent reply other threads:[~2015-12-25 22:09 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-25 22:09 [PATCH v2 01/16] resource: Add System RAM resource type Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` Toshi Kani [this message] 2015-12-25 22:09 ` [PATCH v2 02/16] resource: make resource flags handled properly Toshi Kani 2015-12-25 22:09 ` [PATCH v2 03/16] resource: Add I/O resource descriptor Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 04/16] x86/e820: Set System RAM type and descriptor Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 05/16] ia64: " Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 06/16] arch: Set IORESOURCE_SYSTEM_RAM to System RAM Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 07/16] kexec: " Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 08/16] xen, mm: " Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2016-01-04 11:41 ` [Xen-devel] " David Vrabel 2015-12-25 22:09 ` [PATCH v2 09/16] drivers: Initialize resource entry to zero Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-28 21:37 ` Simon Horman 2015-12-28 21:37 ` Simon Horman 2015-12-25 22:09 ` [PATCH v2 10/16] resource: Change walk_system_ram to use System RAM type Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 11/16] arm/samsung: Change s3c_pm_run_res() " Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 12/16] memremap: Change region_intersects() to take @flags and @desc Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 13/16] resource: Add walk_iomem_res_desc() Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-26 10:38 ` Borislav Petkov 2015-12-27 0:31 ` Toshi Kani 2015-12-27 0:31 ` Toshi Kani 2015-12-27 2:12 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Minfei Huang [not found] ` <20151227021257.GA13560-0VdLhd/A9Pl6Yz8KYMO23x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> 2015-12-27 10:24 ` Borislav Petkov 2015-12-27 10:24 ` Borislav Petkov 2016-01-04 9:29 ` Dave Young [not found] ` <20160104092937.GB7033-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> 2016-01-04 12:26 ` Borislav Petkov 2016-01-04 12:26 ` Borislav Petkov 2016-01-04 17:57 ` Toshi Kani 2016-01-04 17:57 ` Toshi Kani 2016-01-04 19:41 ` Borislav Petkov 2016-01-04 19:41 ` Borislav Petkov 2016-01-04 19:45 ` Toshi Kani 2016-01-05 5:20 ` Dave Young 2015-12-26 16:05 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Minfei Huang 2015-12-26 16:05 ` Minfei Huang 2015-12-27 0:39 ` Toshi Kani 2015-12-27 0:39 ` Toshi Kani 2016-01-04 9:25 ` Dave Young 2016-01-04 9:25 ` Dave Young 2016-01-04 11:04 ` Dave Young 2015-12-25 22:09 ` [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res Toshi Kani 2015-12-25 22:09 ` Toshi Kani 2015-12-26 0:05 ` Joe Perches 2015-12-26 0:05 ` Joe Perches 2015-12-27 0:52 ` Toshi Kani 2015-12-27 0:52 ` Toshi Kani 2015-12-25 22:09 ` [PATCH v2 16/16] ACPI/EINJ: Allow memory error injection to NVDIMM Toshi Kani 2015-12-25 22:09 ` Toshi Kani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1451081365-15190-2-git-send-email-toshi.kani@hpe.com \ --to=toshi.kani@hpe.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=dan.j.williams@intel.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=rafael.j.wysocki@intel.com \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).