From: "Michael S. Tsirkin" <mst@redhat.com> To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra <peterz@infradead.org>, Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>, virtualization@lists.linux-foundation.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>, David Miller <davem@davemloft.net>, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Subject: [PATCH v2 05/32] powerpc: reuse asm-generic/barrier.h Date: Thu, 31 Dec 2015 21:06:21 +0200 [thread overview] Message-ID: <1451572003-2440-6-git-send-email-mst@redhat.com> (raw) In-Reply-To: <1451572003-2440-1-git-send-email-mst@redhat.com> On powerpc read_barrier_depends, smp_read_barrier_depends smp_store_mb(), smp_mb__before_atomic and smp_mb__after_atomic match the asm-generic variants exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Arnd Bergmann <arnd@arndb.de> --- arch/powerpc/include/asm/barrier.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/barrier.h b/arch/powerpc/include/asm/barrier.h index a7af5fb..980ad0c 100644 --- a/arch/powerpc/include/asm/barrier.h +++ b/arch/powerpc/include/asm/barrier.h @@ -34,8 +34,6 @@ #define rmb() __asm__ __volatile__ ("sync" : : : "memory") #define wmb() __asm__ __volatile__ ("sync" : : : "memory") -#define smp_store_mb(var, value) do { WRITE_ONCE(var, value); smp_mb(); } while (0) - #ifdef __SUBARCH_HAS_LWSYNC # define SMPWMB LWSYNC #else @@ -60,9 +58,6 @@ #define smp_wmb() barrier() #endif /* CONFIG_SMP */ -#define read_barrier_depends() do { } while (0) -#define smp_read_barrier_depends() do { } while (0) - /* * This is a barrier which prevents following instructions from being * started until the value of the argument x is known. For example, if @@ -87,8 +82,8 @@ do { \ ___p1; \ }) -#define smp_mb__before_atomic() smp_mb() -#define smp_mb__after_atomic() smp_mb() #define smp_mb__before_spinlock() smp_mb() +#include <asm-generic/barrier.h> + #endif /* _ASM_POWERPC_BARRIER_H */ -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra <peterz@infradead.org>, Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>, virtualization@lists.linux-foundation.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>, David Miller <davem@davemloft.net>, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Ingo Molnar <mingo@kernel.org>, Davidlohr Bueso <dave@stgolabs.net>, Andrey Konovalov <andreyknvl@google.com>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> Subject: [PATCH v2 05/32] powerpc: reuse asm-generic/barrier.h Date: Thu, 31 Dec 2015 21:06:21 +0200 [thread overview] Message-ID: <1451572003-2440-6-git-send-email-mst@redhat.com> (raw) Message-ID: <20151231190621.Bs0Qclt40Ljxa1_--ZFPxzBYTERipu9kLqdfDOQ8ZBw@z> (raw) In-Reply-To: <1451572003-2440-1-git-send-email-mst@redhat.com> On powerpc read_barrier_depends, smp_read_barrier_depends smp_store_mb(), smp_mb__before_atomic and smp_mb__after_atomic match the asm-generic variants exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Arnd Bergmann <arnd@arndb.de> --- arch/powerpc/include/asm/barrier.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/barrier.h b/arch/powerpc/include/asm/barrier.h index a7af5fb..980ad0c 100644 --- a/arch/powerpc/include/asm/barrier.h +++ b/arch/powerpc/include/asm/barrier.h @@ -34,8 +34,6 @@ #define rmb() __asm__ __volatile__ ("sync" : : : "memory") #define wmb() __asm__ __volatile__ ("sync" : : : "memory") -#define smp_store_mb(var, value) do { WRITE_ONCE(var, value); smp_mb(); } while (0) - #ifdef __SUBARCH_HAS_LWSYNC # define SMPWMB LWSYNC #else @@ -60,9 +58,6 @@ #define smp_wmb() barrier() #endif /* CONFIG_SMP */ -#define read_barrier_depends() do { } while (0) -#define smp_read_barrier_depends() do { } while (0) - /* * This is a barrier which prevents following instructions from being * started until the value of the argument x is known. For example, if @@ -87,8 +82,8 @@ do { \ ___p1; \ }) -#define smp_mb__before_atomic() smp_mb() -#define smp_mb__after_atomic() smp_mb() #define smp_mb__before_spinlock() smp_mb() +#include <asm-generic/barrier.h> + #endif /* _ASM_POWERPC_BARRIER_H */ -- MST
next prev parent reply other threads:[~2015-12-31 19:06 UTC|newest] Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-31 19:05 [PATCH v2 00/34] arch: barrier cleanup + barriers for virt Michael S. Tsirkin 2015-12-31 19:05 ` Michael S. Tsirkin 2015-12-31 19:05 ` [PATCH v2 01/32] lcoking/barriers, arch: Use smp barriers in smp_store_release() Michael S. Tsirkin 2015-12-31 19:05 ` Michael S. Tsirkin 2015-12-31 19:05 ` [PATCH v2 02/32] asm-generic: guard smp_store_release/load_acquire Michael S. Tsirkin 2015-12-31 19:05 ` Michael S. Tsirkin 2015-12-31 19:06 ` [PATCH v2 03/32] ia64: rename nop->iosapic_nop Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2015-12-31 19:06 ` [PATCH v2 04/32] ia64: reuse asm-generic/barrier.h Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin [this message] 2015-12-31 19:06 ` [PATCH v2 05/32] powerpc: " Michael S. Tsirkin 2015-12-31 19:06 ` [PATCH v2 06/32] s390: " Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2016-01-04 13:20 ` Peter Zijlstra 2016-01-04 13:20 ` Peter Zijlstra 2016-01-04 15:03 ` Martin Schwidefsky 2016-01-04 15:03 ` Martin Schwidefsky 2016-01-04 20:42 ` Michael S. Tsirkin 2016-01-04 20:42 ` Michael S. Tsirkin 2016-01-05 8:03 ` Martin Schwidefsky 2016-01-05 8:03 ` Martin Schwidefsky 2016-01-04 20:34 ` Michael S. Tsirkin 2016-01-04 20:34 ` Michael S. Tsirkin 2015-12-31 19:06 ` [PATCH v2 07/32] sparc: " Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2015-12-31 19:43 ` David Miller 2015-12-31 19:43 ` David Miller 2015-12-31 19:06 ` [PATCH v2 08/32] arm: " Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2016-01-02 11:20 ` Russell King - ARM Linux 2016-01-02 11:20 ` Russell King - ARM Linux 2015-12-31 19:06 ` [PATCH v2 09/32] arm64: " Michael S. Tsirkin 2015-12-31 19:06 ` Michael S. Tsirkin 2015-12-31 19:07 ` [PATCH v2 11/32] mips: " Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin [not found] ` <1451572003-2440-12-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-01-04 13:26 ` Peter Zijlstra 2016-01-04 13:26 ` Peter Zijlstra 2015-12-31 19:07 ` [PATCH v2 13/32] x86: " Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2015-12-31 19:07 ` [PATCH v2 15/32] powerpc: define __smp_xxx Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2016-01-05 1:36 ` Boqun Feng 2016-01-05 1:36 ` Boqun Feng [not found] ` <20160105013648.GA1256-nNqVUaWX1rAq6Sbylg4iGasjOiXwFzmk@public.gmane.org> 2016-01-05 8:51 ` Michael S. Tsirkin 2016-01-05 8:51 ` Michael S. Tsirkin 2016-01-05 9:53 ` Boqun Feng 2016-01-05 9:53 ` Boqun Feng [not found] ` <20160105095341.GA5321-nNqVUaWX1rAq6Sbylg4iGasjOiXwFzmk@public.gmane.org> 2016-01-05 16:16 ` Michael S. Tsirkin 2016-01-05 16:16 ` Michael S. Tsirkin 2016-01-06 1:51 ` Boqun Feng 2016-01-06 1:51 ` Boqun Feng [not found] ` <20160106015152.GA14605-nNqVUaWX1rAq6Sbylg4iGasjOiXwFzmk@public.gmane.org> 2016-01-06 20:23 ` Michael S. Tsirkin 2016-01-06 20:23 ` Michael S. Tsirkin 2016-01-07 0:43 ` Boqun Feng 2016-01-07 0:43 ` Boqun Feng 2015-12-31 19:07 ` [PATCH v2 16/32] arm64: " Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2015-12-31 19:07 ` [PATCH v2 17/32] arm: " Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2016-01-02 11:24 ` Russell King - ARM Linux 2016-01-02 11:24 ` Russell King - ARM Linux 2016-01-03 9:12 ` Michael S. Tsirkin 2016-01-03 9:12 ` Michael S. Tsirkin 2016-01-04 13:36 ` Peter Zijlstra 2016-01-04 13:36 ` Peter Zijlstra 2016-01-04 13:54 ` Peter Zijlstra 2016-01-04 13:54 ` Peter Zijlstra 2016-01-04 13:59 ` Russell King - ARM Linux 2016-01-04 13:59 ` Russell King - ARM Linux 2016-01-05 14:38 ` Michael S. Tsirkin 2016-01-05 14:38 ` Michael S. Tsirkin 2016-01-04 20:39 ` Michael S. Tsirkin 2016-01-04 20:39 ` Michael S. Tsirkin 2016-01-04 20:12 ` Michael S. Tsirkin 2016-01-04 20:12 ` Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 18/32] blackfin: " Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 19/32] ia64: " Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin [not found] ` <1451572003-2440-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-12-31 19:07 ` [PATCH v2 10/32] metag: reuse asm-generic/barrier.h Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2016-01-04 23:24 ` James Hogan 2016-01-04 23:24 ` James Hogan 2015-12-31 19:07 ` [PATCH v2 12/32] x86/um: " Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin [not found] ` <1451572003-2440-13-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-01-05 23:12 ` Richard Weinberger 2016-01-05 23:12 ` Richard Weinberger 2015-12-31 19:07 ` [PATCH v2 14/32] asm-generic: add __smp_xxx wrappers Michael S. Tsirkin 2015-12-31 19:07 ` Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 20/32] metag: define __smp_xxx Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin 2016-01-04 13:41 ` Peter Zijlstra 2016-01-04 13:41 ` Peter Zijlstra 2016-01-04 15:25 ` James Hogan 2016-01-04 15:25 ` James Hogan 2016-01-04 15:30 ` Peter Zijlstra 2016-01-04 15:30 ` Peter Zijlstra 2016-01-04 16:04 ` James Hogan 2016-01-04 16:04 ` James Hogan 2016-01-05 0:09 ` James Hogan 2016-01-05 0:09 ` James Hogan [not found] ` <20160105000929.GM17861-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org> 2016-01-11 11:10 ` Michael S. Tsirkin 2016-01-11 11:10 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 27/32] x86: " Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 31/32] sh: support a 2-byte smp_store_mb Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2016-01-04 14:05 ` Peter Zijlstra 2015-12-31 19:10 ` [PATCH v2 33/34] xenbus: use virt_xxx barriers Michael S. Tsirkin 2015-12-31 19:10 ` Michael S. Tsirkin 2016-01-04 11:32 ` [Xen-devel] " David Vrabel 2016-01-04 11:32 ` David Vrabel 2016-01-04 12:03 ` Stefano Stabellini 2016-01-04 12:03 ` Stefano Stabellini [not found] ` <1451572003-2440-34-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-01-04 14:09 ` Peter Zijlstra 2016-01-04 14:09 ` Peter Zijlstra 2015-12-31 19:08 ` [PATCH v2 21/32] mips: define __smp_xxx Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 22/32] s390: " Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin 2016-01-04 13:45 ` Peter Zijlstra 2016-01-04 13:45 ` Peter Zijlstra 2016-01-04 20:18 ` Michael S. Tsirkin 2016-01-04 20:18 ` Michael S. Tsirkin 2016-01-05 8:13 ` Martin Schwidefsky 2016-01-05 8:13 ` Martin Schwidefsky 2016-01-05 9:30 ` Michael S. Tsirkin 2016-01-05 9:30 ` Michael S. Tsirkin 2016-01-05 12:08 ` Martin Schwidefsky 2016-01-05 12:08 ` Martin Schwidefsky 2016-01-05 13:04 ` Michael S. Tsirkin 2016-01-05 13:04 ` Michael S. Tsirkin 2016-01-05 14:21 ` Martin Schwidefsky 2016-01-05 14:21 ` Martin Schwidefsky [not found] ` <20160105105335-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-01-05 15:39 ` Christian Borntraeger 2016-01-05 15:39 ` Christian Borntraeger 2016-01-05 16:04 ` Michael S. Tsirkin 2016-01-05 16:04 ` Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 23/32] sh: define __smp_xxx, fix smp_store_mb for !SMP Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin 2015-12-31 19:08 ` [PATCH v2 24/32] sparc: define __smp_xxx Michael S. Tsirkin 2015-12-31 19:08 ` Michael S. Tsirkin 2015-12-31 19:44 ` David Miller 2015-12-31 19:44 ` David Miller 2015-12-31 19:09 ` [PATCH v2 25/32] tile: " Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 26/32] xtensa: " Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 28/32] asm-generic: implement virt_xxx memory barriers Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 29/32] Revert "virtio_ring: Update weak barriers to use dma_wmb/rmb" Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 30/32] virtio_ring: update weak barriers to use __smp_XXX Michael S. Tsirkin 2016-01-01 9:39 ` [PATCH v2 30/32] virtio_ring: update weak barriers to use __smp_xxx Michael S. Tsirkin 2016-01-01 10:21 ` Michael S. Tsirkin 2016-01-01 10:21 ` Michael S. Tsirkin 2015-12-31 19:09 ` [PATCH v2 32/32] virtio_ring: use virt_store_mb Michael S. Tsirkin 2015-12-31 19:09 ` Michael S. Tsirkin 2016-01-01 17:23 ` Sergei Shtylyov 2016-01-01 17:23 ` Sergei Shtylyov [not found] ` <5686B622.6070600-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-01-03 9:01 ` Michael S. Tsirkin 2016-01-03 9:01 ` Michael S. Tsirkin 2015-12-31 19:10 ` [PATCH v2 34/34] xen/io: use virt_xxx barriers Michael S. Tsirkin 2015-12-31 19:10 ` Michael S. Tsirkin 2016-01-04 11:32 ` [Xen-devel] " David Vrabel 2016-01-04 11:32 ` David Vrabel [not found] ` <1451572003-2440-35-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-01-04 12:05 ` Stefano Stabellini 2016-01-04 12:05 ` Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1451572003-2440-6-git-send-email-mst@redhat.com \ --to=mst@redhat.com \ --cc=adi-buildroot-devel@lists.sourceforge.net \ --cc=andrew.cooper3@citrix.com \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=davem@davemloft.net \ --cc=hpa@zytor.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-metag@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=linux-xtensa@linux-xtensa.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@elte.hu \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=sparclinux@vger.kernel.org \ --cc=stefano.stabellini@eu.citrix.com \ --cc=tglx@linutronix.de \ --cc=user-mode-linux-devel@lists.sourceforge.net \ --cc=virtualization@lists.linux-foundation.org \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).