From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search Date: Mon, 04 Jan 2016 10:57:40 -0700 Message-ID: <1451930260.19330.21.camel@hpe.com> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> <567F315B.8080005@hpe.com> <20151227021257.GA13560@dhcp-128-25.nay.redhat.com> <20151227102406.GB19398@nazgul.tnic> <20160104092937.GB7033@dhcp-128-65.nay.redhat.com> <20160104122619.GH22941@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160104122619.GH22941@pd.tnic> Sender: owner-linux-mm@kvack.org To: Borislav Petkov , Dave Young Cc: Minfei Huang , linux-arch@vger.kernel.org, linux-nvdimm@ml01.01.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Dan Williams List-Id: linux-arch.vger.kernel.org On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd > > cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART desc for compitibility purpose is doable, no? > > Just read your other mails too. If I see it correctly, there's only one > place which has "GART": > > $ git grep -e \"GART\" > arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0, > -1, > > So crash.c only excludes this region but the kernel doesn't create it. > Right? > > So we can kill that walk_iomem_res(), as you say. Which would be even > nicer... Agreed. As Dave suggested in the other thread, we can simply remove the walk_iomem_res("GART",) call in crash.c. With this change, there will be no caller to walk_iomem_res(). Should we remove walk_iomem_res() altogether, or keep it for now as a deprecated func with the checkpatch check? Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5008.houston.hp.com ([15.240.92.66]:48984 "EHLO g9t5008.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbcADR6R (ORCPT ); Mon, 4 Jan 2016 12:58:17 -0500 Message-ID: <1451930260.19330.21.camel@hpe.com> Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search From: Toshi Kani Date: Mon, 04 Jan 2016 10:57:40 -0700 In-Reply-To: <20160104122619.GH22941@pd.tnic> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> <567F315B.8080005@hpe.com> <20151227021257.GA13560@dhcp-128-25.nay.redhat.com> <20151227102406.GB19398@nazgul.tnic> <20160104092937.GB7033@dhcp-128-65.nay.redhat.com> <20160104122619.GH22941@pd.tnic> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Borislav Petkov , Dave Young Cc: Minfei Huang , linux-arch@vger.kernel.org, linux-nvdimm@ml01.01.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Dan Williams Message-ID: <20160104175740.ldk90gGH6bpgTv9bgDJy7XtcPdc4awIbP3bI3ns8Df8@z> On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd > > cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART desc for compitibility purpose is doable, no? > > Just read your other mails too. If I see it correctly, there's only one > place which has "GART": > > $ git grep -e \"GART\" > arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0, > -1, > > So crash.c only excludes this region but the kernel doesn't create it. > Right? > > So we can kill that walk_iomem_res(), as you say. Which would be even > nicer... Agreed. As Dave suggested in the other thread, we can simply remove the walk_iomem_res("GART",) call in crash.c. With this change, there will be no caller to walk_iomem_res(). Should we remove walk_iomem_res() altogether, or keep it for now as a deprecated func with the checkpatch check? Thanks, -Toshi