From: Paul Bolle <pebolle@tiscali.nl>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: peterz@infradead.org, heiko.carstens@de.ibm.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc
Date: Mon, 25 Jan 2016 16:03:24 +0100 [thread overview]
Message-ID: <1453734204.17181.15.camel@tiscali.nl> (raw)
In-Reply-To: <1453720528-103788-1-git-send-email-borntraeger@de.ibm.com>
On ma, 2016-01-25 at 12:15 +0100, Christian Borntraeger wrote:
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> +config DEBUG_PAGEALLOC_ENABLE_DEFAULT
> + bool "Enable debug page memory allocations by default?"
> + default off
Nit: you apparently meant
default n
Note that "default off" should also evaluate to "n", which probably
explains why you didn't notice. And "n" is the default anyhow.
So I'm guessing you might as well drop this line.
> + depends on DEBUG_PAGEALLOC
> + ---help---
> + Enable debug page memory allocations by default? This value
> + can be overridden by debug_pagealloc=off|on.
> +
> + If unsure say no.
(Really trivial: you start indentation both with spaces and with tabs.
Start with tabs, please.)
Paul Bolle
prev parent reply other threads:[~2016-01-25 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:15 [PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc Christian Borntraeger
2016-01-25 11:15 ` Christian Borntraeger
2016-01-25 15:03 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453734204.17181.15.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).