From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, linux-arch@vger.kernel.org Subject: [PATCH 13/19] s390: get rid of superfluous __GFP_REPEAT Date: Mon, 11 Apr 2016 13:08:06 +0200 [thread overview] Message-ID: <1460372892-8157-14-git-send-email-mhocko@kernel.org> (raw) In-Reply-To: <1460372892-8157-1-git-send-email-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. arch_dup_task_struct uses __GFP_REPEAT for fpu_regs_size which is either sizeof(__vector128) * __NUM_VXRS = 4069B resp. sizeof(freg_t) * __NUM_FPRS = 1024B AFAICS. page_table_alloc then uses the flag for a single page allocation. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> --- arch/s390/kernel/process.c | 2 +- arch/s390/mm/pgalloc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c index f8e79824e284..1837a1901d4b 100644 --- a/arch/s390/kernel/process.c +++ b/arch/s390/kernel/process.c @@ -102,7 +102,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) */ fpu_regs_size = MACHINE_HAS_VX ? sizeof(__vector128) * __NUM_VXRS : sizeof(freg_t) * __NUM_FPRS; - dst->thread.fpu.regs = kzalloc(fpu_regs_size, GFP_KERNEL|__GFP_REPEAT); + dst->thread.fpu.regs = kzalloc(fpu_regs_size, GFP_KERNEL); if (!dst->thread.fpu.regs) return -ENOMEM; diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index f6c3de26cda8..3f716741797a 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -198,7 +198,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm) return table; } /* Allocate a fresh page */ - page = alloc_page(GFP_KERNEL|__GFP_REPEAT); + page = alloc_page(GFP_KERNEL); if (!page) return NULL; if (!pgtable_page_ctor(page)) { -- 2.8.0.rc3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, linux-arch@vger.kernel.org Subject: [PATCH 13/19] s390: get rid of superfluous __GFP_REPEAT Date: Mon, 11 Apr 2016 13:08:06 +0200 [thread overview] Message-ID: <1460372892-8157-14-git-send-email-mhocko@kernel.org> (raw) Message-ID: <20160411110806.ThF-mHG--qIvOXzeqyIAjeB8IwO7vgR-38s6oZAT_Lg@z> (raw) In-Reply-To: <1460372892-8157-1-git-send-email-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. arch_dup_task_struct uses __GFP_REPEAT for fpu_regs_size which is either sizeof(__vector128) * __NUM_VXRS = 4069B resp. sizeof(freg_t) * __NUM_FPRS = 1024B AFAICS. page_table_alloc then uses the flag for a single page allocation. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> --- arch/s390/kernel/process.c | 2 +- arch/s390/mm/pgalloc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c index f8e79824e284..1837a1901d4b 100644 --- a/arch/s390/kernel/process.c +++ b/arch/s390/kernel/process.c @@ -102,7 +102,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) */ fpu_regs_size = MACHINE_HAS_VX ? sizeof(__vector128) * __NUM_VXRS : sizeof(freg_t) * __NUM_FPRS; - dst->thread.fpu.regs = kzalloc(fpu_regs_size, GFP_KERNEL|__GFP_REPEAT); + dst->thread.fpu.regs = kzalloc(fpu_regs_size, GFP_KERNEL); if (!dst->thread.fpu.regs) return -ENOMEM; diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index f6c3de26cda8..3f716741797a 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -198,7 +198,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm) return table; } /* Allocate a fresh page */ - page = alloc_page(GFP_KERNEL|__GFP_REPEAT); + page = alloc_page(GFP_KERNEL); if (!page) return NULL; if (!pgtable_page_ctor(page)) { -- 2.8.0.rc3
next prev parent reply other threads:[~2016-04-11 11:08 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1460372892-8157-1-git-send-email-mhocko@kernel.org> 2016-04-11 11:07 ` [PATCH 01/19] tree wide: get rid of __GFP_REPEAT for order-0 allocations part I Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-14 19:56 ` David Rientjes 2016-04-15 7:44 ` Michal Hocko 2016-04-15 7:44 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 02/19] x86: get rid of superfluous __GFP_REPEAT Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 03/19] x86/efi: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-12 15:53 ` Matt Fleming 2016-04-12 15:53 ` Matt Fleming 2016-04-11 11:07 ` [PATCH 04/19] arm: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 05/19] arm64: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 15:49 ` Will Deacon 2016-04-11 11:07 ` [PATCH 06/19] arc: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 14:23 ` Vineet Gupta 2016-04-11 11:08 ` [PATCH 07/19] mips: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 08/19] nios2: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 09/19] parisc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 10/19] score: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 11/19] powerpc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 12/19] sparc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` Michal Hocko [this message] 2016-04-11 11:08 ` [PATCH 13/19] s390: " Michal Hocko 2016-04-11 11:28 ` Cornelia Huck 2016-04-11 11:28 ` Cornelia Huck 2016-04-11 12:47 ` Heiko Carstens 2016-04-11 12:47 ` Heiko Carstens 2016-04-11 11:08 ` [PATCH 14/19] sh: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 15/19] tile: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 16/19] unicore32: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1460372892-8157-14-git-send-email-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).