From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, John Crispin <blogic@openwrt.org>, linux-arch@vger.kernel.org Subject: [PATCH 07/19] mips: get rid of superfluous __GFP_REPEAT Date: Mon, 11 Apr 2016 13:08:00 +0200 [thread overview] Message-ID: <1460372892-8157-8-git-send-email-mhocko@kernel.org> (raw) In-Reply-To: <1460372892-8157-1-git-send-email-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. pte_alloc_one{_kernel}, pmd_alloc_one allocate PTE_ORDER resp. PMD_ORDER but both are not larger than 1. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: John Crispin <blogic@openwrt.org> Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> --- arch/mips/include/asm/pgalloc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index b336037e8768..93c079a1cfc8 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -69,7 +69,7 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, { pte_t *pte; - pte = (pte_t *) __get_free_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, PTE_ORDER); + pte = (pte_t *) __get_free_pages(GFP_KERNEL|__GFP_ZERO, PTE_ORDER); return pte; } @@ -79,7 +79,7 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm, { struct page *pte; - pte = alloc_pages(GFP_KERNEL | __GFP_REPEAT, PTE_ORDER); + pte = alloc_pages(GFP_KERNEL, PTE_ORDER); if (!pte) return NULL; clear_highpage(pte); @@ -113,7 +113,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - pmd = (pmd_t *) __get_free_pages(GFP_KERNEL|__GFP_REPEAT, PMD_ORDER); + pmd = (pmd_t *) __get_free_pages(GFP_KERNEL, PMD_ORDER); if (pmd) pmd_init((unsigned long)pmd, (unsigned long)invalid_pte_table); return pmd; -- 2.8.0.rc3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, John Crispin <blogic@openwrt.org>, linux-arch@vger.kernel.org Subject: [PATCH 07/19] mips: get rid of superfluous __GFP_REPEAT Date: Mon, 11 Apr 2016 13:08:00 +0200 [thread overview] Message-ID: <1460372892-8157-8-git-send-email-mhocko@kernel.org> (raw) Message-ID: <20160411110800.g6UnNPb2s2XATj4cWBMt6828qRKNqEDEaLEZRmcIO04@z> (raw) In-Reply-To: <1460372892-8157-1-git-send-email-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. pte_alloc_one{_kernel}, pmd_alloc_one allocate PTE_ORDER resp. PMD_ORDER but both are not larger than 1. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. Cc: John Crispin <blogic@openwrt.org> Cc: linux-arch@vger.kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> --- arch/mips/include/asm/pgalloc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index b336037e8768..93c079a1cfc8 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -69,7 +69,7 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, { pte_t *pte; - pte = (pte_t *) __get_free_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, PTE_ORDER); + pte = (pte_t *) __get_free_pages(GFP_KERNEL|__GFP_ZERO, PTE_ORDER); return pte; } @@ -79,7 +79,7 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm, { struct page *pte; - pte = alloc_pages(GFP_KERNEL | __GFP_REPEAT, PTE_ORDER); + pte = alloc_pages(GFP_KERNEL, PTE_ORDER); if (!pte) return NULL; clear_highpage(pte); @@ -113,7 +113,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - pmd = (pmd_t *) __get_free_pages(GFP_KERNEL|__GFP_REPEAT, PMD_ORDER); + pmd = (pmd_t *) __get_free_pages(GFP_KERNEL, PMD_ORDER); if (pmd) pmd_init((unsigned long)pmd, (unsigned long)invalid_pte_table); return pmd; -- 2.8.0.rc3
next prev parent reply other threads:[~2016-04-11 11:08 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1460372892-8157-1-git-send-email-mhocko@kernel.org> 2016-04-11 11:07 ` [PATCH 01/19] tree wide: get rid of __GFP_REPEAT for order-0 allocations part I Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-14 19:56 ` David Rientjes 2016-04-15 7:44 ` Michal Hocko 2016-04-15 7:44 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 02/19] x86: get rid of superfluous __GFP_REPEAT Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 03/19] x86/efi: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-12 15:53 ` Matt Fleming 2016-04-12 15:53 ` Matt Fleming 2016-04-11 11:07 ` [PATCH 04/19] arm: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 11:07 ` [PATCH 05/19] arm64: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 15:49 ` Will Deacon 2016-04-11 11:07 ` [PATCH 06/19] arc: " Michal Hocko 2016-04-11 11:07 ` Michal Hocko 2016-04-11 14:23 ` Vineet Gupta 2016-04-11 11:08 ` Michal Hocko [this message] 2016-04-11 11:08 ` [PATCH 07/19] mips: " Michal Hocko 2016-04-11 11:08 ` [PATCH 08/19] nios2: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 09/19] parisc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 10/19] score: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 11/19] powerpc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 12/19] sparc: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 13/19] s390: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:28 ` Cornelia Huck 2016-04-11 11:28 ` Cornelia Huck 2016-04-11 12:47 ` Heiko Carstens 2016-04-11 12:47 ` Heiko Carstens 2016-04-11 11:08 ` [PATCH 14/19] sh: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 15/19] tile: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko 2016-04-11 11:08 ` [PATCH 16/19] unicore32: " Michal Hocko 2016-04-11 11:08 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1460372892-8157-8-git-send-email-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=blogic@openwrt.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).