From: Michal Hocko <mhocko@kernel.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: [PATCH] x86: add frame annotation for call_rwsem_down_write_failed_killable
Date: Wed, 13 Apr 2016 11:57:12 +0200 [thread overview]
Message-ID: <1460541432-21631-1-git-send-email-mhocko@kernel.org> (raw)
In-Reply-To: <1460041951-22347-11-git-send-email-mhocko@kernel.org>
From: Michal Hocko <mhocko@suse.com>
3387a535ce62 ("x86/asm: Create stack frames in rwsem functions") has
added FRAME_{BEGIN,END} annotations to rwsem asm stubs. The patch
which has added call_rwsem_down_write_failed_killable was based on an
older tree so it didn't know about annotations. Let's add them.
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
Hi Ingo,
please apply this on top of [1] when merging to tip/locking/rwsem.
Thanks!
[1] http://lkml.kernel.org/r/1460041951-22347-11-git-send-email-mhocko@kernel.org
arch/x86/lib/rwsem.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/lib/rwsem.S b/arch/x86/lib/rwsem.S
index 4534a7e912f3..a37462a23546 100644
--- a/arch/x86/lib/rwsem.S
+++ b/arch/x86/lib/rwsem.S
@@ -107,10 +107,12 @@ ENTRY(call_rwsem_down_write_failed)
ENDPROC(call_rwsem_down_write_failed)
ENTRY(call_rwsem_down_write_failed_killable)
+ FRAME_BEGIN
save_common_regs
movq %rax,%rdi
call rwsem_down_write_failed_killable
restore_common_regs
+ FRAME_END
ret
ENDPROC(call_rwsem_down_write_failed_killable)
--
2.8.0.rc3
next prev parent reply other threads:[~2016-04-13 9:57 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:12 [PATCH 0/11] introduce down_write_killable for rw_semaphore v3 Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 01/11] locking, rwsem: get rid of __down_write_nested Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 02/11] locking, rwsem: drop explicit memory barriers Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 03/11] xtensa, rwsem: drop superfluous arch specific implementation Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 04/11] sh, " Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 05/11] sparc, " Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 06/11] locking, rwsem: introduce basis for down_write_killable Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 07/11] alpha, rwsem: provide __down_write_killable Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 08/11] ia64, " Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 17:28 ` Sergei Shtylyov
2016-04-08 6:22 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 09/11] s390, " Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-07 15:12 ` [PATCH 10/11] x86, " Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-13 9:08 ` Ingo Molnar
2016-04-13 9:16 ` Michal Hocko
2016-04-13 9:16 ` Michal Hocko
2016-04-13 9:19 ` Ingo Molnar
2016-04-13 9:19 ` Ingo Molnar
2016-04-13 10:27 ` Ingo Molnar
2016-04-13 12:49 ` Michal Hocko
2016-04-13 12:49 ` Michal Hocko
2016-04-17 16:59 ` Michal Hocko
2016-04-17 16:59 ` Michal Hocko
2016-04-20 13:40 ` Peter Zijlstra
2016-04-20 13:40 ` Peter Zijlstra
2016-04-20 18:04 ` H. Peter Anvin
2016-04-20 18:04 ` H. Peter Anvin
2016-04-20 20:45 ` Borislav Petkov
2016-04-20 20:45 ` Borislav Petkov
2016-04-20 20:58 ` Michal Hocko
2016-04-20 20:58 ` Michal Hocko
2016-04-20 21:06 ` H. Peter Anvin
2016-04-20 21:06 ` H. Peter Anvin
2016-04-20 21:36 ` Borislav Petkov
2016-04-20 22:29 ` H. Peter Anvin
2016-04-20 22:29 ` H. Peter Anvin
2016-04-21 11:35 ` Borislav Petkov
2016-04-21 11:35 ` Borislav Petkov
2016-04-21 13:09 ` Michal Hocko
2016-04-21 13:09 ` Michal Hocko
2016-04-21 13:21 ` Borislav Petkov
2016-04-21 13:21 ` Borislav Petkov
2016-04-27 12:02 ` [PATCH] x86/locking/rwsem: Cleanup ____down_write() Borislav Petkov
2016-04-27 12:02 ` Borislav Petkov
2016-04-22 6:53 ` [PATCH 10/11] x86, rwsem: provide __down_write_killable Ingo Molnar
2016-04-22 6:53 ` Ingo Molnar
2016-04-13 9:57 ` Michal Hocko [this message]
2016-04-07 15:12 ` [PATCH 11/11] locking, rwsem: provide down_write_killable Michal Hocko
2016-04-07 15:12 ` Michal Hocko
2016-04-12 9:37 ` [PATCH 0/11] introduce down_write_killable for rw_semaphore v3 Michal Hocko
2016-04-12 9:37 ` Michal Hocko
2016-04-12 15:40 ` Peter Zijlstra
2016-04-12 15:40 ` Peter Zijlstra
2016-04-12 18:01 ` Michal Hocko
2016-04-12 18:01 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460541432-21631-1-git-send-email-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).