From: Christopher Covington <cov@codeaurora.org> To: Catalin Marinas <catalin.marinas@arm.com>, criu@openvz.org, Laurent Dufour <ldufour@linux.vnet.ibm.com>, Will Deacon <Will.Deacon@arm.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Christopher Covington <cov@codeaurora.org> Subject: [RFC 2/5] mm/powerpc: Make VDSO unmap generic Date: Thu, 28 Apr 2016 11:18:54 -0400 [thread overview] Message-ID: <1461856737-17071-3-git-send-email-cov@codeaurora.org> (raw) In-Reply-To: <1461856737-17071-1-git-send-email-cov@codeaurora.org> In order to support unmapping the VDSO on additional architectures, move the unmap code out from arch/powerpc. Architectures that wish to use the generic logic must have an unsigned long vdso in mm->context and can opt in by selecting CONFIG_ARCH_WANT_VDSO_MAP. This allows PowerPC to go back to using the generic MM hooks, instead of carrying its own. Signed-off-by: Christopher Covington <cov@codeaurora.org> --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/mmu_context.h | 35 +--------------------------------- include/asm-generic/mm_hooks.h | 4 ++++ 3 files changed, 6 insertions(+), 34 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 7cd32c0..f74320e 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -160,6 +160,7 @@ config PPC select HAVE_ARCH_SECCOMP_FILTER select ARCH_HAS_UBSAN_SANITIZE_ALL select ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT + select ARCH_WANT_VDSO_MAP config GENERIC_CSUM def_bool CPU_LITTLE_ENDIAN diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h index 508b842..3e51842 100644 --- a/arch/powerpc/include/asm/mmu_context.h +++ b/arch/powerpc/include/asm/mmu_context.h @@ -8,6 +8,7 @@ #include <linux/spinlock.h> #include <asm/mmu.h> #include <asm/cputable.h> +#include <asm-generic/mm_hooks.h> #include <asm/cputhreads.h> /* @@ -126,39 +127,5 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, #endif } -static inline void arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) -{ -} - -static inline void arch_exit_mmap(struct mm_struct *mm) -{ -} - -static inline void arch_unmap(struct mm_struct *mm, - struct vm_area_struct *vma, - unsigned long start, unsigned long end) -{ - if (start <= mm->context.vdso && mm->context.vdso < end) - mm->context.vdso = 0; -} - -static inline void arch_bprm_mm_init(struct mm_struct *mm, - struct vm_area_struct *vma) -{ -} - -static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, - bool write, bool execute, bool foreign) -{ - /* by default, allow everything */ - return true; -} - -static inline bool arch_pte_access_permitted(pte_t pte, bool write) -{ - /* by default, allow everything */ - return true; -} #endif /* __KERNEL__ */ #endif /* __ASM_POWERPC_MMU_CONTEXT_H */ diff --git a/include/asm-generic/mm_hooks.h b/include/asm-generic/mm_hooks.h index cc5d9a14..6645116 100644 --- a/include/asm-generic/mm_hooks.h +++ b/include/asm-generic/mm_hooks.h @@ -19,6 +19,10 @@ static inline void arch_unmap(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long start, unsigned long end) { +#ifdef CONFIG_ARCH_WANT_VDSO_MAP + if (start <= mm->context.vdso && mm->context.vdso < end) + mm->context.vdso = 0; +#endif /* CONFIG_ARCH_WANT_VDSO_MAP */ } static inline void arch_bprm_mm_init(struct mm_struct *mm, -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christopher Covington <cov@codeaurora.org> To: Catalin Marinas <catalin.marinas@arm.com>, criu@openvz.org, Laurent Dufour <ldufour@linux.vnet.ibm.com>, Will Deacon <Will.Deacon@arm.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Christopher Covington <cov@codeaurora.org> Subject: [RFC 2/5] mm/powerpc: Make VDSO unmap generic Date: Thu, 28 Apr 2016 11:18:54 -0400 [thread overview] Message-ID: <1461856737-17071-3-git-send-email-cov@codeaurora.org> (raw) Message-ID: <20160428151854.8NuAMhCFLc7jiu8BafHsQXdRcNeyt45clL1ZOVq86hk@z> (raw) In-Reply-To: <1461856737-17071-1-git-send-email-cov@codeaurora.org> In order to support unmapping the VDSO on additional architectures, move the unmap code out from arch/powerpc. Architectures that wish to use the generic logic must have an unsigned long vdso in mm->context and can opt in by selecting CONFIG_ARCH_WANT_VDSO_MAP. This allows PowerPC to go back to using the generic MM hooks, instead of carrying its own. Signed-off-by: Christopher Covington <cov@codeaurora.org> --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/mmu_context.h | 35 +--------------------------------- include/asm-generic/mm_hooks.h | 4 ++++ 3 files changed, 6 insertions(+), 34 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 7cd32c0..f74320e 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -160,6 +160,7 @@ config PPC select HAVE_ARCH_SECCOMP_FILTER select ARCH_HAS_UBSAN_SANITIZE_ALL select ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT + select ARCH_WANT_VDSO_MAP config GENERIC_CSUM def_bool CPU_LITTLE_ENDIAN diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h index 508b842..3e51842 100644 --- a/arch/powerpc/include/asm/mmu_context.h +++ b/arch/powerpc/include/asm/mmu_context.h @@ -8,6 +8,7 @@ #include <linux/spinlock.h> #include <asm/mmu.h> #include <asm/cputable.h> +#include <asm-generic/mm_hooks.h> #include <asm/cputhreads.h> /* @@ -126,39 +127,5 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, #endif } -static inline void arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) -{ -} - -static inline void arch_exit_mmap(struct mm_struct *mm) -{ -} - -static inline void arch_unmap(struct mm_struct *mm, - struct vm_area_struct *vma, - unsigned long start, unsigned long end) -{ - if (start <= mm->context.vdso && mm->context.vdso < end) - mm->context.vdso = 0; -} - -static inline void arch_bprm_mm_init(struct mm_struct *mm, - struct vm_area_struct *vma) -{ -} - -static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, - bool write, bool execute, bool foreign) -{ - /* by default, allow everything */ - return true; -} - -static inline bool arch_pte_access_permitted(pte_t pte, bool write) -{ - /* by default, allow everything */ - return true; -} #endif /* __KERNEL__ */ #endif /* __ASM_POWERPC_MMU_CONTEXT_H */ diff --git a/include/asm-generic/mm_hooks.h b/include/asm-generic/mm_hooks.h index cc5d9a14..6645116 100644 --- a/include/asm-generic/mm_hooks.h +++ b/include/asm-generic/mm_hooks.h @@ -19,6 +19,10 @@ static inline void arch_unmap(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long start, unsigned long end) { +#ifdef CONFIG_ARCH_WANT_VDSO_MAP + if (start <= mm->context.vdso && mm->context.vdso < end) + mm->context.vdso = 0; +#endif /* CONFIG_ARCH_WANT_VDSO_MAP */ } static inline void arch_bprm_mm_init(struct mm_struct *mm, -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-28 15:18 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20151202121918.GA4523@arm.com> 2016-04-28 15:18 ` VDSO unmap and remap support for additional architectures Christopher Covington 2016-04-28 15:18 ` Christopher Covington 2016-04-28 15:18 ` [RFC 1/5] powerpc: Rename context.vdso_base to context.vdso Christopher Covington 2016-04-28 15:18 ` Christopher Covington 2016-05-02 1:05 ` Balbir Singh 2016-05-02 1:05 ` Balbir Singh 2016-05-04 21:21 ` Christopher Covington 2016-04-28 15:18 ` Christopher Covington [this message] 2016-04-28 15:18 ` [RFC 2/5] mm/powerpc: Make VDSO unmap generic Christopher Covington 2016-04-28 15:18 ` [RFC 3/5] mm/powerpc: Make VDSO remap generic Christopher Covington 2016-04-28 15:18 ` Christopher Covington 2016-04-28 15:18 ` [RFC 4/5] arm64: Use unsigned long for vdso Christopher Covington 2016-04-28 15:18 ` Christopher Covington 2016-04-28 15:18 ` [RFC 5/5] arm64: Gain VDSO unmap and remap powers Christopher Covington 2016-04-28 15:18 ` Christopher Covington 2016-04-28 18:53 ` VDSO unmap and remap support for additional architectures Andy Lutomirski 2016-04-28 18:53 ` Andy Lutomirski 2016-04-29 13:22 ` Christopher Covington 2016-04-29 13:22 ` Christopher Covington 2016-04-29 13:55 ` Dmitry Safonov 2016-04-29 13:55 ` Dmitry Safonov 2016-05-03 21:37 ` Christopher Covington 2016-05-03 21:37 ` Christopher Covington
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1461856737-17071-3-git-send-email-cov@codeaurora.org \ --to=cov@codeaurora.org \ --cc=Will.Deacon@arm.com \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=catalin.marinas@arm.com \ --cc=criu@openvz.org \ --cc=ldufour@linux.vnet.ibm.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).