From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: [PATCH v3 0/2] kbuild: Remove stale asm-generic wrappers Date: Mon, 23 May 2016 09:21:19 +0100 Message-ID: <1463991681-3531-1-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Sender: linux-kbuild-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , James Hogan , Michal Marek , Jonathan Corbet , Arnd Bergmann , Ralf Baechle , Paul Burton , Florian Fainelli , Heinrich Schuchardt , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org List-Id: linux-arch.vger.kernel.org This patchset attempts to fix kbuild to automatically remove stale asm-generic wrappers, i.e. when files are removed from generic-y and added directly into arch/*/include/uapi/asm/, but where the existing wrapper in arch/*/include/generated/asm/ continues to be used. MIPS was recently burned by this in v4.3 (see patch 2), with continuing reports of build failures when people upgrade their trees, which go away after arch/mips/include/generated is removed (or reportedly make mrproper/distclean). It is particularly irritating during bisection. Since v2 I've seen other cases of this breaking MIPS build, and testing on x86_64, starting a build first on v4.0 and then on mainline with this patchset shows one stale generated header: REMOVE arch/x86/include/generated/asm/scatterlist.h Changes in v3: - Ensure FORCE actually gets marked .PHONY. Changes in v2: - New patch 1 to add tracking of generated headers that aren't generic-y wrappers, via generated-y, particularly for x86 (thanks to kbuild test robot). - Rewrite a bit, drawing inspiration from Makefile.headersinst. - Exclude genhdr-y and generated-y (thanks to kbuild test robot). James Hogan (2): kbuild, x86: Track generated headers with generated-y kbuild: Remove stale asm-generic wrappers Documentation/kbuild/makefiles.txt | 14 ++++++++++++++ arch/x86/include/asm/Kbuild | 6 ++++++ scripts/Makefile.asm-generic | 17 ++++++++++++++++- 3 files changed, 36 insertions(+), 1 deletion(-) Cc: Michal Marek Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Jonathan Corbet Cc: Arnd Bergmann Cc: Ralf Baechle Cc: Paul Burton Cc: Florian Fainelli Cc: Heinrich Schuchardt Cc: linux-kbuild@vger.kernel.org Cc: x86@kernel.org Cc: linux-doc@vger.kernel.org Cc: linux-arch@vger.kernel.org Cc: linux-mips@linux-mips.org -- 2.4.10 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailapp01.imgtec.com ([195.59.15.196]:47801 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbcEWIVq (ORCPT ); Mon, 23 May 2016 04:21:46 -0400 From: James Hogan Subject: [PATCH v3 0/2] kbuild: Remove stale asm-generic wrappers Date: Mon, 23 May 2016 09:21:19 +0100 Message-ID: <1463991681-3531-1-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , James Hogan , Michal Marek , Jonathan Corbet , Arnd Bergmann , Ralf Baechle , Paul Burton , Florian Fainelli , Heinrich Schuchardt , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org Message-ID: <20160523082119.H2_Z5xMxPoJHX4Y5ZG7z0DGK6P3g244Y2S1O6Nc_BaY@z> This patchset attempts to fix kbuild to automatically remove stale asm-generic wrappers, i.e. when files are removed from generic-y and added directly into arch/*/include/uapi/asm/, but where the existing wrapper in arch/*/include/generated/asm/ continues to be used. MIPS was recently burned by this in v4.3 (see patch 2), with continuing reports of build failures when people upgrade their trees, which go away after arch/mips/include/generated is removed (or reportedly make mrproper/distclean). It is particularly irritating during bisection. Since v2 I've seen other cases of this breaking MIPS build, and testing on x86_64, starting a build first on v4.0 and then on mainline with this patchset shows one stale generated header: REMOVE arch/x86/include/generated/asm/scatterlist.h Changes in v3: - Ensure FORCE actually gets marked .PHONY. Changes in v2: - New patch 1 to add tracking of generated headers that aren't generic-y wrappers, via generated-y, particularly for x86 (thanks to kbuild test robot). - Rewrite a bit, drawing inspiration from Makefile.headersinst. - Exclude genhdr-y and generated-y (thanks to kbuild test robot). James Hogan (2): kbuild, x86: Track generated headers with generated-y kbuild: Remove stale asm-generic wrappers Documentation/kbuild/makefiles.txt | 14 ++++++++++++++ arch/x86/include/asm/Kbuild | 6 ++++++ scripts/Makefile.asm-generic | 17 ++++++++++++++++- 3 files changed, 36 insertions(+), 1 deletion(-) Cc: Michal Marek Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Jonathan Corbet Cc: Arnd Bergmann Cc: Ralf Baechle Cc: Paul Burton Cc: Florian Fainelli Cc: Heinrich Schuchardt Cc: linux-kbuild@vger.kernel.org Cc: x86@kernel.org Cc: linux-doc@vger.kernel.org Cc: linux-arch@vger.kernel.org Cc: linux-mips@linux-mips.org -- 2.4.10