From: James Hogan <james.hogan@imgtec.com> To: linux-arch@vger.kernel.org Cc: James Hogan <james.hogan@imgtec.com>, Nathan Lynch <nathan_lynch@mentor.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King <linux@armlinux.org.uk> Subject: [PATCH 2/5] ARM: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Date: Mon, 25 Jul 2016 16:59:51 +0100 [thread overview] Message-ID: <1469462394-8970-3-git-send-email-james.hogan@imgtec.com> (raw) In-Reply-To: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> AT_VECTOR_SIZE_ARCH should be defined with the maximum number of NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined for ARM at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when VDSO is enabled. This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for AT_BASE_PLATFORM which ARM doesn't use, but lets define it now and add the comment above ARCH_DLINFO as found in several other architectures to remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to date. Fixes: 1713ce7c4375 ("ARM: 8329/1: miscellaneous vdso infrastructure, preparation") Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Nathan Lynch <nathan_lynch@mentor.com> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/include/asm/elf.h | 1 + arch/arm/include/uapi/asm/auxvec.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm/include/asm/elf.h b/arch/arm/include/asm/elf.h index d2315ffd8f12..dc58133e33f1 100644 --- a/arch/arm/include/asm/elf.h +++ b/arch/arm/include/asm/elf.h @@ -129,6 +129,7 @@ extern void elf_set_personality(const struct elf32_hdr *); #ifdef CONFIG_MMU #ifdef CONFIG_VDSO +/* update AT_VECTOR_SIZE_ARCH if the number of NEW_AUX_ENT entries changes */ #define ARCH_DLINFO \ do { \ NEW_AUX_ENT(AT_SYSINFO_EHDR, \ diff --git a/arch/arm/include/uapi/asm/auxvec.h b/arch/arm/include/uapi/asm/auxvec.h index cb02a767a500..5ab9090356df 100644 --- a/arch/arm/include/uapi/asm/auxvec.h +++ b/arch/arm/include/uapi/asm/auxvec.h @@ -4,4 +4,6 @@ /* VDSO location */ #define AT_SYSINFO_EHDR 33 +#define AT_VECTOR_SIZE_ARCH 1 /* entries in ARCH_DLINFO */ + #endif -- 2.4.10
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com> To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, James Hogan <james.hogan@imgtec.com>, Russell King <linux@armlinux.org.uk>, Nathan Lynch <nathan_lynch@mentor.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] ARM: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Date: Mon, 25 Jul 2016 16:59:51 +0100 [thread overview] Message-ID: <1469462394-8970-3-git-send-email-james.hogan@imgtec.com> (raw) Message-ID: <20160725155951.ouTEMoAbXQ5_7T6HlLiWwNkdQjuTwlm2GzHXiyjy9-E@z> (raw) In-Reply-To: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> AT_VECTOR_SIZE_ARCH should be defined with the maximum number of NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined for ARM at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when VDSO is enabled. This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for AT_BASE_PLATFORM which ARM doesn't use, but lets define it now and add the comment above ARCH_DLINFO as found in several other architectures to remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to date. Fixes: 1713ce7c4375 ("ARM: 8329/1: miscellaneous vdso infrastructure, preparation") Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Nathan Lynch <nathan_lynch@mentor.com> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/include/asm/elf.h | 1 + arch/arm/include/uapi/asm/auxvec.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm/include/asm/elf.h b/arch/arm/include/asm/elf.h index d2315ffd8f12..dc58133e33f1 100644 --- a/arch/arm/include/asm/elf.h +++ b/arch/arm/include/asm/elf.h @@ -129,6 +129,7 @@ extern void elf_set_personality(const struct elf32_hdr *); #ifdef CONFIG_MMU #ifdef CONFIG_VDSO +/* update AT_VECTOR_SIZE_ARCH if the number of NEW_AUX_ENT entries changes */ #define ARCH_DLINFO \ do { \ NEW_AUX_ENT(AT_SYSINFO_EHDR, \ diff --git a/arch/arm/include/uapi/asm/auxvec.h b/arch/arm/include/uapi/asm/auxvec.h index cb02a767a500..5ab9090356df 100644 --- a/arch/arm/include/uapi/asm/auxvec.h +++ b/arch/arm/include/uapi/asm/auxvec.h @@ -4,4 +4,6 @@ /* VDSO location */ #define AT_SYSINFO_EHDR 33 +#define AT_VECTOR_SIZE_ARCH 1 /* entries in ARCH_DLINFO */ + #endif -- 2.4.10
next prev parent reply other threads:[~2016-07-25 15:59 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-25 15:59 [PATCH 0/5] Define AT_VECTOR_SIZE_ARCH correctly James Hogan 2016-07-25 15:59 ` [PATCH 1/5] MIPS: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO James Hogan 2016-07-25 15:59 ` James Hogan [this message] 2016-07-25 15:59 ` [PATCH 2/5] ARM: " James Hogan 2016-07-25 15:59 ` [PATCH 3/5] arm64: " James Hogan 2016-07-25 15:59 ` James Hogan 2016-07-25 15:59 ` [PATCH 4/5] s390: " James Hogan 2016-07-31 12:23 ` Martin Schwidefsky 2016-07-25 15:59 ` [PATCH 5/5] tile: " James Hogan 2016-07-25 16:37 ` Chris Metcalf 2016-07-25 19:10 ` James Hogan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1469462394-8970-3-git-send-email-james.hogan@imgtec.com \ --to=james.hogan@imgtec.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=nathan_lynch@mentor.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).