From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi Date: Mon, 27 Mar 2017 11:43:00 +0200 Message-ID: <1470ef61-3b51-869a-ded5-87b956e83d2d@6wind.com> References: <1489496093-15315-1-git-send-email-nicolas.dichtel@6wind.com> <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: Arnd Bergmann , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-arch@vger.kernel.org, David Airlie , "David S. Miller" , Russell King , bp@alien8.de, slash.tmp@free.fr, Daniel Vetter , rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de, hch@infradead.org, Tobias Klauser , mpe@ellerman.id.au, Ingo Molnar , Thomas Gleixner , "Dmitry V. Levin" , Herbert Xu , linux-rdma@vger.kernel.org List-Id: linux-arch.vger.kernel.org Le 27/03/2017 à 07:31, Masahiro Yamada a écrit : [snip] >> -#endif /* __ASM_H8300_BITS_PER_LONG */ >> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h >> new file mode 100644 >> index 000000000000..e56cf72369b6 >> --- /dev/null >> +++ b/arch/h8300/include/uapi/asm/bitsperlong.h >> @@ -0,0 +1,14 @@ >> +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG >> +#define _UAPI_ASM_H8300_BITS_PER_LONG > > > Just a minor comment. > > The include guard was originally __ASM_H8300_BITS_PER_LONG. > This will change it into _ASM_H8300_BITS_PER_LONG > (after _UAPI is stripped by headers_install.sh) > > I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, > but I know I am nit-picking. I can apply this as-is. > I leave it to you. I intentionnaly "clean" that, but I will restore it, no problem ;-) Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com ([209.85.128.182]:34920 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbdC0Jol (ORCPT ); Mon, 27 Mar 2017 05:44:41 -0400 Received: by mail-wr0-f182.google.com with SMTP id u1so47639100wra.2 for ; Mon, 27 Mar 2017 02:43:04 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi References: <1489496093-15315-1-git-send-email-nicolas.dichtel@6wind.com> <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> From: Nicolas Dichtel Message-ID: <1470ef61-3b51-869a-ded5-87b956e83d2d@6wind.com> Date: Mon, 27 Mar 2017 11:43:00 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Arnd Bergmann , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-arch@vger.kernel.org, David Airlie , "David S. Miller" , Russell King , bp@alien8.de, slash.tmp@free.fr, Daniel Vetter , rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de, hch@infradead.org, Tobias Klauser , mpe@ellerman.id.au, Ingo Molnar , Thomas Gleixner , "Dmitry V. Levin" , Herbert Xu , linux-rdma@vger.kernel.org Message-ID: <20170327094300.IlhXs4AQ9hbNgL3hce3Q_0O_iBu3GScD57Rh1rYEK_k@z> Le 27/03/2017 à 07:31, Masahiro Yamada a écrit : [snip] >> -#endif /* __ASM_H8300_BITS_PER_LONG */ >> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h >> new file mode 100644 >> index 000000000000..e56cf72369b6 >> --- /dev/null >> +++ b/arch/h8300/include/uapi/asm/bitsperlong.h >> @@ -0,0 +1,14 @@ >> +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG >> +#define _UAPI_ASM_H8300_BITS_PER_LONG > > > Just a minor comment. > > The include guard was originally __ASM_H8300_BITS_PER_LONG. > This will change it into _ASM_H8300_BITS_PER_LONG > (after _UAPI is stripped by headers_install.sh) > > I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, > but I know I am nit-picking. I can apply this as-is. > I leave it to you. I intentionnaly "clean" that, but I will restore it, no problem ;-) Regards, Nicolas