From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcgrof@kernel.org Subject: [PATCH v4 01/16] x86: remove LTO_REFERENCE_INITCALL() Date: Fri, 19 Aug 2016 14:32:50 -0700 Message-ID: <1471642385-5629-2-git-send-email-mcgrof@kernel.org> References: <1471642385-5629-1-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1471642385-5629-1-git-send-email-mcgrof@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, jpoimboe@redhat.com, bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org, masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com, heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, realmz6@gmail.com Cc: gnomes@lxorguk.ukuu.org.uk, linux-ia64@vger.kernel.org, jkosina@suse.cz, benh@kernel.crashing.org, ming.lei@canonical.com, linux@rasmusvillemoes.dk, platform-driver-x86@vger.kernel.org, James.Bottomley@HansenPartnership.com, paul.gortmaker@windriver.com, paulus@samba.org, sparclinux@vger.kernel.org, mchehab@osg.samsung.com, linux-arch@vger.kernel.org, markus.heiser@darmarit.de, xen-devel@lists.xensource.com, msalter@redhat.com, linux-sh@vger.kernel.org, mpe@ellerman.id.au, x86@kernel.org, fontana@sharpeleven.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, dvhart@infradead.org, dwmw2@infradead.org, linux-xtensa@linux-xtensa.org, pali.rohar@gmail.com, keescook@chromium.org, arnd@arndb.de, jani.nikula@intel.com, will.deacon@arm.com, rusty@rustcorp.com.au, rostedt@goodmis.org, acme@redhat.com, ak@linux.intel.com, andriy.shevchenko@linux.intel.com, mcb30@ip List-Id: linux-arch.vger.kernel.org RnJvbTogIkx1aXMgUi4gUm9kcmlndWV6IiA8bWNncm9mQGtlcm5lbC5vcmc+CgpUaGUgc2V0dXAg Zm9yIExUTyBuZXZlciBtYWRlIGl0IHVwc3RyZWFtLCBhbmQgYWx0aG91Z2ggdGhpcyBoYXMKc29t ZSB1c2VycywgdGhpcyBpcyBub3cgcmVhbGx5IG9sZCBzdHVmZiBmb3IgYSBnY2MgNC43IExUTyBw cm9ibGVtLgpXZSBrbm93IHRoYXQgYXQgbGVhc3QgTFRPX1JFRkVSRU5DRV9JTklUQ0FMTCgpIHdv cmsgYXJvdW5kIGNhbgpiZSByZW1vdmVkIGlmIExUTyBpcyBub3Qgc3VwcG9ydGVkIG9uIHY0Ljcg YW55bW9yZS4KCkFzIHBlciBBbmRpIHRoZSBESVNBQkxFX0xUTyBhbmQgTFRPX0NGTEFHUyBhcmUg c3RpbGwgbmVlZWRlZCB0aG91Z2guCgp2MzogYWRkZWQgdG8gdGhpcyBzZXJpZXMsIHJlbW92aW5n IExUT19SRUZFUkVOQ0VfSU5JVENBTEwoKQogICAganVzdGlmaWVzIHRoYXQgb3RoZXIgZnV0dXJl IHNpbWlsYXIgbWFjcm9zIGRvIG5vdCBuZWVkCiAgICBhIHJlc3BlY3RpdmUgTFRPX1JFRkVSRU5D RV9JTklUQ0FMTCgpIG9uIHRoZW0gdGhlcmVmb3JlCiAgICBzaW1wbGlmeWluZyBuZXcgY29kZS4K CkFja2VkLWJ5OiBBbmRpIEtsZWVuIDxha0BsaW51eC5pbnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6 IEx1aXMgUi4gUm9kcmlndWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4KLS0tCiBpbmNsdWRlL2xpbnV4 L2luaXQuaCB8IDIwICstLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaW5p dC5oIGIvaW5jbHVkZS9saW51eC9pbml0LmgKaW5kZXggMWU1YzEzMWQ1YzlhLi5hYTY2MmFkODBk OWMgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvbGludXgvaW5pdC5oCisrKyBiL2luY2x1ZGUvbGludXgv aW5pdC5oCkBAIC0xNTEsMjMgKzE1MSw2IEBAIGV4dGVybiBib29sIGluaXRjYWxsX2RlYnVnOwog CiAjaWZuZGVmIF9fQVNTRU1CTFlfXwogCi0jaWZkZWYgQ09ORklHX0xUTwotLyogV29yayBhcm91 bmQgYSBMVE8gZ2NjIHByb2JsZW06IHdoZW4gdGhlcmUgaXMgbm8gcmVmZXJlbmNlIHRvIGEgdmFy aWFibGUKLSAqIGluIGEgbW9kdWxlIGl0IHdpbGwgYmUgbW92ZWQgdG8gdGhlIGVuZCBvZiB0aGUg cHJvZ3JhbS4gVGhpcyBjYXVzZXMKLSAqIHJlb3JkZXJpbmcgb2YgaW5pdGNhbGxzIHdoaWNoIHRo ZSBrZXJuZWwgZG9lcyBub3QgbGlrZS4KLSAqIEFkZCBhIGR1bW15IHJlZmVyZW5jZSBmdW5jdGlv biB0byBhdm9pZCB0aGlzLiBUaGUgZnVuY3Rpb24gaXMKLSAqIGRlbGV0ZWQgYnkgdGhlIGxpbmtl ci4KLSAqLwotI2RlZmluZSBMVE9fUkVGRVJFTkNFX0lOSVRDQUxMKHgpIFwKLQk7IC8qIHllcyB0 aGlzIGlzIG5lZWRlZCAqLwkJCVwKLQlzdGF0aWMgX191c2VkIF9fZXhpdCB2b2lkICpyZWZlcmVu Y2VfIyN4KHZvaWQpCVwKLQl7CQkJCQkJXAotCQlyZXR1cm4gJng7CQkJCVwKLQl9Ci0jZWxzZQot I2RlZmluZSBMVE9fUkVGRVJFTkNFX0lOSVRDQUxMKHgpCi0jZW5kaWYKLQogLyogaW5pdGNhbGxz IGFyZSBub3cgZ3JvdXBlZCBieSBmdW5jdGlvbmFsaXR5IGludG8gc2VwYXJhdGUgCiAgKiBzdWJz ZWN0aW9ucy4gT3JkZXJpbmcgaW5zaWRlIHRoZSBzdWJzZWN0aW9ucyBpcyBkZXRlcm1pbmVkCiAg KiBieSBsaW5rIG9yZGVyLiAKQEAgLTE4MCw4ICsxNjMsNyBAQCBleHRlcm4gYm9vbCBpbml0Y2Fs bF9kZWJ1ZzsKIAogI2RlZmluZSBfX2RlZmluZV9pbml0Y2FsbChmbiwgaWQpIFwKIAlzdGF0aWMg aW5pdGNhbGxfdCBfX2luaXRjYWxsXyMjZm4jI2lkIF9fdXNlZCBcCi0JX19hdHRyaWJ1dGVfXygo X19zZWN0aW9uX18oIi5pbml0Y2FsbCIgI2lkICIuaW5pdCIpKSkgPSBmbjsgXAotCUxUT19SRUZF UkVOQ0VfSU5JVENBTEwoX19pbml0Y2FsbF8jI2ZuIyNpZCkKKwlfX2F0dHJpYnV0ZV9fKChfX3Nl Y3Rpb25fXygiLmluaXRjYWxsIiAjaWQgIi5pbml0IikpKSA9IGZuOwogCiAvKgogICogRWFybHkg aW5pdGNhbGxzIHJ1biBiZWZvcmUgaW5pdGlhbGl6aW5nIFNNUC4KLS0gCjIuOS4yCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:42858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873AbcHSVlP (ORCPT ); Fri, 19 Aug 2016 17:41:15 -0400 From: mcgrof@kernel.org Subject: [PATCH v4 01/16] x86: remove LTO_REFERENCE_INITCALL() Date: Fri, 19 Aug 2016 14:32:50 -0700 Message-ID: <1471642385-5629-2-git-send-email-mcgrof@kernel.org> In-Reply-To: <1471642385-5629-1-git-send-email-mcgrof@kernel.org> References: <1471642385-5629-1-git-send-email-mcgrof@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, jpoimboe@redhat.com, bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org, masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com, heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, realmz6@gmail.com Cc: x86@kernel.org, luto@amacapital.net, keescook@chromium.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, rusty@rustcorp.com.au, gnomes@lxorguk.ukuu.org.uk, alan@linux.intel.com, dwmw2@infradead.org, arnd@arndb.de, ming.lei@canonical.com, linux-arch@vger.kernel.org, benh@kernel.crashing.org, ananth@in.ibm.com, pebolle@tiscali.nl, fontana@sharpeleven.org, david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com, andrew.cooper3@citrix.com, andriy.shevchenko@linux.intel.com, paul.gortmaker@windriver.com, xen-devel@lists.xensource.com, ak@linux.intel.com, pali.rohar@gmail.com, dvhart@infradead.org, platform-driver-x86@vger.kernel.org, mmarek@suse.com, linux@rasmusvillemoes.dk, jkosina@suse.cz, korea.drzix@gmail.com, linux-kbuild@vger.kernel.org, tony.luck@intel.com, akpm@linux-foundation.org, linux-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, rostedt@goodmis.org, jani.nikula@intel.com, mchehab@osg.samsung.com, markus.heiser@darmarit.de, acme@redhat.com, jolsa@kernel.org, msalter@redhat.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, paulus@samba.org, mpe@ellerman.id.au, James.Bottomley@HansenPartnership.com, "Luis R. Rodriguez" Message-ID: <20160819213250.koBLUZDi87sCxefNdXmHEHuYp72sDrCZH3tanyBZ0DY@z> From: "Luis R. Rodriguez" The setup for LTO never made it upstream, and although this has some users, this is now really old stuff for a gcc 4.7 LTO problem. We know that at least LTO_REFERENCE_INITCALL() work around can be removed if LTO is not supported on v4.7 anymore. As per Andi the DISABLE_LTO and LTO_CFLAGS are still neeeded though. v3: added to this series, removing LTO_REFERENCE_INITCALL() justifies that other future similar macros do not need a respective LTO_REFERENCE_INITCALL() on them therefore simplifying new code. Acked-by: Andi Kleen Signed-off-by: Luis R. Rodriguez --- include/linux/init.h | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/include/linux/init.h b/include/linux/init.h index 1e5c131d5c9a..aa662ad80d9c 100644 --- a/include/linux/init.h +++ b/include/linux/init.h @@ -151,23 +151,6 @@ extern bool initcall_debug; #ifndef __ASSEMBLY__ -#ifdef CONFIG_LTO -/* Work around a LTO gcc problem: when there is no reference to a variable - * in a module it will be moved to the end of the program. This causes - * reordering of initcalls which the kernel does not like. - * Add a dummy reference function to avoid this. The function is - * deleted by the linker. - */ -#define LTO_REFERENCE_INITCALL(x) \ - ; /* yes this is needed */ \ - static __used __exit void *reference_##x(void) \ - { \ - return &x; \ - } -#else -#define LTO_REFERENCE_INITCALL(x) -#endif - /* initcalls are now grouped by functionality into separate * subsections. Ordering inside the subsections is determined * by link order. @@ -180,8 +163,7 @@ extern bool initcall_debug; #define __define_initcall(fn, id) \ static initcall_t __initcall_##fn##id __used \ - __attribute__((__section__(".initcall" #id ".init"))) = fn; \ - LTO_REFERENCE_INITCALL(__initcall_##fn##id) + __attribute__((__section__(".initcall" #id ".init"))) = fn; /* * Early initcalls run before initializing SMP. -- 2.9.2