From: Baoyou Xie <baoyou.xie@linaro.org>
To: ralf@linux-mips.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, arnd@arndb.de,
akpm@linux-foundation.org, paul.burton@imgtec.com,
chenhc@lemote.com, david.daney@cavium.com, kumba@gentoo.org,
yamada.masahiro@socionext.com, kirill.shutemov@linux.intel.com,
dave.hansen@linux.intel.com, toshi.kani@hpe.com,
dan.j.williams@intel.com, luto@kernel.org, JBeulich@suse.com
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, baoyou.xie@linaro.org,
xie.baoyou@zte.com.cn
Subject: [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration to pgtable.h
Date: Tue, 13 Sep 2016 15:26:37 +0800 [thread overview]
Message-ID: <1473751597-12139-1-git-send-email-baoyou.xie@linaro.org> (raw)
We get 1 warning when building kernel with W=1:
drivers/char/mem.c:220:12: warning: no previous prototype for 'phys_mem_access_prot_allowed' [-Wmissing-prototypes]
int __weak phys_mem_access_prot_allowed(struct file *file,
In fact, its declaration is spreading to several header files
in different architecture, but need to be declare in common
header file.
So this patch moves phys_mem_access_prot_allowed() to pgtable.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
arch/mips/include/asm/pgtable.h | 2 --
arch/x86/include/asm/pgtable_types.h | 2 --
include/asm-generic/pgtable.h | 3 +++
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h
index 70128d3..9e9e944 100644
--- a/arch/mips/include/asm/pgtable.h
+++ b/arch/mips/include/asm/pgtable.h
@@ -673,8 +673,6 @@ static inline pmd_t pmdp_huge_get_and_clear(struct mm_struct *mm,
struct file;
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
unsigned long size, pgprot_t vma_prot);
-int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
- unsigned long size, pgprot_t *vma_prot);
#endif
/*
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index f1218f5..8b4de22 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -439,8 +439,6 @@ extern pgprot_t pgprot_writethrough(pgprot_t prot);
struct file;
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
unsigned long size, pgprot_t vma_prot);
-int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
- unsigned long size, pgprot_t *vma_prot);
/* Install a pte for a particular vaddr in kernel space. */
void set_pte_vaddr(unsigned long vaddr, pte_t pte);
diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index d4458b6..c4f8fd2 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -800,6 +800,9 @@ static inline int pmd_clear_huge(pmd_t *pmd)
#endif
#endif
+struct file;
+int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
+ unsigned long size, pgprot_t *vma_prot);
#endif /* !__ASSEMBLY__ */
#ifndef io_remap_pfn_range
--
2.7.4
next reply other threads:[~2016-09-13 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:26 Baoyou Xie [this message]
2016-09-13 12:50 ` [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration to pgtable.h Thomas Gleixner
2016-09-16 13:55 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473751597-12139-1-git-send-email-baoyou.xie@linaro.org \
--to=baoyou.xie@linaro.org \
--cc=JBeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=chenhc@lemote.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david.daney@cavium.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kumba@gentoo.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
--cc=xie.baoyou@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).