From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: [PATCHv2 2/2] thread_info: include for THREAD_INFO_IN_TASK Date: Wed, 26 Oct 2016 18:43:07 +0100 Message-ID: <1477503787-25537-3-git-send-email-mark.rutland@arm.com> References: <1477503787-25537-1-git-send-email-mark.rutland@arm.com> Return-path: In-Reply-To: <1477503787-25537-1-git-send-email-mark.rutland@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, akpm@linux-foundation.org, heiko.carstens@de.ibm.com, keescook@chromium.org, luto@kernel.org, mark.rutland@arm.com List-Id: linux-arch.vger.kernel.org When CONFIG_THREAD_INFO_IN_TASK is selected, the current_thread_info() macro relies on current having been defined prior to its use. However, not all users of current_thread_info() include , and thus current is not guaranteed to be defined. When CONFIG_THREAD_INFO_IN_TASK is not selected, it's possible that get_current() / current are based upon current_thread_info(), and includes . Thus always including would result in circular dependences on some platforms. To ensure both cases work, this patch includes , but only when CONFIG_THREAD_INFO_IN_TASK is selected. Signed-off-by: Mark Rutland Acked-by: Heiko Carstens Cc: Andrew Morton Cc: Andy Lutomirski Cc: Kees Cook Cc: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- include/linux/thread_info.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index c75c6ab..ef1f4b0 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -12,6 +12,7 @@ #include #ifdef CONFIG_THREAD_INFO_IN_TASK +#include #define current_thread_info() ((struct thread_info *)current) #endif -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:48634 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933819AbcJZRns (ORCPT ); Wed, 26 Oct 2016 13:43:48 -0400 From: Mark Rutland Subject: [PATCHv2 2/2] thread_info: include for THREAD_INFO_IN_TASK Date: Wed, 26 Oct 2016 18:43:07 +0100 Message-ID: <1477503787-25537-3-git-send-email-mark.rutland@arm.com> In-Reply-To: <1477503787-25537-1-git-send-email-mark.rutland@arm.com> References: <1477503787-25537-1-git-send-email-mark.rutland@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, akpm@linux-foundation.org, heiko.carstens@de.ibm.com, keescook@chromium.org, luto@kernel.org, mark.rutland@arm.com Message-ID: <20161026174307.R6D1LMUyAZLv6P1-EkQraa5Lq5-gcaXPGt5LCsNMaH0@z> When CONFIG_THREAD_INFO_IN_TASK is selected, the current_thread_info() macro relies on current having been defined prior to its use. However, not all users of current_thread_info() include , and thus current is not guaranteed to be defined. When CONFIG_THREAD_INFO_IN_TASK is not selected, it's possible that get_current() / current are based upon current_thread_info(), and includes . Thus always including would result in circular dependences on some platforms. To ensure both cases work, this patch includes , but only when CONFIG_THREAD_INFO_IN_TASK is selected. Signed-off-by: Mark Rutland Acked-by: Heiko Carstens Cc: Andrew Morton Cc: Andy Lutomirski Cc: Kees Cook Cc: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- include/linux/thread_info.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index c75c6ab..ef1f4b0 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -12,6 +12,7 @@ #include #ifdef CONFIG_THREAD_INFO_IN_TASK +#include #define current_thread_info() ((struct thread_info *)current) #endif -- 1.9.1