From: David Howells <dhowells@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: dhowells@redhat.com, linux-arch@vger.kernel.org, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] Add assertion checking macros
Date: Tue, 20 Dec 2011 15:38:05 +0000 [thread overview]
Message-ID: <14844.1324395485@redhat.com> (raw)
In-Reply-To: <m21us4qjuy.fsf@firstfloor.org>
Andi Kleen <andi@firstfloor.org> wrote:
> David Howells <dhowells@redhat.com> writes:
> >
> > There is no need to display val here in the case the expression fails
> > since it can only be 0. If this fails, it produces an error like the
> > following:
> >
> > ------------[ cut here ]------------
> > kernel BUG at fs/fscache/main.c:109!
> > ASSERTION FAILED
>
> It would be nice to display the expression here like an user space
> assert. While it can be looked up in the source it would
> make quick eyeballing easier.
>
> Probably wouldn't cost too much additional text size?
It can easily be made selectable. I don't think text size should be much of
an issue - but it will also add a bunch of strings (preprocessed expressions)
to the rodata, and I'm not sure how big those can get - particularly if
they've got nested macros within (test_bit() for example).
David
next prev parent reply other threads:[~2011-12-20 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 14:13 [PATCH 1/7] Add conditional oopsing with annotation David Howells
2011-12-16 14:14 ` [PATCH 2/7] Make shrink_dcache_for_umount_subtree() use ANNOTATED_BUG() David Howells
2011-12-16 14:14 ` [PATCH 3/7] Add assertion checking macros David Howells
2011-12-16 14:14 ` David Howells
2011-12-16 21:36 ` Andi Kleen
2011-12-20 15:38 ` David Howells [this message]
2011-12-16 14:14 ` [PATCH 4/7] FS-Cache: Use new core assertion macros David Howells
2011-12-16 14:14 ` [PATCH 5/7] CacheFiles: " David Howells
2011-12-16 14:14 ` [PATCH 6/7] AFS: " David Howells
2011-12-16 14:14 ` David Howells
2011-12-16 14:14 ` [PATCH 7/7] RxRPC: " David Howells
2011-12-16 14:14 ` David Howells
2011-12-17 19:15 ` [PATCH 1/7] Add conditional oopsing with annotation Mike Frysinger
2011-12-17 19:15 ` Mike Frysinger
2011-12-18 8:02 ` Ingo Molnar
2011-12-20 15:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14844.1324395485@redhat.com \
--to=dhowells@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).