From: Babu Moger <babu.moger@oracle.com>
To: davem@davemloft.net, peterz@infradead.org, mingo@redhat.com,
arnd@arndb.de
Cc: babu.moger@oracle.com, shannon.nelson@oracle.com,
haakon.bugge@oracle.com, steven.sistare@oracle.com,
vijay.ac.kumar@oracle.com, jane.chu@oracle.com,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: [PATCH v3 1/7] arch/sparc: Remove the check #ifndef __LINUX_SPINLOCK_TYPES_H
Date: Tue, 23 May 2017 15:45:52 -0600 [thread overview]
Message-ID: <1495575958-1022566-2-git-send-email-babu.moger@oracle.com> (raw)
In-Reply-To: <1495575958-1022566-1-git-send-email-babu.moger@oracle.com>
Saw these compile errors on SPARC when queued rwlock feature is enabled.
CC kernel/locking/qrwlock.o
In file included from ./include/asm-generic/qrwlock_types.h:5,
from ./arch/sparc/include/asm/qrwlock.h:4,
from kernel/locking/qrwlock.c:24:
./arch/sparc/include/asm/spinlock_types.h:5:3: error:
#error "please don't include this file directly"
SPARC has this guard which causes compile error when spinlock_types.h
is included directly.
@ifndef __LINUX_SPINLOCK_TYPES_H
@ error "please don't include this file directly"
@endif
Remove this un-necessary "ifndef __LINUX_SPINLOCK_TYPES_H" stanza from SPARC.
Signed-off-by: Babu Moger <babu.moger@oracle.com>
Suggested-by: David Miller <davem@davemloft.net>
---
arch/sparc/include/asm/spinlock_types.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/sparc/include/asm/spinlock_types.h b/arch/sparc/include/asm/spinlock_types.h
index 9c454fd..019c085 100644
--- a/arch/sparc/include/asm/spinlock_types.h
+++ b/arch/sparc/include/asm/spinlock_types.h
@@ -1,10 +1,6 @@
#ifndef __SPARC_SPINLOCK_TYPES_H
#define __SPARC_SPINLOCK_TYPES_H
-#ifndef __LINUX_SPINLOCK_TYPES_H
-# error "please don't include this file directly"
-#endif
-
typedef struct {
volatile unsigned char lock;
} arch_spinlock_t;
--
1.7.1
next prev parent reply other threads:[~2017-05-23 21:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 21:45 [PATCH v3 0/7] Enable queued rwlock and queued spinlock for SPARC Babu Moger
2017-05-23 21:45 ` Babu Moger
2017-05-23 21:45 ` Babu Moger [this message]
2017-05-23 21:45 ` [PATCH v3 1/7] arch/sparc: Remove the check #ifndef __LINUX_SPINLOCK_TYPES_H Babu Moger
2017-05-23 21:45 ` [PATCH v3 2/7] kernel/locking: Fix compile error with qrwlock.c Babu Moger
2017-05-23 21:45 ` Babu Moger
2017-05-23 21:45 ` [PATCH v3 3/7] arch/sparc: Define config parameter CPU_BIG_ENDIAN Babu Moger
2017-05-23 21:45 ` Babu Moger
2017-05-24 9:48 ` Geert Uytterhoeven
2017-05-24 9:48 ` Geert Uytterhoeven
2017-05-24 14:37 ` Babu Moger
2017-05-23 21:45 ` [PATCH v3 4/7] arch/sparc: Introduce cmpxchg_u8 SPARC Babu Moger
2017-05-23 21:45 ` Babu Moger
2017-05-23 21:45 ` [PATCH v3 5/7] arch/sparc: Enable queued rwlocks for SPARC Babu Moger
2017-05-23 21:45 ` [PATCH v3 6/7] arch/sparc: Introduce xchg16 " Babu Moger
2017-05-23 21:45 ` Babu Moger
2017-05-23 21:45 ` [PATCH v3 7/7] arch/sparc: Enable queued spinlock support " Babu Moger
2017-05-23 21:45 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495575958-1022566-2-git-send-email-babu.moger@oracle.com \
--to=babu.moger@oracle.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=haakon.bugge@oracle.com \
--cc=jane.chu@oracle.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=steven.sistare@oracle.com \
--cc=vijay.ac.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).