From: Arnd Bergmann <arnd@arndb.de>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Michal Marek <mmarek@suse.com>,
Adam Borowski <kilobyte@angband.pl>,
Omar Sandoval <osandov@osandov.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
adobriyan@gmail.com, sfr@canb.auug.org.au,
viro@zeniv.linux.org.uk, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: [PATCH 2/2, variant B] ARM: move mmiocpy/mmioset exports to io.c
Date: Mon, 24 Oct 2016 17:06:45 +0200 [thread overview]
Message-ID: <14981419.nRUFpzhctm@wuerfel> (raw)
In-Reply-To: <3446653.W8FbGAKSeQ@wuerfel>
The prototypes for mmioset/mmiocpy are intentionally hidden
inside of inline functions, which breaks the EXPORT_SYMBOL
statements when symbol versioning is enabled.
This moves the two exports from the files that implement the
code into the kernel/io.c file, adding another local declaration
there.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/arch/arm/kernel/io.c b/arch/arm/kernel/io.c
index eedefe050022..c74746997626 100644
--- a/arch/arm/kernel/io.c
+++ b/arch/arm/kernel/io.c
@@ -82,3 +82,10 @@ void _memset_io(volatile void __iomem *dst, int c, size_t count)
}
}
EXPORT_SYMBOL(_memset_io);
+
+/* can't export them from memcpy.S/memset.S because of hidden declaration */
+void mmioset(void __iomem *addr, unsigned int c, size_t n);
+EXPORT_SYMBOL(mmioset);
+
+void mmiocpy(void *dest, const void __iomem *src, size_t n);
+EXPORT_SYMBOL(mmiocpy);
diff --git a/arch/arm/lib/memcpy.S b/arch/arm/lib/memcpy.S
index 1be5b6ddf37c..1f822fc52400 100644
--- a/arch/arm/lib/memcpy.S
+++ b/arch/arm/lib/memcpy.S
@@ -70,4 +70,3 @@ ENTRY(memcpy)
ENDPROC(memcpy)
ENDPROC(mmiocpy)
EXPORT_SYMBOL(memcpy)
-EXPORT_SYMBOL(mmiocpy)
diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S
index 7b72044cba62..6f075ca09abc 100644
--- a/arch/arm/lib/memset.S
+++ b/arch/arm/lib/memset.S
@@ -137,4 +137,3 @@ UNWIND( .fnend )
ENDPROC(memset)
ENDPROC(mmioset)
EXPORT_SYMBOL(memset)
-EXPORT_SYMBOL(mmioset)
next prev parent reply other threads:[~2016-10-24 15:06 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161017065131.GA27863@angband.pl>
2016-10-17 6:59 ` [GIT PULL] kbuild changes for v4.9-rc1 Nicholas Piggin
2016-10-17 6:59 ` Nicholas Piggin
2016-10-17 10:01 ` Adam Borowski
2016-10-17 10:01 ` Adam Borowski
2016-10-17 11:12 ` Alexey Dobriyan
2016-10-17 11:12 ` Alexey Dobriyan
2016-10-17 11:17 ` Geert Uytterhoeven
2016-10-17 11:32 ` Alexey Dobriyan
2016-10-17 11:32 ` Alexey Dobriyan
2016-10-17 12:22 ` Mathieu OTHACEHE
2016-10-18 0:16 ` Adam Borowski
2016-10-18 0:16 ` Adam Borowski
2016-10-18 1:34 ` Nicholas Piggin
2016-10-19 14:38 ` Michal Marek
2016-10-19 14:38 ` Michal Marek
2016-10-20 3:52 ` Nicholas Piggin
2016-10-20 3:52 ` Nicholas Piggin
2016-10-27 8:10 ` Kalle Valo
2016-10-27 8:10 ` Kalle Valo
2016-10-27 11:15 ` Nicholas Piggin
2016-10-27 11:15 ` Nicholas Piggin
2016-10-27 13:14 ` Kalle Valo
2016-10-27 13:14 ` Kalle Valo
2016-10-27 13:25 ` Nicholas Piggin
2016-10-27 13:25 ` Nicholas Piggin
2016-10-30 10:51 ` Thorsten Leemhuis
2016-10-30 10:51 ` Thorsten Leemhuis
2016-11-01 15:48 ` Michal Marek
2016-11-01 15:48 ` Michal Marek
2016-11-02 12:11 ` Adam Borowski
2016-11-02 12:11 ` Adam Borowski
2016-11-02 12:14 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for x86 Adam Borowski
2016-11-02 12:14 ` Adam Borowski
2016-12-16 19:55 ` [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby
2016-12-16 19:55 ` Jiri Slaby
2016-12-16 19:57 ` Linus Torvalds
2016-12-17 8:57 ` Jiri Slaby
2016-12-17 8:57 ` Jiri Slaby
2016-12-17 9:33 ` Adam Borowski
2016-12-17 9:33 ` Adam Borowski
2016-12-17 23:59 ` Linus Torvalds
2016-12-17 23:59 ` Linus Torvalds
2016-12-18 10:49 ` Jiri Slaby
2016-12-18 11:03 ` Arend Van Spriel
2016-12-18 11:03 ` Arend Van Spriel
2016-12-18 13:27 ` Nikolay Borisov
2016-12-18 13:27 ` Nikolay Borisov
2016-12-18 14:45 ` Jiri Slaby
2016-12-18 14:54 ` Nikolay Borisov
2016-12-18 15:08 ` Jiri Slaby
2016-10-17 12:26 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM Arnd Bergmann
2016-10-19 14:52 ` Michal Marek
2016-10-19 14:52 ` Michal Marek
2016-10-19 15:02 ` Arnd Bergmann
2016-10-19 15:02 ` Arnd Bergmann
2016-10-19 15:32 ` Russell King - ARM Linux
2016-10-19 15:32 ` Russell King - ARM Linux
2016-10-20 4:08 ` Nicholas Piggin
2016-10-20 13:17 ` Russell King - ARM Linux
2016-10-20 13:17 ` Russell King - ARM Linux
2016-10-20 14:20 ` Nicholas Piggin
2016-10-20 14:20 ` Nicholas Piggin
2016-10-20 14:33 ` Russell King - ARM Linux
2016-10-20 14:33 ` Russell King - ARM Linux
2016-10-20 14:51 ` Nicholas Piggin
2016-10-20 14:51 ` Nicholas Piggin
2016-10-22 19:51 ` Michal Marek
2016-10-24 15:04 ` Arnd Bergmann
2016-10-24 15:05 ` [PATCH 1/2] " Arnd Bergmann
2016-10-24 15:05 ` Arnd Bergmann
2016-10-25 8:32 ` Nicholas Piggin
2016-11-20 13:21 ` Russell King - ARM Linux
2016-11-20 18:32 ` Linus Torvalds
2016-11-20 19:12 ` Russell King - ARM Linux
2016-11-20 19:12 ` Russell King - ARM Linux
2016-11-21 6:10 ` Nicholas Piggin
2016-11-21 6:10 ` Nicholas Piggin
2016-11-21 18:46 ` Bug#844530: [1/2] " Uwe Kleine-König
2016-11-21 18:46 ` Uwe Kleine-König
2016-11-21 19:13 ` Russell King - ARM Linux
2016-11-21 19:13 ` Russell King - ARM Linux
2016-11-22 1:01 ` Nicholas Piggin
2016-10-24 15:06 ` [PATCH 2/2, variant A] ARM: add hidden mmioset/mmiocpy prototypes Arnd Bergmann
2016-10-24 15:06 ` Arnd Bergmann
2016-10-24 15:06 ` Arnd Bergmann [this message]
2016-10-24 15:06 ` [PATCH 2/2, variant B] ARM: move mmiocpy/mmioset exports to io.c Arnd Bergmann
2016-10-20 7:37 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM Geert Uytterhoeven
2016-10-20 8:20 ` Russell King - ARM Linux
2016-10-20 8:20 ` Russell King - ARM Linux
2016-10-20 8:23 ` Geert Uytterhoeven
2016-10-20 8:23 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14981419.nRUFpzhctm@wuerfel \
--to=arnd@arndb.de \
--cc=adobriyan@gmail.com \
--cc=kilobyte@angband.pl \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmarek@suse.com \
--cc=npiggin@gmail.com \
--cc=osandov@osandov.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).