From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D3BC433E0 for ; Sat, 13 Mar 2021 09:27:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78FF064F1E for ; Sat, 13 Mar 2021 09:27:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232731AbhCMJ0p (ORCPT ); Sat, 13 Mar 2021 04:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232331AbhCMJ0N (ORCPT ); Sat, 13 Mar 2021 04:26:13 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D7A4C061574; Sat, 13 Mar 2021 01:26:13 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id 18so49194010lff.6; Sat, 13 Mar 2021 01:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VxsRaCYGnlKyw9cBJuU8/XC7Ex+0yUqWLoNjE+h24RE=; b=BcDwH5ufeQE6u2QTFQIJvhO3uJvuy3848WIfNn/G0h9ttbUKPub2+zAf+Et3IQJfs9 OuViCnfXBhhNlmSuGNocjnuJ+QOQirhB+cjma79DQLrDM6fEh/sgLzSAdHdVf1CA7eEh BmnzW5T5PtbGTRu7MpOamh7q4pXHNm+Ka78+RUzATw1r8A4GqZJysjPZtB6dbRQq2iug 6RLgyDKJa6LTPqTpW8tZlK5u2saHl4kkbQyi7eQE3fHLYI638jq8tuOqukFJ9q+9s2yT eCsjxfdXlPgWCV6MGwFZ7Qf56v2KD2gVCFKxHDtOyZru2lqIV7TsSytk+YlDM8EvL9Bb dyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VxsRaCYGnlKyw9cBJuU8/XC7Ex+0yUqWLoNjE+h24RE=; b=PP165ZgHzVGnDNa7hYrb+5VUlwE5a5yZv5wJHFxs7CvAGuMTZF0xTTAQpQcFIjM93K h3AnjDJjY4SC7K9sLiDHwf/WEXc1kTmKUgMZHnrRP0cQJSoHMV5eGhYcrK14qeyazdmQ o1nGZzHRCk5tZWrpHwDixoElzquCQ/ysii6F9cG76ClJC1Z9fxgIcFZC+l+K89CToAVk Gcvyb9TpTmK2Ai9Dy5YbvZNhJ3pkfLbxcbWTUHQFtMVYaADaxIG5W4UAg9p/nJs26cXu o++yu+jTXr/+RuYB91yPLhR63UiFcmGbq+8qmjCprdAbSeiRt09V6Hcb+QxflYNaaWpt lmvA== X-Gm-Message-State: AOAM533MxeC0TZLa6RPS8Lu+7IlGtQUuHwyWir2vspfMc4xwKxFqr3ih 9zu/YSYPQwgndm/+zRhSp9zHBK0zipzqeQ== X-Google-Smtp-Source: ABdhPJzcSTSqsIdnI30O1V5AQzJi6oRKcOU1zsOM6LcAktO3sTlVUFywWYUi73G8t7ARLpfhFIv/+A== X-Received: by 2002:a19:b03:: with SMTP id 3mr2186669lfl.236.1615627571657; Sat, 13 Mar 2021 01:26:11 -0800 (PST) Received: from [192.168.1.101] ([31.173.82.251]) by smtp.gmail.com with ESMTPSA id w5sm1976524lfu.179.2021.03.13.01.26.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Mar 2021 01:26:11 -0800 (PST) Subject: Re: [PATCH 5/6] ftrace: introduce FTRACE_IP_EXTENSION To: Huang Pei , Thomas Bogendoerfer , ambrosehua@gmail.com Cc: Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , "Maciej W . Rozycki" , Steven Rostedt , Jisheng Zhang , Masami Hiramatsu References: <20210313064149.29276-1-huangpei@loongson.cn> <20210313064149.29276-6-huangpei@loongson.cn> From: Sergei Shtylyov Message-ID: <14999d3c-ebfd-ed20-b87a-77e536a4a606@gmail.com> Date: Sat, 13 Mar 2021 12:26:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210313064149.29276-6-huangpei@loongson.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Hello! On 3/13/21 9:41 AM, Huang Pei wrote: > From: Jisheng Zhang > > On some architectures, the DYNAMIC_FTRACE_WITH_REGS is implemented by > gcc's -fpatchable-function-entry option. Take arm64 for example, arm64 > makes use of GCC -fpatchable-function-entry=2 option to insert two > nops. When the function is traced, the first nop will be modified to > the LR saver, then the second nop to "bl ". we need to > update ftrace_location() to recognise these two instructions as being > part of ftrace. To do this, we introduce FTRACE_IP_EXTENSION to let > ftrace_location search IP, IP + FTRACE_IP_EXTENSION range. > > Signed-off-by: Jisheng Zhang > Suggested-by: Steven Rostedt (VMware) > --- > include/linux/ftrace.h | 4 ++++ > kernel/trace/ftrace.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 1bd3a0356ae4..c1e1fbde8a04 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -20,6 +20,10 @@ > > #include > > +#ifndef FTRACE_IP_EXTENSION > +#define FTRACE_IP_EXTENSION 0 Inconsistent spacing between # and the value? [...] MBR, Sergei