From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] [RFC] ARM: modify pgd_t definition for TRANSPARENT_HUGEPAGE_PUD Date: Wed, 03 Feb 2016 21:36:38 +0100 Message-ID: <15001627.5KATBhJaXU@wuerfel> References: <1773775.QWf7OyDGPh@wuerfel> <20160203163946.GA20360@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.135]:55605 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcBCUh3 (ORCPT ); Wed, 3 Feb 2016 15:37:29 -0500 In-Reply-To: <20160203163946.GA20360@ravnborg.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arm-kernel@lists.infradead.org Cc: Sam Ravnborg , linux-arch@vger.kernel.org, Jan Kara , Dan Williams , linux-kernel@vger.kernel.org, "David S. Miller" , linux-mm@kvack.org, Russell King , Matthew Wilcox , Andrew Morton , Ross Zwisler , "Kirill A. Shutemov" On Wednesday 03 February 2016 17:39:46 Sam Ravnborg wrote: > On Wed, Feb 03, 2016 at 02:21:48PM +0100, Arnd Bergmann wrote: > > arch/alpha/include/asm/page.h > > arch/arc/include/asm/page.h > > arch/arm/include/asm/pgtable-3level-types.h > > arch/arm64/include/asm/pgtable-types.h > > arch/ia64/include/asm/page.h > > arch/parisc/include/asm/page.h > > arch/powerpc/include/asm/page.h > > arch/sparc/include/asm/page_32.h > > arch/sparc/include/asm/page_64.h > > For the sparc32 case we use the simpler variants. > According to the comment this is due to limitation in > the way we pass arguments in the sparc32 ABI. > But I have not tried to compare a kernel for sparc32 with > and without the use of structs. > > For sparc64 we use the stricter types (structs). > I did not check other architectures - but just wanted to > tell that the right choice may be architecture dependent. > I see. I was assuming that they all (wrongly) default to the simple definitions. It seems we have these categories: * both defined, but using strict: arch/alpha/include/asm/page.h:#define STRICT_MM_TYPECHECKS arch/sparc/include/asm/page_64.h:#define STRICT_MM_TYPECHECKS arch/ia64/include/asm/page.h:# define STRICT_MM_TYPECHECKS arch/parisc/include/asm/page.h:#define STRICT_MM_TYPECHECKS * both defined, but using non-strict: arch/arc/include/asm/page.h:#undef STRICT_MM_TYPECHECKS arch/arm/include/asm/pgtable-2level-types.h:#undef STRICT_MM_TYPECHECKS arch/arm/include/asm/pgtable-3level-types.h:#undef STRICT_MM_TYPECHECKS arch/arm64/include/asm/pgtable-types.h:#undef STRICT_MM_TYPECHECKS arch/sparc/include/asm/page_32.h:/* #define STRICT_MM_TYPECHECKS */ arch/unicore32/include/asm/page.h:#undef STRICT_MM_TYPECHECKS * Kconfig option: arch/powerpc/Kconfig.debug:config STRICT_MM_TYPECHECKS default n * only strict defined: everything else Arnd