linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Francis Deslauriers <francis.deslauriers@efficios.com>,
	mathieu.desnoyers@efficios.com, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Mikael Starvik <starvik@axis.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-cris-kernel@axis.com, linux-arch@vger.kernel.org
Subject: [PATCH -tip v9 0/5] kprobes related bugfix
Date: Thu,  3 Aug 2017 11:33:58 +0900	[thread overview]
Message-ID: <150172762859.27216.16741726568669538542.stgit@devbox> (raw)

Hi,

Here are the 9th version of the series to fix kprobes not
to optimize on the functions in irqentry text ([5/5]).
To check the irqentry text always, [4/5] makes irqentry
text section unconditional.

This involves some other cleanups on h8300, xtensa, and
cris ports, because those sources declare section 
start/end symbol as single characters, but generic
sections.h declares it as character arrays. So it leads
build errors if we apply [4/5].

Changes in v9
 - Add cris cleanup patch (3/5).

BTW, in this series I just give a minimum fix for
arch dependent code, since this is a series to fix
a bug in x86 optprobe. However, IMHO, we should
revisit these "local _stext/_etext references" and
replace it with just including asm/sections.h.
And also, I would like to expose is_kernel_text()
as a generic routine for arch dependent code
so that they can use it.

Thank you,

---

Masami Hiramatsu (5):
      h8300: mark _stext and _etext as char-arrays, not single char
      xtensa: mark _stext and _end as char-arrays, not single char
      cris: mark _stext and _end as char-arrays, not single char
      irq: Make irqentry text section unconditional
      [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code


 arch/arm/include/asm/traps.h         |    7 -------
 arch/arm64/include/asm/traps.h       |    7 -------
 arch/cris/arch-v32/mach-a3/arbiter.c |    4 ++--
 arch/cris/arch-v32/mach-fs/arbiter.c |    4 ++--
 arch/cris/kernel/traps.c             |    6 +++---
 arch/h8300/include/asm/traps.h       |    6 +++---
 arch/x86/entry/entry_64.S            |    9 ++-------
 arch/x86/kernel/kprobes/opt.c        |    9 ++++++---
 arch/x86/kernel/unwind_frame.c       |    2 --
 arch/xtensa/kernel/setup.c           |    6 +++---
 include/asm-generic/sections.h       |    4 ++++
 include/asm-generic/vmlinux.lds.h    |    8 --------
 include/linux/interrupt.h            |   14 +-------------
 13 files changed, 26 insertions(+), 60 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Francis Deslauriers <francis.deslauriers@efficios.com>,
	mathieu.desnoyers@efficios.com, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Mikael Starvik <starvik@axis.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-cris-kernel@axis.com, linux-arch@vger.kernel.org
Subject: [PATCH -tip v9 0/5] kprobes related bugfix
Date: Thu,  3 Aug 2017 11:33:58 +0900	[thread overview]
Message-ID: <150172762859.27216.16741726568669538542.stgit@devbox> (raw)
Message-ID: <20170803023358.5IGdiQZNKZBx5AqkiYEOnLbVvWSQVHFaznM3kI8HPeU@z> (raw)

Hi,

Here are the 9th version of the series to fix kprobes not
to optimize on the functions in irqentry text ([5/5]).
To check the irqentry text always, [4/5] makes irqentry
text section unconditional.

This involves some other cleanups on h8300, xtensa, and
cris ports, because those sources declare section 
start/end symbol as single characters, but generic
sections.h declares it as character arrays. So it leads
build errors if we apply [4/5].

Changes in v9
 - Add cris cleanup patch (3/5).

BTW, in this series I just give a minimum fix for
arch dependent code, since this is a series to fix
a bug in x86 optprobe. However, IMHO, we should
revisit these "local _stext/_etext references" and
replace it with just including asm/sections.h.
And also, I would like to expose is_kernel_text()
as a generic routine for arch dependent code
so that they can use it.

Thank you,

---

Masami Hiramatsu (5):
      h8300: mark _stext and _etext as char-arrays, not single char
      xtensa: mark _stext and _end as char-arrays, not single char
      cris: mark _stext and _end as char-arrays, not single char
      irq: Make irqentry text section unconditional
      [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code


 arch/arm/include/asm/traps.h         |    7 -------
 arch/arm64/include/asm/traps.h       |    7 -------
 arch/cris/arch-v32/mach-a3/arbiter.c |    4 ++--
 arch/cris/arch-v32/mach-fs/arbiter.c |    4 ++--
 arch/cris/kernel/traps.c             |    6 +++---
 arch/h8300/include/asm/traps.h       |    6 +++---
 arch/x86/entry/entry_64.S            |    9 ++-------
 arch/x86/kernel/kprobes/opt.c        |    9 ++++++---
 arch/x86/kernel/unwind_frame.c       |    2 --
 arch/xtensa/kernel/setup.c           |    6 +++---
 include/asm-generic/sections.h       |    4 ++++
 include/asm-generic/vmlinux.lds.h    |    8 --------
 include/linux/interrupt.h            |   14 +-------------
 13 files changed, 26 insertions(+), 60 deletions(-)

--
Masami Hiramatsu

             reply	other threads:[~2017-08-03  2:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  2:33 Masami Hiramatsu [this message]
2017-08-03  2:33 ` [PATCH -tip v9 0/5] kprobes related bugfix Masami Hiramatsu
2017-08-03  2:35 ` [PATCH -tip v9 1/5] h8300: mark _stext and _etext as char-arrays, not single char Masami Hiramatsu
2017-08-03  2:36 ` [PATCH -tip v9 2/5] xtensa: mark _stext and _end " Masami Hiramatsu
2017-08-03  2:37 ` [PATCH -tip v9 3/5] cris: " Masami Hiramatsu
2017-08-16 11:01   ` Masami Hiramatsu
2017-08-18 18:38     ` Jesper Nilsson
2017-08-18 18:38   ` Jesper Nilsson
2017-08-03  2:38 ` [PATCH -tip v9 4/5] irq: Make irqentry text section unconditional Masami Hiramatsu
2017-08-03  2:39 ` [PATCH -tip v9 5/5] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code Masami Hiramatsu
2017-08-03  2:39   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150172762859.27216.16741726568669538542.stgit@devbox \
    --to=mhiramat@kernel.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=chris@zankel.net \
    --cc=davem@davemloft.net \
    --cc=francis.deslauriers@efficios.com \
    --cc=hpa@zytor.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-cris-kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=starvik@axis.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).