From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH] bitfield: Use __ffs64(x) to fix missing __ffsdi2()
Date: Mon, 9 Oct 2017 10:40:49 +0200 [thread overview]
Message-ID: <1507538449-22775-1-git-send-email-geert+renesas@glider.be> (raw)
On most architectures[*], gcc turns __builtin_ffsll() into a call to
__ffsdi2(), which is not provided by any architecture, leading to
failures like:
rcar-gen3-cpg.c:(.text+0x289): undefined reference to `__ffsdi2'
To fix this, use __ffs64() instead, which is available on all
architectures.
[*] Known exceptions are some 64-bit architectures like amd64, arm64,
ia64, powerpc64, and tilegx.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 3e9b3112ec74f192 ("add basic register-field manipulation macros")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
include/linux/bitfield.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h
index 8b9d6fff002db113..0a827677372756fa 100644
--- a/include/linux/bitfield.h
+++ b/include/linux/bitfield.h
@@ -15,6 +15,7 @@
#ifndef _LINUX_BITFIELD_H
#define _LINUX_BITFIELD_H
+#include <linux/bitops.h>
#include <linux/bug.h>
/*
@@ -46,7 +47,7 @@
* reg |= FIELD_PREP(REG_FIELD_C, c);
*/
-#define __bf_shf(x) (__builtin_ffsll(x) - 1)
+#define __bf_shf(x) __ffs64(x)
#define __BF_FIELD_CHECK(_mask, _reg, _val, _pfx) \
({ \
--
2.7.4
next reply other threads:[~2017-10-09 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 8:40 Geert Uytterhoeven [this message]
2017-10-09 14:34 ` [PATCH] bitfield: Use __ffs64(x) to fix missing __ffsdi2() Jakub Kicinski
2017-10-09 14:34 ` Jakub Kicinski
2017-10-09 22:37 ` kbuild test robot
2017-10-09 22:37 ` kbuild test robot
2017-10-09 22:53 ` Jakub Kicinski
2017-10-10 7:03 ` Geert Uytterhoeven
2017-10-10 7:03 ` Geert Uytterhoeven
2017-10-10 15:06 ` Jakub Kicinski
2017-10-10 15:06 ` Jakub Kicinski
2017-10-09 22:57 ` kbuild test robot
2017-10-09 22:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507538449-22775-1-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).