linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
	"Richard Sandiford" <richard.sandiford@arm.com>,
	"Okamoto Takayuki" <tokamoto@jp.fujitsu.com>,
	kvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org,
	linux-arch@vger.kernel.org
Subject: [PATCH v3 10/28] arm64/sve: Low-level CPU setup
Date: Tue, 10 Oct 2017 19:38:27 +0100	[thread overview]
Message-ID: <1507660725-7986-11-git-send-email-Dave.Martin@arm.com> (raw)
In-Reply-To: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com>

To enable the kernel to use SVE, SVE traps from EL1 to EL2 must be
disabled.  To take maximum advantage of the hardware, the full
available vector length also needs to be enabled for EL1 by
programming ZCR_EL2.LEN.  (The kernel will program ZCR_EL1.LEN as
required, but this cannot override the limit set by ZCR_EL2.)

Traps from EL0 to EL1 are also left enabled by virtue of setting
the relevant CPACR bit at its default (RES0) value.

This patch makes the appropriate changes to the primary and
secondary CPU initialisation code.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Alex Bennée <alex.bennee@linaro.org>

---

Dropped Alex Bennée's Reviewed-by, since there is a non-trivial change
to the logic here.

Changes since v2
----------------

Requested by Catalin Marinas:

 * Removed the asm logic to enable SVE for EL1 from __cpu_setup, since
   the kernel doesn't need SVE so early.

   Instead, this logic is moved to C code called via cpufeatures in
   "arm64/sve: Probe SVE capabilities and usable vector lengths"
   and wired up for the arm64_cpu_capabilities enable() method in
   "arm64/sve: Detect SVE and activate runtime support".
---
 arch/arm64/kernel/head.S | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
index 0b243ec..bb6e3f2 100644
--- a/arch/arm64/kernel/head.S
+++ b/arch/arm64/kernel/head.S
@@ -517,8 +517,19 @@ CPU_LE(	movk	x0, #0x30d0, lsl #16	)	// Clear EE and E0E on LE systems
 	mov	x0, #0x33ff
 	msr	cptr_el2, x0			// Disable copro. traps to EL2
 
+	/* SVE register access */
+	mrs	x1, id_aa64pfr0_el1
+	ubfx	x1, x1, #ID_AA64PFR0_SVE_SHIFT, #4
+	cbz	x1, 7f
+
+	bic	x0, x0, #CPTR_EL2_TZ		// Also disable SVE traps
+	msr	cptr_el2, x0			// Disable copro. traps to EL2
+	isb
+	mov	x1, #ZCR_ELx_LEN_MASK		// SVE: Enable full vector
+	msr_s	SYS_ZCR_EL2, x1			// length for EL1.
+
 	/* Hypervisor stub */
-	adr_l	x0, __hyp_stub_vectors
+7:	adr_l	x0, __hyp_stub_vectors
 	msr	vbar_el2, x0
 
 	/* spsr */
-- 
2.1.4

  parent reply	other threads:[~2017-10-10 18:39 UTC|newest]

Thread overview: 155+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 18:38 [PATCH v3 00/28] ARM Scalable Vector Extension (SVE) Dave Martin
2017-10-10 18:38 ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 01/28] regset: Add support for dynamically sized regsets Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 14:14   ` Catalin Marinas
2017-10-11 14:45     ` Dave Martin
2017-10-11 14:45       ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 02/28] arm64: KVM: Hide unsupported AArch64 CPU features from guests Dave Martin
2017-10-11 14:14   ` Catalin Marinas
2017-10-11 16:21   ` Marc Zyngier
2017-10-11 16:21     ` Marc Zyngier
2017-10-17 13:51   ` Christoffer Dall
2017-10-17 14:08     ` Marc Zyngier
2017-10-18 13:20       ` Christoffer Dall
2017-10-18 13:20         ` Christoffer Dall
2017-10-18 14:45         ` Dave Martin
2017-10-18 19:19           ` Christoffer Dall
2017-10-10 18:38 ` [PATCH v3 03/28] arm64: efi: Add missing Kconfig dependency on KERNEL_MODE_NEON Dave Martin
2017-10-11 14:16   ` Catalin Marinas
2017-10-11 14:35     ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 04/28] arm64: Port deprecated instruction emulation to new sysctl interface Dave Martin
2017-10-11 14:17   ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 05/28] arm64: fpsimd: Simplify uses of {set, clear}_ti_thread_flag() Dave Martin
2017-10-10 18:38   ` [PATCH v3 05/28] arm64: fpsimd: Simplify uses of {set,clear}_ti_thread_flag() Dave Martin
2017-10-11 14:19   ` [PATCH v3 05/28] arm64: fpsimd: Simplify uses of {set, clear}_ti_thread_flag() Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 06/28] arm64/sve: System register and exception syndrome definitions Dave Martin
2017-10-11 14:20   ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 07/28] arm64/sve: Low-level SVE architectural state manipulation functions Dave Martin
2017-10-11 14:28   ` Catalin Marinas
2017-10-11 14:28     ` Catalin Marinas
2017-10-11 14:39     ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 08/28] arm64/sve: Kconfig update and conditional compilation support Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 14:29   ` Catalin Marinas
2017-10-11 14:29     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 09/28] arm64/sve: Signal frame and context structure definition Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 14:29   ` Catalin Marinas
2017-10-11 14:29     ` Catalin Marinas
2017-10-10 18:38 ` Dave Martin [this message]
2017-10-11 14:30   ` [PATCH v3 10/28] arm64/sve: Low-level CPU setup Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 11/28] arm64/sve: Core task context handling Dave Martin
2017-10-11 16:15   ` Catalin Marinas
2017-10-12 16:05     ` Dave Martin
2017-10-13 13:57       ` Catalin Marinas
2017-10-13 17:53         ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 12/28] arm64/sve: Support vector length resetting for new processes Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 16:16   ` Catalin Marinas
2017-10-11 16:16     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 13/28] arm64/sve: Signal handling support Dave Martin
2017-10-11 16:40   ` Catalin Marinas
2017-10-12 16:11     ` Dave Martin
2017-10-13 11:17       ` Catalin Marinas
2017-10-13 11:17         ` Catalin Marinas
2017-10-13 14:26         ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 14/28] arm64/sve: Backend logic for setting the vector length Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 16:43   ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 15/28] arm64: cpufeature: Move sys_caps_initialised declarations Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 16:50   ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 16/28] arm64/sve: Probe SVE capabilities and usable vector lengths Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 16:55   ` Catalin Marinas
2017-10-12 12:56   ` Suzuki K Poulose
2017-10-16 15:46     ` Dave Martin
2017-10-16 15:46       ` Dave Martin
2017-10-16 16:27       ` Suzuki K Poulose
2017-10-16 16:27         ` Suzuki K Poulose
2017-10-16 16:44         ` Dave Martin
2017-10-16 16:44           ` Dave Martin
2017-10-16 16:47           ` Suzuki K Poulose
2017-10-16 16:47             ` Suzuki K Poulose
2017-10-16 16:55             ` Dave Martin
2017-10-16 16:58               ` Suzuki K Poulose
2017-10-10 18:38 ` [PATCH v3 17/28] arm64/sve: Preserve SVE registers around kernel-mode NEON use Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-12 10:15   ` Catalin Marinas
2017-10-12 10:15     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 18/28] arm64/sve: Preserve SVE registers around EFI runtime service calls Dave Martin
2017-10-12 10:57   ` Catalin Marinas
2017-10-12 10:57     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 19/28] arm64/sve: ptrace and ELF coredump support Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-12 17:06   ` Catalin Marinas
2017-10-13 16:16     ` Dave Martin
2017-10-13 16:16       ` Dave Martin
2017-10-18 10:32       ` Catalin Marinas
2017-10-18 16:02         ` Dave Martin
2017-10-10 18:38 ` [PATCH v3 20/28] arm64/sve: Add prctl controls for userspace vector length management Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-12 17:11   ` Catalin Marinas
2017-10-12 17:11     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 21/28] arm64/sve: Add sysctl to set the default vector length for new processes Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-12 17:11   ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 22/28] arm64/sve: KVM: Prevent guests from using SVE Dave Martin
2017-10-11 16:28   ` Marc Zyngier
2017-10-12 11:04     ` Dave Martin
2017-10-12 11:28       ` Marc Zyngier
2017-10-13 14:15         ` Dave Martin
2017-10-13 14:21           ` Marc Zyngier
2017-10-13 16:47             ` Dave Martin
2017-10-12 17:13   ` Catalin Marinas
2017-10-17 11:50   ` Christoffer Dall
2017-10-17 11:50     ` Christoffer Dall
2017-10-17 14:31     ` Dave Martin
2017-10-17 14:31       ` Dave Martin
2017-10-18 13:23       ` Christoffer Dall
2017-10-18 13:23         ` Christoffer Dall
2017-10-18 15:00         ` Dave Martin
2017-10-18 15:00           ` Dave Martin
2017-10-18 19:22           ` Christoffer Dall
2017-10-18 19:22             ` Christoffer Dall
2017-10-10 18:38 ` [PATCH v3 23/28] arm64/sve: KVM: Treat guest SVE use as undefined instruction execution Dave Martin
2017-10-12 17:13   ` Catalin Marinas
2017-10-17 13:58   ` Christoffer Dall
2017-10-10 18:38 ` [PATCH v3 24/28] arm64/sve: KVM: Hide SVE from CPU features exposed to guests Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11 16:31   ` Marc Zyngier
2017-10-12 17:13   ` Catalin Marinas
2017-10-17 13:58   ` Christoffer Dall
2017-10-17 13:58     ` Christoffer Dall
2017-10-17 14:07     ` Dave Martin
2017-10-17 14:29       ` Marc Zyngier
2017-10-17 14:29         ` Marc Zyngier
2017-10-17 15:47         ` Dave Martin
2017-10-18 13:21           ` Christoffer Dall
2017-10-18 13:21             ` Christoffer Dall
2017-10-18 15:01             ` Dave Martin
2017-10-18 15:01               ` Dave Martin
2017-10-18 16:49               ` Christoffer Dall
2017-10-18 16:49                 ` Christoffer Dall
2017-10-10 18:38 ` [PATCH v3 25/28] arm64/sve: Detect SVE and activate runtime support Dave Martin
2017-10-11 17:11   ` Suzuki K Poulose
2017-10-12 17:14   ` Catalin Marinas
2017-10-12 17:14     ` Catalin Marinas
2017-10-10 18:38 ` [PATCH v3 26/28] arm64/sve: Add documentation Dave Martin
2017-10-10 18:38   ` Dave Martin
2017-10-11  9:50   ` Szabolcs Nagy
     [not found]     ` <59DDE958.4080605-5wv7dgnIgG8@public.gmane.org>
2017-10-11 11:08       ` Dave Martin
2017-10-11 11:08         ` Dave Martin
     [not found]         ` <20171011110811.GB19485-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2017-10-11 11:30           ` Szabolcs Nagy
2017-10-11 11:30             ` Szabolcs Nagy
2017-10-13 14:24   ` Catalin Marinas
2017-10-13 17:17     ` Dave Martin
     [not found]       ` <20171013171758.GO19485-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2017-10-18  9:32         ` Catalin Marinas
2017-10-18  9:32           ` Catalin Marinas
     [not found]     ` <20171013142421.j32jzisukewxtosx-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-10-13 17:35       ` Dave Martin
2017-10-13 17:35         ` Dave Martin
2017-10-10 18:38 ` [RFC PATCH v3 27/28] arm64: signal: Report signal frame size to userspace via auxv Dave Martin
2017-10-11 10:19   ` Szabolcs Nagy
2017-10-11 13:14     ` Dave P Martin
2017-10-10 18:38 ` [RFC PATCH v3 28/28] arm64/sve: signal: Include SVE when computing AT_MINSIGSTKSZ Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507660725-7986-11-git-send-email-Dave.Martin@arm.com \
    --to=dave.martin@arm.com \
    --cc=alex.bennee@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=richard.sandiford@arm.com \
    --cc=szabolcs.nagy@arm.com \
    --cc=tokamoto@jp.fujitsu.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).