From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: [PATCH 1/3] lkdtm: Include WARN format string Date: Tue, 7 Nov 2017 16:27:47 -0800 Message-ID: <1510100869-73751-2-git-send-email-keescook@chromium.org> References: <1510100869-73751-1-git-send-email-keescook@chromium.org> Return-path: In-Reply-To: <1510100869-73751-1-git-send-email-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Kees Cook , Peter Zijlstra , Josh Poimboeuf , Joe Perches , Fengguang Wu , Arnd Bergmann , linux-am33-list@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org In order to test the ordering of WARN format strings, actually include one in LKDTM. Signed-off-by: Kees Cook --- drivers/misc/lkdtm_bugs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c index 9e0b4f959987..8523f7dbac99 100644 --- a/drivers/misc/lkdtm_bugs.c +++ b/drivers/misc/lkdtm_bugs.c @@ -62,9 +62,11 @@ void lkdtm_BUG(void) BUG(); } +static int warn_counter; + void lkdtm_WARNING(void) { - WARN_ON(1); + WARN(1, "Warning message trigger count: %d\n", warn_counter++); } void lkdtm_EXCEPTION(void) -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:44320 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757747AbdKHA17 (ORCPT ); Tue, 7 Nov 2017 19:27:59 -0500 Received: by mail-pg0-f68.google.com with SMTP id j3so768775pga.1 for ; Tue, 07 Nov 2017 16:27:59 -0800 (PST) From: Kees Cook Subject: [PATCH 1/3] lkdtm: Include WARN format string Date: Tue, 7 Nov 2017 16:27:47 -0800 Message-ID: <1510100869-73751-2-git-send-email-keescook@chromium.org> In-Reply-To: <1510100869-73751-1-git-send-email-keescook@chromium.org> References: <1510100869-73751-1-git-send-email-keescook@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Kees Cook , Peter Zijlstra , Josh Poimboeuf , Joe Perches , Fengguang Wu , Arnd Bergmann , linux-am33-list@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20171108002747.Q0PnoE7-l7Yfr-ZSST26u9Gc4FOwwjm9HKwcyOQ7_g4@z> In order to test the ordering of WARN format strings, actually include one in LKDTM. Signed-off-by: Kees Cook --- drivers/misc/lkdtm_bugs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c index 9e0b4f959987..8523f7dbac99 100644 --- a/drivers/misc/lkdtm_bugs.c +++ b/drivers/misc/lkdtm_bugs.c @@ -62,9 +62,11 @@ void lkdtm_BUG(void) BUG(); } +static int warn_counter; + void lkdtm_WARNING(void) { - WARN_ON(1); + WARN(1, "Warning message trigger count: %d\n", warn_counter++); } void lkdtm_EXCEPTION(void) -- 2.7.4