Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Christoph Hellwig
2005-12-13T10:19:38Z

On Tue, Dec 13, 2005 at 05:11:41AM -0500, Jakub Jelinek wrote:
> On Tue, Dec 13, 2005 at 09:04:29AM +0000, Christoph Hellwig wrote:
> > >
> > > Remove -Wdeclaration-after-statement
> > >
> > > Now that gcc 2.95 is not supported anymore it's ok to use C99
> > > style mixed declarations everywhere.
> >
> > Nack. This code style is pure obsfucation and we should disallow it forever.
>
> Why? It greatly increases readability when variable declarations can be
> moved close to their actual uses. glibc changed a lot of its codebase
> this way and from my experience it really helps.

mentioning glibc and readability in the same sentence disqualies your here,
sorry ;-)

But serious, having to look all over the source instead of just a block
beginning decreases code readability a lot. And if you have to scroll more
than a page to the block beginning on a 80x24 terminal means the code needs
a refactoring anyway.