From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures) Date: Thu, 15 Mar 2018 10:13:42 -0700 Message-ID: <1521134022.22221.38.camel@perches.com> References: <20180314143529.1456168-1-arnd@arndb.de> <2929.1521106970@warthog.procyon.org.uk> <1521133006.22221.35.camel@perches.com> <20180315170830.GA17574@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180315170830.GA17574@bombadil.infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matthew Wilcox Cc: Linux-Arch , linux-block@vger.kernel.org, Linux Fbdev development list , Linux Watchdog Mailing List , Arnd Bergmann , linux-doc@vger.kernel.org, netdev , USB list , linux-wireless , Linux Kernel Mailing List , Linux PWM List , linux-spi , David Howells , linux-ide@vger.kernel.org, Geert Uytterhoeven , DRI Development , linux-input@vger.kernel.org, Linux FS Devel , Linux MM , linux-rtc@vger.kernel.org List-Id: linux-arch.vger.kernel.org T24gVGh1LCAyMDE4LTAzLTE1IGF0IDEwOjA4IC0wNzAwLCBNYXR0aGV3IFdpbGNveCB3cm90ZToK PiBPbiBUaHUsIE1hciAxNSwgMjAxOCBhdCAwOTo1Njo0NkFNIC0wNzAwLCBKb2UgUGVyY2hlcyB3 cm90ZToKPiA+IEkgaGF2ZSBhIHBhdGNoc2V0IHRoYXQgY3JlYXRlcyBhIHZzcHJpbnRmIGV4dGVu c2lvbiBmb3IKPiA+IHByaW50X3ZtYV9hZGRyIGFuZCByZW1vdmVzIGFsbCB0aGUgdXNlcyBzaW1p bGFyIHRvIHRoZQo+ID4gcHJpbnRfc3ltYm9sKCkgcmVtb3ZhbC4KPiA+IAo+ID4gVGhpcyBub3cg YXZvaWRzIGFueSBwb3NzaWJsZSBwcmludGsgaW50ZXJsZWF2aW5nLgo+ID4gCj4gPiBVbmZvcnR1 bmF0ZWx5LCB3aXRob3V0IHNvbWUgI2lmZGVmIGluIHZzcHJpbnRmLCB3aGljaAo+ID4gSSB3b3Vs ZCBsaWtlIHRvIGF2b2lkLCBpdCBpbmNyZWFzZXMgdGhlIG5vbW11IGtlcm5lbAo+ID4gc2l6ZSBi eSB+NTAwIGJ5dGVzLgo+ID4gCj4gPiBBbnlvbmUgdGhpbmsgdGhpcyBpcyBhY2NlcHRhYmxlPwpb XQo+IFRoaXMgZG9lc24ndCBmZWVsIGxpa2UgYSBodWdlIHdpbiBzaW5jZSBpdCdzIG9ubHkgY2Fs bGVkIH5vbmNlIHBlcgo+IGFyY2hpdGVjdHVyZS4gIEknZCBiZSBtb3JlIGV4Y2l0ZWQgaWYgaXQg bWFkZSB0aGUgcHJpbnRpbmcgb2YgdGhlIHdob2xlCj4gdGhpbmcgc3RhbmRhcmRpc2VkOyBlZyB3 ZSBoYXZlIGEgcHJpbnRfZmF1bHQoKSBmdW5jdGlvbiBpbiBtbS9tZW1vcnkuYwo+IHdoaWNoIHRh a2VzIGEgc3VpdGFibGUgc2V0IG9mIGFyZ3VtZW50cy4KClN1cmUgYnV0IHBlcmhhcHMgdGhhdCdz IG5vdCBmZWFzaWJsZSBhcyB0aGUgc3Vycm91bmRpbmcgb3V0cHV0CmlzIHBlci1hcmNoIHNwZWNp ZmljLgoKV2hhdCBjb3VsZCBiZSBhIHN0YW5kYXJkaXplZCBmYXVsdCBtZXNzYWdlIGhlcmU/Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0102.hostedemail.com ([216.40.44.102]:57754 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750987AbeCORNt (ORCPT ); Thu, 15 Mar 2018 13:13:49 -0400 Message-ID: <1521134022.22221.38.camel@perches.com> Subject: Re: rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures) From: Joe Perches Date: Thu, 15 Mar 2018 10:13:42 -0700 In-Reply-To: <20180315170830.GA17574@bombadil.infradead.org> References: <20180314143529.1456168-1-arnd@arndb.de> <2929.1521106970@warthog.procyon.org.uk> <1521133006.22221.35.camel@perches.com> <20180315170830.GA17574@bombadil.infradead.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matthew Wilcox Cc: Geert Uytterhoeven , David Howells , Arnd Bergmann , Linux-Arch , Linux Kernel Mailing List , linux-doc@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-input@vger.kernel.org, netdev , linux-wireless , Linux PWM List , linux-rtc@vger.kernel.org, linux-spi , USB list , DRI Development , Linux Fbdev development list , Linux Watchdog Mailing List , Linux FS Devel , Linux MM Message-ID: <20180315171342.qY-Ra0nlpQXMvxSQXavzZlnOeRZTSlhKy5SWLaDEGg4@z> On Thu, 2018-03-15 at 10:08 -0700, Matthew Wilcox wrote: > On Thu, Mar 15, 2018 at 09:56:46AM -0700, Joe Perches wrote: > > I have a patchset that creates a vsprintf extension for > > print_vma_addr and removes all the uses similar to the > > print_symbol() removal. > > > > This now avoids any possible printk interleaving. > > > > Unfortunately, without some #ifdef in vsprintf, which > > I would like to avoid, it increases the nommu kernel > > size by ~500 bytes. > > > > Anyone think this is acceptable? [] > This doesn't feel like a huge win since it's only called ~once per > architecture. I'd be more excited if it made the printing of the whole > thing standardised; eg we have a print_fault() function in mm/memory.c > which takes a suitable set of arguments. Sure but perhaps that's not feasible as the surrounding output is per-arch specific. What could be a standardized fault message here?