Re: [PATCH v4 1/3] ioremap: Update pgtable free interfaces with addr

Kani, Toshi
2018-03-20T22:58:18Z

On Tue, 2018-03-20 at 17:15 +0530, Chintan Pandya wrote:
> This patch ("mm/vmalloc: Add interfaces to free unmapped
> page table") adds following 2 interfaces to free the page
> table in case we implement huge mapping.
>
> pud_free_pmd_page() and pmd_free_pte_page()
>
> Some architectures (like arm64) needs to do proper TLB
> maintanance after updating pagetable entry even in map.
> Why ? Read this,
> https://patchwork.kernel.org/patch/10134581/
>
> Pass 'addr' in these interfaces so that proper TLB ops
> can be performed.
>
> Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>

Thanks for the update. The change looks good.

Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

-Toshi