From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Naveen N. Rao" Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code Date: Thu, 07 Jun 2018 22:07:26 +0530 Message-ID: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Masami Hiramatsu Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner List-Id: linux-arch.vger.kernel.org Masami Hiramatsu wrote: > On Thu, 07 Jun 2018 17:07:00 +0530 > "Naveen N. Rao" wrote: > >> Masami Hiramatsu wrote: >> > Don't call the ->break_handler() from the arm kprobes code, >> ^^^ powerpc >> >> > because it was only used by jprobes which got removed. >> > >> > This also makes skip_singlestep() a static function since >> > only ftrace-kprobe.c is using this function. >> > >> > Signed-off-by: Masami Hiramatsu >> > Cc: Benjamin Herrenschmidt >> > Cc: Paul Mackerras >> > Cc: Michael Ellerman >> > Cc: "Naveen N. Rao" >> > Cc: linuxppc-dev@lists.ozlabs.org >> > --- >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- >> > 3 files changed, 14 insertions(+), 43 deletions(-) >> >> With 2 small comments... > > 2 ? or 1 ? Two, with one in the commit log above :) - Naveen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38516 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932843AbeFGQhh (ORCPT ); Thu, 7 Jun 2018 12:37:37 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w57GYVgw089378 for ; Thu, 7 Jun 2018 12:37:36 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jf85a0t3b-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Jun 2018 12:37:36 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jun 2018 17:37:34 +0100 Date: Thu, 07 Jun 2018 22:07:26 +0530 From: "Naveen N. Rao" Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> In-Reply-To: <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Message-ID: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner Message-ID: <20180607163726.uS3OsKuEBuP1jVxYeCZL3xvkVJBEhBFO_F0Q4LuXHrY@z> Masami Hiramatsu wrote: > On Thu, 07 Jun 2018 17:07:00 +0530 > "Naveen N. Rao" wrote: > >> Masami Hiramatsu wrote: >> > Don't call the ->break_handler() from the arm kprobes code, >> ^^^ powerpc >> >> > because it was only used by jprobes which got removed. >> > >> > This also makes skip_singlestep() a static function since >> > only ftrace-kprobe.c is using this function. >> > >> > Signed-off-by: Masami Hiramatsu >> > Cc: Benjamin Herrenschmidt >> > Cc: Paul Mackerras >> > Cc: Michael Ellerman >> > Cc: "Naveen N. Rao" >> > Cc: linuxppc-dev@lists.ozlabs.org >> > --- >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- >> > 3 files changed, 14 insertions(+), 43 deletions(-) >> >> With 2 small comments... > > 2 ? or 1 ? Two, with one in the commit log above :) - Naveen