From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [PATCH 02/10] x86/cet: Introduce WRUSS instruction Date: Thu, 07 Jun 2018 13:31:01 -0700 Message-ID: <1528403461.5265.36.camel@2b52.sc.intel.com> References: <20180607143807.3611-1-yu-cheng.yu@intel.com> <20180607143807.3611-3-yu-cheng.yu@intel.com> <20180607184142.GJ12217@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180607184142.GJ12217@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: Andy Lutomirski , LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H. J. Lu" , "Shanbhogue, Vedvyas" , "Ravi V. Shankar" , Dave Hansen , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , mike.kravetz@oracle.com List-Id: linux-arch.vger.kernel.org On Thu, 2018-06-07 at 20:41 +0200, Peter Zijlstra wrote: > On Thu, Jun 07, 2018 at 09:40:02AM -0700, Andy Lutomirski wrote: > > Peterz, isn't there some fancy better way we're supposed to handle the > > error return these days? > > Don't think so. I played with a few things but that never really went > anywhere. > > Also, both asm things look suspicously similar, it might make sense to > share. Also, maybe do the instruction .byte sequence in a #define INSN > or something. I will fix that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:37328 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbeFGUeN (ORCPT ); Thu, 7 Jun 2018 16:34:13 -0400 Message-ID: <1528403461.5265.36.camel@2b52.sc.intel.com> Subject: Re: [PATCH 02/10] x86/cet: Introduce WRUSS instruction From: Yu-cheng Yu Date: Thu, 07 Jun 2018 13:31:01 -0700 In-Reply-To: <20180607184142.GJ12217@hirez.programming.kicks-ass.net> References: <20180607143807.3611-1-yu-cheng.yu@intel.com> <20180607143807.3611-3-yu-cheng.yu@intel.com> <20180607184142.GJ12217@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Andy Lutomirski , LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H. J. Lu" , "Shanbhogue, Vedvyas" , "Ravi V. Shankar" , Dave Hansen , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , mike.kravetz@oracle.com Message-ID: <20180607203101.aS5h-lxCtjQBkMLfVczYV_L6vw5zwdWvaag86g9-R_M@z> On Thu, 2018-06-07 at 20:41 +0200, Peter Zijlstra wrote: > On Thu, Jun 07, 2018 at 09:40:02AM -0700, Andy Lutomirski wrote: > > Peterz, isn't there some fancy better way we're supposed to handle the > > error return these days? > > Don't think so. I played with a few things but that never really went > anywhere. > > Also, both asm things look suspicously similar, it might make sense to > share. Also, maybe do the instruction .byte sequence in a #define INSN > or something. I will fix that.