From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Date: Fri, 29 Apr 2016 19:30:19 +0200 Message-ID: <1554541.oDP7Ro5zB2@wuerfel> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-25-git-send-email-ynorov@caviumnetworks.com> <20160429160154.GC30316@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20160429160154.GC30316@e104818-lin.cambridge.arm.com> Sender: linux-doc-owner@vger.kernel.org To: Catalin Marinas Cc: Yury Norov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, Philipp Tomsich , joseph@codesourcery.com, christoph.muellner@theobroma-systems.com List-Id: linux-arch.vger.kernel.org On Friday 29 April 2016 17:01:55 Catalin Marinas wrote: > On Wed, Apr 06, 2016 at 01:08:46AM +0300, Yury Norov wrote: > > ILP32 VDSO exports next symbols: > > __kernel_rt_sigreturn; > > __kernel_gettimeofday; > > __kernel_clock_gettime; > > __kernel_clock_getres; > > [...] > > > +$(obj)/gettimeofday-ilp32.o: $(src)/../vdso/gettimeofday.S > > + $(call if_changed_dep,vdso-ilp32as) > > Are struct timeval and timespec the same between ILP32 and LP64? For > example, __kernel_gettimeofday() assumes TVAL_TV_SEC offset defined in > asm-offsets.c based on the LP64 timeval. No, ilp32 uses the generic 32-bit data structures, which have a 32-bit time_t. I guess that means it can work for little-endian but not big-endian, right? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.24]:56250 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbcD2RbQ (ORCPT ); Fri, 29 Apr 2016 13:31:16 -0400 From: Arnd Bergmann Subject: Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Date: Fri, 29 Apr 2016 19:30:19 +0200 Message-ID: <1554541.oDP7Ro5zB2@wuerfel> In-Reply-To: <20160429160154.GC30316@e104818-lin.cambridge.arm.com> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-25-git-send-email-ynorov@caviumnetworks.com> <20160429160154.GC30316@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: Yury Norov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, Philipp Tomsich , joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Message-ID: <20160429173019.Rt3clmV4F-cXcn-I_PhsXozijpqwLeKyOEfXWeowZeg@z> On Friday 29 April 2016 17:01:55 Catalin Marinas wrote: > On Wed, Apr 06, 2016 at 01:08:46AM +0300, Yury Norov wrote: > > ILP32 VDSO exports next symbols: > > __kernel_rt_sigreturn; > > __kernel_gettimeofday; > > __kernel_clock_gettime; > > __kernel_clock_getres; > > [...] > > > +$(obj)/gettimeofday-ilp32.o: $(src)/../vdso/gettimeofday.S > > + $(call if_changed_dep,vdso-ilp32as) > > Are struct timeval and timespec the same between ILP32 and LP64? For > example, __kernel_gettimeofday() assumes TVAL_TV_SEC offset defined in > asm-offsets.c based on the LP64 timeval. No, ilp32 uses the generic 32-bit data structures, which have a 32-bit time_t. I guess that means it can work for little-endian but not big-endian, right? Arnd