From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: [PATCH 00/15] introduce generic pte_{alloc,free}_one[_kernel] Date: Thu, 2 May 2019 18:28:27 +0300 Message-ID: <1556810922-20248-1-git-send-email-rppt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org To: Andrew Morton Cc: Michal Hocko , Catalin Marinas , Palmer Dabbelt , linux-mips@vger.kernel.org, Guo Ren , linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, Michael Ellerman , Helge Deller , x86@kernel.org, Russell King , Matthew Wilcox , Mike Rapoport , Geert Uytterhoeven , Matt Turner , Sam Creasey , Arnd Bergmann , linux-um@lists.infradead.org, Richard Weinberger , linux-m68k@lists.linux-m68k.org, Greentime Hu , nios2-dev@lists.rocketboards.org, Guan Xuetao , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-kernel@vger.ke List-Id: linux-arch.vger.kernel.org Hi, I've tried to trim down the recipients list, but it's still quite long, so sorry for the spam. Many architectures have similar, if not identical implementation of pte_alloc_one_kernel(), pte_alloc_one(), pte_free_kernel() and pte_free(). A while ago Anshuman suggested to introduce a common definition of GFP_PGTABLE and during the discussion it was suggested to rather consolidate the allocators. These patches introduce generic version of PTE allocation and free and enable their use on several architectures. The conversion introduces some changes for some of the architectures. Here's the executive summary and the details are described at each patch. * Most architectures do not set __GFP_ACCOUNT for the user page tables. Switch to the generic functions is "spreading that goodness to all other architectures" * arm, arm64 and unicore32 used to check if the pte is not NULL before freeing its memory in pte_free_kernel(). It's dropped during the conversion as it seems superfluous. * x86 used to BUG_ON() is pte was not page aligned duirng pte_free_kernel(), the generic version simply frees the memory without any checks. This set only performs the straightforward conversion, the architectures with different logic in pte_alloc_one() and pte_alloc_one_kernel() are not touched, as well as architectures that have custom page table allocators. [1] https://lore.kernel.org/lkml/1547619692-7946-1-git-send-email-anshuman.khandual@arm.com asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] Mike Rapoport (15): asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] alpha: switch to generic version of pte allocation arm: switch to generic version of pte allocation arm64: switch to generic version of pte allocation csky: switch to generic version of pte allocation hexagon: switch to generic version of pte allocation m68k: sun3: switch to generic version of pte allocation mips: switch to generic version of pte allocation nds32: switch to generic version of pte allocation nios2: switch to generic version of pte allocation parisc: switch to generic version of pte allocation powerpc/nohash/64: switch to generic version of pte allocation riscv: switch to generic version of pte allocation um: switch to generic version of pte allocation unicore32: switch to generic version of pte allocation arch/alpha/include/asm/pgalloc.h | 40 +--------- arch/arm/include/asm/pgalloc.h | 41 ++++------ arch/arm/mm/mmu.c | 2 +- arch/arm64/include/asm/pgalloc.h | 43 +---------- arch/arm64/mm/mmu.c | 2 +- arch/arm64/mm/pgd.c | 4 +- arch/csky/include/asm/pgalloc.h | 30 +------- arch/hexagon/include/asm/pgalloc.h | 34 +-------- arch/m68k/include/asm/sun3_pgalloc.h | 41 +--------- arch/mips/include/asm/pgalloc.h | 33 +-------- arch/nds32/include/asm/pgalloc.h | 31 +------- arch/nios2/include/asm/pgalloc.h | 37 +-------- arch/parisc/include/asm/pgalloc.h | 33 +-------- arch/powerpc/include/asm/nohash/64/pgalloc.h | 35 +-------- arch/riscv/include/asm/pgalloc.h | 29 +------- arch/um/include/asm/pgalloc.h | 16 +--- arch/um/kernel/mem.c | 22 ------ arch/unicore32/include/asm/pgalloc.h | 36 ++------- arch/x86/include/asm/pgalloc.h | 19 +---- arch/x86/mm/pgtable.c | 33 +++------ include/asm-generic/pgalloc.h | 107 ++++++++++++++++++++++++++- virt/kvm/arm/mmu.c | 2 +- 22 files changed, 171 insertions(+), 499 deletions(-) -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54732 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728332AbfEBP3D (ORCPT ); Thu, 2 May 2019 11:29:03 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x42FSMjE139062 for ; Thu, 2 May 2019 11:29:01 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s81d7djbm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 02 May 2019 11:29:00 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 May 2019 16:28:58 +0100 From: Mike Rapoport Subject: [PATCH 00/15] introduce generic pte_{alloc,free}_one[_kernel] Date: Thu, 2 May 2019 18:28:27 +0300 Message-ID: <1556810922-20248-1-git-send-email-rppt@linux.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Arnd Bergmann , Catalin Marinas , Geert Uytterhoeven , Greentime Hu , Guan Xuetao , Guo Ren , Helge Deller , Ley Foon Tan , Matthew Wilcox , Matt Turner , Michael Ellerman , Michal Hocko , Palmer Dabbelt , Paul Burton , Richard Kuo , Richard Weinberger , Russell King , Sam Creasey , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-um@lists.infradead.org, nios2-dev@lists.rocketboards.org, Mike Rapoport Message-ID: <20190502152827.upHiYEvpCdQskJPtNvZCwX5P0aCDKk35stTEjUgYOoA@z> Hi, I've tried to trim down the recipients list, but it's still quite long, so sorry for the spam. Many architectures have similar, if not identical implementation of pte_alloc_one_kernel(), pte_alloc_one(), pte_free_kernel() and pte_free(). A while ago Anshuman suggested to introduce a common definition of GFP_PGTABLE and during the discussion it was suggested to rather consolidate the allocators. These patches introduce generic version of PTE allocation and free and enable their use on several architectures. The conversion introduces some changes for some of the architectures. Here's the executive summary and the details are described at each patch. * Most architectures do not set __GFP_ACCOUNT for the user page tables. Switch to the generic functions is "spreading that goodness to all other architectures" * arm, arm64 and unicore32 used to check if the pte is not NULL before freeing its memory in pte_free_kernel(). It's dropped during the conversion as it seems superfluous. * x86 used to BUG_ON() is pte was not page aligned duirng pte_free_kernel(), the generic version simply frees the memory without any checks. This set only performs the straightforward conversion, the architectures with different logic in pte_alloc_one() and pte_alloc_one_kernel() are not touched, as well as architectures that have custom page table allocators. [1] https://lore.kernel.org/lkml/1547619692-7946-1-git-send-email-anshuman.khandual@arm.com asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] Mike Rapoport (15): asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] alpha: switch to generic version of pte allocation arm: switch to generic version of pte allocation arm64: switch to generic version of pte allocation csky: switch to generic version of pte allocation hexagon: switch to generic version of pte allocation m68k: sun3: switch to generic version of pte allocation mips: switch to generic version of pte allocation nds32: switch to generic version of pte allocation nios2: switch to generic version of pte allocation parisc: switch to generic version of pte allocation powerpc/nohash/64: switch to generic version of pte allocation riscv: switch to generic version of pte allocation um: switch to generic version of pte allocation unicore32: switch to generic version of pte allocation arch/alpha/include/asm/pgalloc.h | 40 +--------- arch/arm/include/asm/pgalloc.h | 41 ++++------ arch/arm/mm/mmu.c | 2 +- arch/arm64/include/asm/pgalloc.h | 43 +---------- arch/arm64/mm/mmu.c | 2 +- arch/arm64/mm/pgd.c | 4 +- arch/csky/include/asm/pgalloc.h | 30 +------- arch/hexagon/include/asm/pgalloc.h | 34 +-------- arch/m68k/include/asm/sun3_pgalloc.h | 41 +--------- arch/mips/include/asm/pgalloc.h | 33 +-------- arch/nds32/include/asm/pgalloc.h | 31 +------- arch/nios2/include/asm/pgalloc.h | 37 +-------- arch/parisc/include/asm/pgalloc.h | 33 +-------- arch/powerpc/include/asm/nohash/64/pgalloc.h | 35 +-------- arch/riscv/include/asm/pgalloc.h | 29 +------- arch/um/include/asm/pgalloc.h | 16 +--- arch/um/kernel/mem.c | 22 ------ arch/unicore32/include/asm/pgalloc.h | 36 ++------- arch/x86/include/asm/pgalloc.h | 19 +---- arch/x86/mm/pgtable.c | 33 +++------ include/asm-generic/pgalloc.h | 107 ++++++++++++++++++++++++++- virt/kvm/arm/mmu.c | 2 +- 22 files changed, 171 insertions(+), 499 deletions(-) -- 2.7.4