* [PATCH] mm/hugetlb: ensure signedness of large numbers
@ 2019-12-28 10:33 isidentical
2019-12-28 10:33 ` isidentical
2019-12-29 1:31 ` James Bottomley
0 siblings, 2 replies; 4+ messages in thread
From: isidentical @ 2019-12-28 10:33 UTC (permalink / raw)
Cc: isidentical, Arnd Bergmann, linux-arch, linux-kernel
This change introduces a sanitity helper for
numbers that are larger than 2^5.
Signed-off-by: isidentical <batuhanosmantaskaya@gmail.com>
---
include/uapi/asm-generic/hugetlb_encode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
index b0f8e87235bd..42c06c62ae17 100644
--- a/include/uapi/asm-generic/hugetlb_encode.h
+++ b/include/uapi/asm-generic/hugetlb_encode.h
@@ -31,6 +31,6 @@
#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
-#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_16GB (UINT32_C(34) << HUGETLB_FLAG_ENCODE_SHIFT)
#endif /* _ASM_GENERIC_HUGETLB_ENCODE_H_ */
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mm/hugetlb: ensure signedness of large numbers
2019-12-28 10:33 [PATCH] mm/hugetlb: ensure signedness of large numbers isidentical
@ 2019-12-28 10:33 ` isidentical
2019-12-29 1:31 ` James Bottomley
1 sibling, 0 replies; 4+ messages in thread
From: isidentical @ 2019-12-28 10:33 UTC (permalink / raw)
Cc: isidentical, Arnd Bergmann, linux-arch, linux-kernel
This change introduces a sanitity helper for
numbers that are larger than 2^5.
Signed-off-by: isidentical <batuhanosmantaskaya@gmail.com>
---
include/uapi/asm-generic/hugetlb_encode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
index b0f8e87235bd..42c06c62ae17 100644
--- a/include/uapi/asm-generic/hugetlb_encode.h
+++ b/include/uapi/asm-generic/hugetlb_encode.h
@@ -31,6 +31,6 @@
#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
-#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_16GB (UINT32_C(34) << HUGETLB_FLAG_ENCODE_SHIFT)
#endif /* _ASM_GENERIC_HUGETLB_ENCODE_H_ */
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/hugetlb: ensure signedness of large numbers
2019-12-28 10:33 [PATCH] mm/hugetlb: ensure signedness of large numbers isidentical
2019-12-28 10:33 ` isidentical
@ 2019-12-29 1:31 ` James Bottomley
2019-12-29 1:31 ` James Bottomley
1 sibling, 1 reply; 4+ messages in thread
From: James Bottomley @ 2019-12-29 1:31 UTC (permalink / raw)
To: isidentical; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sat, 2019-12-28 at 13:33 +0300, isidentical wrote:
> This change introduces a sanitity helper for
> numbers that are larger than 2^5.
What's the rationale for this ... i.e. what problem are you trying to
solve? left to its own devices, gcc will assume int size for all
literals, so 34<<26 doesn't appear to have a problem, except that it
will be sign extended as a negative number into a 64 bit variable.
However, it's designed use is for an int flags in mmap, so its current
definition seems to be fine.
> Signed-off-by: isidentical <batuhanosmantaskaya@gmail.com>
> ---
> include/uapi/asm-generic/hugetlb_encode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h
> b/include/uapi/asm-generic/hugetlb_encode.h
> index b0f8e87235bd..42c06c62ae17 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -31,6 +31,6 @@
> #define HUGETLB_FLAG_ENCODE_512MB (29 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_1GB (30 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_2GB (31 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> -#define HUGETLB_FLAG_ENCODE_16GB (34 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_16GB (UINT32_C(34) <<
> HUGETLB_FLAG_ENCODE_SHIFT)
And if there is a literal problem here, it can't be solved like this:
UINT32_C is a Cism which has no analogue in the kernel because we don't
pull in the /usr/include headers where it is defined. Usually in the
kernel we solve this by making the literal type explicit, like 34U, but
as I said above, I don't see a problem that this would solve.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/hugetlb: ensure signedness of large numbers
2019-12-29 1:31 ` James Bottomley
@ 2019-12-29 1:31 ` James Bottomley
0 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2019-12-29 1:31 UTC (permalink / raw)
To: isidentical; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sat, 2019-12-28 at 13:33 +0300, isidentical wrote:
> This change introduces a sanitity helper for
> numbers that are larger than 2^5.
What's the rationale for this ... i.e. what problem are you trying to
solve? left to its own devices, gcc will assume int size for all
literals, so 34<<26 doesn't appear to have a problem, except that it
will be sign extended as a negative number into a 64 bit variable.
However, it's designed use is for an int flags in mmap, so its current
definition seems to be fine.
> Signed-off-by: isidentical <batuhanosmantaskaya@gmail.com>
> ---
> include/uapi/asm-generic/hugetlb_encode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h
> b/include/uapi/asm-generic/hugetlb_encode.h
> index b0f8e87235bd..42c06c62ae17 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -31,6 +31,6 @@
> #define HUGETLB_FLAG_ENCODE_512MB (29 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_1GB (30 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_2GB (31 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> -#define HUGETLB_FLAG_ENCODE_16GB (34 <<
> HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_16GB (UINT32_C(34) <<
> HUGETLB_FLAG_ENCODE_SHIFT)
And if there is a literal problem here, it can't be solved like this:
UINT32_C is a Cism which has no analogue in the kernel because we don't
pull in the /usr/include headers where it is defined. Usually in the
kernel we solve this by making the literal type explicit, like 34U, but
as I said above, I don't see a problem that this would solve.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-29 1:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-28 10:33 [PATCH] mm/hugetlb: ensure signedness of large numbers isidentical
2019-12-28 10:33 ` isidentical
2019-12-29 1:31 ` James Bottomley
2019-12-29 1:31 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox