From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ Date: Mon, 13 May 2013 10:40:05 +0100 Message-ID: <15932.1368438005@warthog.procyon.org.uk> References: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> <1368293689-16410-1-git-send-email-jiang.liu@huawei.com> Return-path: In-Reply-To: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> Sender: owner-linux-mm@kvack.org To: Jiang Liu Cc: dhowells@redhat.com, Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Haavard Skinnemoen List-Id: linux-arch.vger.kernel.org Jiang Liu wrote: > -#ifndef HZ > +#ifndef __KERNEL__ > + /* > + * Technically, this is wrong, but some old apps still refer to it. > + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). > + */ > # define HZ 100 > #endif Better still, use asm-generic/param.h and uapi/asm-generic/param.h for AVR32 instead. David -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:24532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022Ab3EMJkl (ORCPT ); Mon, 13 May 2013 05:40:41 -0400 From: David Howells In-Reply-To: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> References: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> <1368293689-16410-1-git-send-email-jiang.liu@huawei.com> Subject: Re: [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ Date: Mon, 13 May 2013 10:40:05 +0100 Message-ID: <15932.1368438005@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jiang Liu Cc: dhowells@redhat.com, Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Haavard Skinnemoen Message-ID: <20130513094005.mlGeVT7CTZBu23tQ7iL_hbOsS8WvwUfo_xcDKpob0i0@z> Jiang Liu wrote: > -#ifndef HZ > +#ifndef __KERNEL__ > + /* > + * Technically, this is wrong, but some old apps still refer to it. > + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). > + */ > # define HZ 100 > #endif Better still, use asm-generic/param.h and uapi/asm-generic/param.h for AVR32 instead. David